Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PASE PasscodeId to Always be 0 to Match Spec #15924

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Updated PASE PasscodeId to Always be 0 to Match Spec #15924

merged 1 commit into from
Mar 10, 2022

Conversation

emargolis
Copy link
Contributor

Problem

#15735

The spec was updated to force PasscodeId to be always zero for v1.0. It should also be removed from OpenCommissioningWindow command.

Change overview

-- Removed PasscodeId from all APIs.
-- When opening an ECM window, the passcodeID to use in PASE PBKDFParamRequest is always 0.
-- Non-zero values of passcodeID in PASE PBKDFParamRequest are forbidden.
-- Removed PasscodeId field in OpenCommissioningWindow command needs.

Testing

Existing tests

@emargolis emargolis force-pushed the emargolis/feature/remove-passcodeid branch from 9385594 to 1c0b311 Compare March 8, 2022 00:33
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15924: Size comparison from d8c337f to 1c0b311

Increases (1 build for mbed)
platform target config section d8c337f 1c0b311 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350980 2351020 40 0.0
.text 1313580 1313620 40 0.0
Decreases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section d8c337f 1c0b311 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602062 602034 -28 -0.0
.app_xip_area 506596 506568 -28 -0.0
lock cyw930739m2evb_01 (read/write) 559982 559954 -28 -0.0
.app_xip_area 466052 466024 -28 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 582170 582142 -28 -0.0
.app_xip_area 478560 478532 -28 -0.0
efr32 lighting-app BRD4161A (read only) 921196 921164 -32 -0.0
.text 921188 921156 -32 -0.0
BRD4161A+rpc (read only) 950032 949984 -48 -0.0
.text 950024 949976 -48 -0.0
window-app BRD4161A (read only) 854224 854176 -48 -0.0
.text 854216 854168 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957614 957550 -64 -0.0
.flash.text 957614 957550 -64 -0.0
m5stack (read only) 1012475 1012415 -60 -0.0
.flash.text 1007091 1007031 -60 -0.0
k32w light k32w061+release (read/write) 694956 694924 -32 -0.0
.text 609488 609456 -32 -0.0
lock k32w061+release (read/write) 696560 696512 -48 -0.0
.text 611116 611068 -48 -0.0
linux all-clusters-app debug (read only) 2427697 2427521 -176 -0.0
.text 2059058 2058882 -176 -0.0
bridge-app debug+rpc (read only) 1732725 1732501 -224 -0.0
.rodata 141748 141716 -32 -0.0
.text 1474837 1474645 -192 -0.0
chip-tool debug (read only) 9761509 9761253 -256 -0.0
.rodata 510868 510836 -32 -0.0
.text 8510965 8510741 -224 -0.0
chip-tool-ipv6only arm64 (read only) 9433156 9433028 -128 -0.0
.rodata 486604 486588 -16 -0.0
.text 7942308 7942196 -112 -0.0
door-lock-app debug (read only) 1947049 1946857 -192 -0.0
.text 1624578 1624386 -192 -0.0
lighting-app debug+rpc (read only) 2079121 2078929 -192 -0.0
.text 1757490 1757298 -192 -0.0
ota-provider-app debug (read only) 1879905 1879889 -16 -0.0
.text 1570114 1570098 -16 -0.0
ota-requestor-app debug (read only) 1901905 1901681 -224 -0.0
.rodata 154188 154156 -32 -0.0
.text 1597490 1597298 -192 -0.0
shell debug (read only) 2394481 2394289 -192 -0.0
.text 2032114 2031922 -192 -0.0
thermostat-no-ble arm64 (read only) 2175540 2175508 -32 -0.0
.text 1823904 1823872 -32 -0.0
tv-app debug (read only) 2620025 2619721 -304 -0.0
.text 2246194 2245890 -304 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151915 1151883 -32 -0.0
text 785584 785552 -32 -0.0
p6 all-clusters-app default (read/write) 2494368 2494320 -48 -0.0
.text 1452632 1452584 -48 -0.0
light-app default (read/write) 2397816 2397768 -48 -0.0
.text 1356080 1356032 -48 -0.0
lock-app default (read/write) 2361248 2361200 -48 -0.0
.text 1319512 1319464 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 889050 888998 -52 -0.0
text 628374 628328 -46 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d8c337f 1c0b311 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602062 602034 -28 -0.0
.app_xip_area 506596 506568 -28 -0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559982 559954 -28 -0.0
.app_xip_area 466052 466024 -28 -0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582170 582142 -28 -0.0
.app_xip_area 478560 478532 -28 -0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921196 921164 -32 -0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 921188 921156 -32 -0.0
BRD4161A+rpc (read only) 950032 949984 -48 -0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 950024 949976 -48 -0.0
window-app BRD4161A (read only) 854224 854176 -48 -0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 854216 854168 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957614 957550 -64 -0.0
(read/write) 1393658 1393658 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197072 197072 0 0.0
.flash.text 957614 957550 -64 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012475 1012415 -60 -0.0
(read/write) 460764 460764 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225888 225888 0 0.0
.flash.text 1007091 1007031 -60 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694956 694924 -32 -0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609488 609456 -32 -0.0
lock k32w061+release (read/write) 696560 696512 -48 -0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 611116 611068 -48 -0.0
linux all-clusters-app debug (read only) 2427697 2427521 -176 -0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205509 205509 0 0.0
.text 2059058 2058882 -176 -0.0
bridge-app debug+rpc (read only) 1732725 1732501 -224 -0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141716 -32 -0.0
.text 1474837 1474645 -192 -0.0
chip-tool debug (read only) 9761509 9761253 -256 -0.0
(read/write) 338776 338776 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 306048 306048 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510836 -32 -0.0
.text 8510965 8510741 -224 -0.0
chip-tool-ipv6only arm64 (read only) 9433156 9433028 -128 -0.0
(read/write) 454433 454433 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351216 351216 0 0.0
.dynamic 560 560 0 0.0
.got 54376 54376 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486604 486588 -16 -0.0
.text 7942308 7942196 -112 -0.0
door-lock-app debug (read only) 1947049 1946857 -192 -0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1624578 1624386 -192 -0.0
lighting-app debug+rpc (read only) 2079121 2078929 -192 -0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165852 165852 0 0.0
.text 1757490 1757298 -192 -0.0
ota-provider-app debug (read only) 1879905 1879889 -16 -0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1570114 1570098 -16 -0.0
ota-requestor-app debug (read only) 1901905 1901681 -224 -0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154188 154156 -32 -0.0
.text 1597490 1597298 -192 -0.0
shell debug (read only) 2394481 2394289 -192 -0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205458 205458 0 0.0
.text 2032114 2031922 -192 -0.0
thermostat-no-ble arm64 (read only) 2175540 2175508 -32 -0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823904 1823872 -32 -0.0
tv-app debug (read only) 2620025 2619721 -304 -0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199549 199549 0 0.0
.text 2246194 2245890 -304 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350980 2351020 40 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313580 1313620 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151915 1151883 -32 -0.0
bss 146792 146792 0 0.0
rodata 144340 144340 0 0.0
text 785584 785552 -32 -0.0
p6 all-clusters-app default (read/write) 2494368 2494320 -48 -0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452632 1452584 -48 -0.0
light-app default (read/write) 2397816 2397768 -48 -0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1356080 1356032 -48 -0.0
lock-app default (read/write) 2361248 2361200 -48 -0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319512 1319464 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 889050 888998 -52 -0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628374 628328 -46 -0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the emargolis/feature/remove-passcodeid branch from 1c0b311 to 5318f43 Compare March 8, 2022 04:20
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15924: Size comparison from 1f458a5 to 5318f43

Increases (1 build for mbed)
platform target config section 1f458a5 5318f43 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350812 2350908 96 0.0
.text 1313412 1313508 96 0.0
Decreases (17 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 1f458a5 5318f43 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601742 -28 -0.0
.app_xip_area 506312 506284 -28 -0.0
lock cyw930739m2evb_01 (read/write) 559690 559662 -28 -0.0
.app_xip_area 465768 465740 -28 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581850 -28 -0.0
.app_xip_area 478276 478248 -28 -0.0
efr32 lighting-app BRD4161A (read only) 920868 920820 -48 -0.0
.text 920860 920812 -48 -0.0
BRD4161A+rpc (read only) 949688 949656 -32 -0.0
.text 949680 949648 -32 -0.0
window-app BRD4161A (read only) 853888 853840 -48 -0.0
.text 853880 853832 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957534 957470 -64 -0.0
.flash.text 957534 957470 -64 -0.0
m5stack (read only) 1012295 1012231 -64 -0.0
.flash.text 1006911 1006847 -64 -0.0
k32w light k32w061+release (read/write) 694820 694788 -32 -0.0
.text 609352 609320 -32 -0.0
lock k32w061+release (read/write) 696424 696392 -32 -0.0
.text 610980 610948 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430420 -128 -0.0
.rodata 486556 486540 -16 -0.0
.text 7940244 7940132 -112 -0.0
thermostat-no-ble arm64 (read only) 2174612 2174596 -16 -0.0
.text 1823312 1823296 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151763 -32 -0.0
text 785512 785476 -36 -0.0
p6 all-clusters-app default (read/write) 2494064 2494016 -48 -0.0
.text 1452328 1452280 -48 -0.0
light-app default (read/write) 2397504 2397456 -48 -0.0
.text 1355768 1355720 -48 -0.0
lock-app default (read/write) 2360936 2360888 -48 -0.0
.text 1319200 1319152 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 888894 -52 -0.0
text 628306 628260 -46 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f458a5 5318f43 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601742 -28 -0.0
.app_xip_area 506312 506284 -28 -0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559690 559662 -28 -0.0
.app_xip_area 465768 465740 -28 -0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581850 -28 -0.0
.app_xip_area 478276 478248 -28 -0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920820 -48 -0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920812 -48 -0.0
BRD4161A+rpc (read only) 949688 949656 -32 -0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949648 -32 -0.0
window-app BRD4161A (read only) 853888 853840 -48 -0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853832 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957534 957470 -64 -0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957534 957470 -64 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012295 1012231 -64 -0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006911 1006847 -64 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694820 694788 -32 -0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609352 609320 -32 -0.0
lock k32w061+release (read/write) 696424 696392 -32 -0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610980 610948 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430420 -128 -0.0
(read/write) 454177 454177 0 0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 351000 0 0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486540 -16 -0.0
.text 7940244 7940132 -112 -0.0
thermostat-no-ble arm64 (read only) 2174612 2174596 -16 -0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1823296 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350812 2350908 96 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313412 1313508 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151763 -32 -0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785512 785476 -36 -0.0
p6 all-clusters-app default (read/write) 2494064 2494016 -48 -0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452280 -48 -0.0
light-app default (read/write) 2397504 2397456 -48 -0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355720 -48 -0.0
lock-app default (read/write) 2360936 2360888 -48 -0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319152 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 888894 -52 -0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628306 628260 -46 -0.0

@emargolis emargolis force-pushed the emargolis/feature/remove-passcodeid branch from 5318f43 to f62be0a Compare March 8, 2022 06:40
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15924: Size comparison from 1f458a5 to f62be0a

Increases (1 build for mbed)
platform target config section 1f458a5 f62be0a change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350812 2350908 96 0.0
.text 1313412 1313508 96 0.0
Decreases (17 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 1f458a5 f62be0a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601742 -28 -0.0
.app_xip_area 506312 506284 -28 -0.0
lock cyw930739m2evb_01 (read/write) 559690 559662 -28 -0.0
.app_xip_area 465768 465740 -28 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581850 -28 -0.0
.app_xip_area 478276 478248 -28 -0.0
efr32 lighting-app BRD4161A (read only) 920868 920820 -48 -0.0
.text 920860 920812 -48 -0.0
BRD4161A+rpc (read only) 949688 949656 -32 -0.0
.text 949680 949648 -32 -0.0
window-app BRD4161A (read only) 853888 853840 -48 -0.0
.text 853880 853832 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957534 957470 -64 -0.0
.flash.text 957534 957470 -64 -0.0
m5stack (read only) 1012295 1012231 -64 -0.0
.flash.text 1006911 1006847 -64 -0.0
k32w light k32w061+release (read/write) 694820 694788 -32 -0.0
.text 609352 609320 -32 -0.0
lock k32w061+release (read/write) 696424 696392 -32 -0.0
.text 610980 610948 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430420 -128 -0.0
.rodata 486556 486540 -16 -0.0
.text 7940244 7940132 -112 -0.0
thermostat-no-ble arm64 (read only) 2174612 2174596 -16 -0.0
.text 1823312 1823296 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151763 -32 -0.0
text 785512 785476 -36 -0.0
p6 all-clusters-app default (read/write) 2494064 2494016 -48 -0.0
.text 1452328 1452280 -48 -0.0
light-app default (read/write) 2397504 2397456 -48 -0.0
.text 1355768 1355720 -48 -0.0
lock-app default (read/write) 2360936 2360888 -48 -0.0
.text 1319200 1319152 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 888894 -52 -0.0
text 628306 628260 -46 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f458a5 f62be0a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601742 -28 -0.0
.app_xip_area 506312 506284 -28 -0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559690 559662 -28 -0.0
.app_xip_area 465768 465740 -28 -0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581850 -28 -0.0
.app_xip_area 478276 478248 -28 -0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920820 -48 -0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920812 -48 -0.0
BRD4161A+rpc (read only) 949688 949656 -32 -0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949648 -32 -0.0
window-app BRD4161A (read only) 853888 853840 -48 -0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853832 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957534 957470 -64 -0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957534 957470 -64 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012295 1012231 -64 -0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006911 1006847 -64 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694820 694788 -32 -0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609352 609320 -32 -0.0
lock k32w061+release (read/write) 696424 696392 -32 -0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610980 610948 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430420 -128 -0.0
(read/write) 454177 454177 0 0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 351000 0 0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486540 -16 -0.0
.text 7940244 7940132 -112 -0.0
thermostat-no-ble arm64 (read only) 2174612 2174596 -16 -0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1823296 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350812 2350908 96 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313412 1313508 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151763 -32 -0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785512 785476 -36 -0.0
p6 all-clusters-app default (read/write) 2494064 2494016 -48 -0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452280 -48 -0.0
light-app default (read/write) 2397504 2397456 -48 -0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355720 -48 -0.0
lock-app default (read/write) 2360936 2360888 -48 -0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319152 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 888894 -52 -0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628306 628260 -46 -0.0

@emargolis emargolis force-pushed the emargolis/feature/remove-passcodeid branch from f62be0a to 0f8ff2c Compare March 9, 2022 21:36
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

PR #15924: Size comparison from 475c710 to 0f8ff2c

Increases (1 build for mbed)
platform target config section 475c710 0f8ff2c change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351892 2351924 32 0.0
.text 1314492 1314524 32 0.0
Decreases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 475c710 0f8ff2c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602202 602174 -28 -0.0
.app_xip_area 506720 506692 -28 -0.0
lock cyw930739m2evb_01 (read/write) 560078 560050 -28 -0.0
.app_xip_area 466132 466104 -28 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 570466 570438 -28 -0.0
.app_xip_area 466816 466788 -28 -0.0
efr32 lighting-app BRD4161A (read only) 922528 922480 -48 -0.0
.text 922520 922472 -48 -0.0
BRD4161A+rpc (read only) 951356 951324 -32 -0.0
.text 951348 951316 -32 -0.0
window-app BRD4161A (read only) 854412 854364 -48 -0.0
.text 854404 854356 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 958694 958630 -64 -0.0
.flash.text 958694 958630 -64 -0.0
m5stack (read only) 1013715 1013655 -60 -0.0
.flash.text 1008331 1008271 -60 -0.0
k32w light k32w061+release (read/write) 696508 696476 -32 -0.0
.text 610992 610960 -32 -0.0
lock k32w061+release (read/write) 697016 696984 -32 -0.0
.text 611548 611516 -32 -0.0
linux all-clusters-app debug (read only) 2432289 2432097 -192 -0.0
.text 2063538 2063346 -192 -0.0
bridge-app debug+rpc (read only) 1737061 1736853 -208 -0.0
.rodata 141964 141932 -32 -0.0
.text 1479125 1478949 -176 -0.0
chip-tool debug (read only) 9943877 9943669 -208 -0.0
.text 8648725 8648517 -208 -0.0
chip-tool-ipv6only arm64 (read only) 9592140 9592028 -112 -0.0
.rodata 490468 490452 -16 -0.0
.text 8054516 8054420 -96 -0.0
door-lock-app debug (read only) 1951521 1951297 -224 -0.0
.rodata 173852 173820 -32 -0.0
.text 1629026 1628834 -192 -0.0
lighting-app debug+rpc (read only) 2083689 2083497 -192 -0.0
.text 1761986 1761794 -192 -0.0
ota-provider-app debug (read only) 1884793 1884777 -16 -0.0
.text 1574978 1574962 -16 -0.0
ota-requestor-app debug (read only) 1912753 1912561 -192 -0.0
.text 1607186 1606994 -192 -0.0
shell debug (read only) 2398465 2398273 -192 -0.0
.text 2036178 2035986 -192 -0.0
thermostat-no-ble arm64 (read only) 2180428 2180396 -32 -0.0
.text 1828608 1828576 -32 -0.0
tv-app debug (read only) 2624313 2623977 -336 -0.0
.rodata 199485 199453 -32 -0.0
.text 2250738 2250434 -304 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153579 1153547 -32 -0.0
text 786964 786928 -36 -0.0
p6 all-clusters-app default (read/write) 2495488 2495440 -48 -0.0
.text 1453752 1453704 -48 -0.0
light-app default (read/write) 2398960 2398912 -48 -0.0
.text 1357224 1357176 -48 -0.0
lock-app default (read/write) 2362520 2362472 -48 -0.0
.text 1320784 1320736 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 889826 889774 -52 -0.0
text 629098 629052 -46 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 475c710 0f8ff2c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602202 602174 -28 -0.0
.app_xip_area 506720 506692 -28 -0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560078 560050 -28 -0.0
.app_xip_area 466132 466104 -28 -0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570466 570438 -28 -0.0
.app_xip_area 466816 466788 -28 -0.0
.bss 86060 86060 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922528 922480 -48 -0.0
(read/write) 128896 128896 0 0.0
.bss 126856 126856 0 0.0
.data 2040 2040 0 0.0
.text 922520 922472 -48 -0.0
BRD4161A+rpc (read only) 951356 951324 -32 -0.0
(read/write) 144852 144852 0 0.0
.bss 142632 142632 0 0.0
.data 2220 2220 0 0.0
.text 951348 951316 -32 -0.0
window-app BRD4161A (read only) 854412 854364 -48 -0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854404 854356 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 958694 958630 -64 -0.0
(read/write) 1393802 1393802 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197088 197088 0 0.0
.flash.text 958694 958630 -64 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1013715 1013655 -60 -0.0
(read/write) 461052 461052 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226056 226056 0 0.0
.flash.text 1008331 1008271 -60 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 696508 696476 -32 -0.0
.bss 77792 77792 0 0.0
.data 1924 1924 0 0.0
.text 610992 610960 -32 -0.0
lock k32w061+release (read/write) 697016 696984 -32 -0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611548 611516 -32 -0.0
linux all-clusters-app debug (read only) 2432289 2432097 -192 -0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205765 205765 0 0.0
.text 2063538 2063346 -192 -0.0
bridge-app debug+rpc (read only) 1737061 1736853 -208 -0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 141932 -32 -0.0
.text 1479125 1478949 -176 -0.0
chip-tool debug (read only) 9943877 9943669 -208 -0.0
(read/write) 357400 357400 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 324584 324584 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 514388 0 0.0
.text 8648725 8648517 -208 -0.0
chip-tool-ipv6only arm64 (read only) 9592140 9592028 -112 -0.0
(read/write) 474241 474241 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 370560 370560 0 0.0
.dynamic 560 560 0 0.0
.got 54728 54728 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 490468 490452 -16 -0.0
.text 8054516 8054420 -96 -0.0
door-lock-app debug (read only) 1951521 1951297 -224 -0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173852 173820 -32 -0.0
.text 1629026 1628834 -192 -0.0
lighting-app debug+rpc (read only) 2083689 2083497 -192 -0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166044 166044 0 0.0
.text 1761986 1761794 -192 -0.0
ota-provider-app debug (read only) 1884793 1884777 -16 -0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 159091 0 0.0
.text 1574978 1574962 -16 -0.0
ota-requestor-app debug (read only) 1912753 1912561 -192 -0.0
(read/write) 117864 117864 0 0.0
.bss 51584 51584 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155052 155052 0 0.0
.text 1607186 1606994 -192 -0.0
shell debug (read only) 2398465 2398273 -192 -0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205714 205714 0 0.0
.text 2036178 2035986 -192 -0.0
thermostat-no-ble arm64 (read only) 2180428 2180396 -32 -0.0
(read/write) 148833 148833 0 0.0
.bss 65409 65409 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133228 133228 0 0.0
.text 1828608 1828576 -32 -0.0
tv-app debug (read only) 2624313 2623977 -336 -0.0
(read/write) 251000 251000 0 0.0
.bss 168160 168160 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199485 199453 -32 -0.0
.text 2250738 2250434 -304 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351892 2351924 32 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1314492 1314524 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153579 1153547 -32 -0.0
bss 146856 146856 0 0.0
rodata 144516 144516 0 0.0
text 786964 786928 -36 -0.0
p6 all-clusters-app default (read/write) 2495488 2495440 -48 -0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453752 1453704 -48 -0.0
light-app default (read/write) 2398960 2398912 -48 -0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357224 1357176 -48 -0.0
lock-app default (read/write) 2362520 2362472 -48 -0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320784 1320736 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 889826 889774 -52 -0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 629098 629052 -46 -0.0

@emargolis
Updated PASE PasscodeId to Always be 0 to Match Spec
965461d 
  -- Removed PasscodeId from all APIs.
  -- When opening an ECM window, the passcodeID to use in PASE PBKDFParamRequest is always 0.
  -- Non-zero values of passcodeID in PASE PBKDFParamRequest are forbidden.
  -- Removed PasscodeId field in OpenCommissioningWindow command needs.
@emargolis emargolis force-pushed the emargolis/feature/remove-passcodeid branch from 0f8ff2c to 965461d Compare March 9, 2022 23:24
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

PR #15924: Size comparison from 190520d to 965461d

Increases (1 build for mbed)
platform target config section 190520d 965461d change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351356 2351388 32 0.0
.text 1313956 1313988 32 0.0
Decreases (25 builds for cyw30739, efr32, esp32, k32w, linux, p6, telink)
platform target config section 190520d 965461d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598058 598026 -32 -0.0
.app_xip_area 505640 505608 -32 -0.0
lock cyw930739m2evb_01 (read/write) 555926 555894 -32 -0.0
.app_xip_area 465044 465012 -32 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 566030 565998 -32 -0.0
.app_xip_area 465444 465412 -32 -0.0
efr32 lighting-app BRD4161A (read only) 919872 919824 -48 -0.0
.text 919864 919816 -48 -0.0
BRD4161A+rpc (read only) 948700 948652 -48 -0.0
.text 948692 948644 -48 -0.0
window-app BRD4161A (read only) 852348 852300 -48 -0.0
.text 852340 852292 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957736 957672 -64 -0.0
.flash.text 957736 957672 -64 -0.0
m5stack (read only) 1012887 1012855 -32 -0.0
.flash.text 1007503 1007471 -32 -0.0
k32w light k32w061+release (read/write) 694492 694460 -32 -0.0
.text 609608 609576 -32 -0.0
lock k32w061+release (read/write) 695292 695260 -32 -0.0
.text 610456 610424 -32 -0.0
linux all-clusters-app debug (read only) 2430321 2430129 -192 -0.0
.text 2061698 2061506 -192 -0.0
bridge-app debug+rpc (read only) 1735493 1735269 -224 -0.0
.rodata 141868 141836 -32 -0.0
.text 1477653 1477461 -192 -0.0
chip-tool debug (read only) 10093045 10092821 -224 -0.0
.text 8796165 8795941 -224 -0.0
chip-tool-ipv6only arm64 (read only) 9729052 9728940 -112 -0.0
.rodata 491908 491892 -16 -0.0
.text 8185956 8185860 -96 -0.0
door-lock-app debug (read only) 1949953 1949713 -240 -0.0
.rodata 173756 173724 -32 -0.0
.text 1627554 1627346 -208 -0.0
lighting-app debug+rpc (read only) 2082121 2081913 -208 -0.0
.text 1760514 1760306 -208 -0.0
ota-provider-app debug (read only) 1883193 1883161 -32 -0.0
.text 1573506 1573474 -32 -0.0
ota-requestor-app debug (read only) 1910801 1910609 -192 -0.0
.text 1605362 1605170 -192 -0.0
shell debug (read only) 2396513 2396305 -208 -0.0
.text 2034354 2034146 -208 -0.0
thermostat-no-ble arm64 (read only) 2178620 2178588 -32 -0.0
.text 1826912 1826880 -32 -0.0
tv-app debug (read only) 2622009 2621705 -304 -0.0
.rodata 199293 199261 -32 -0.0
.text 2248626 2248354 -272 -0.0
p6 all-clusters-app default (read/write) 2494216 2494184 -32 -0.0
.text 1452480 1452448 -32 -0.0
light-app default (read/write) 2398296 2398248 -48 -0.0
.text 1356560 1356512 -48 -0.0
lock-app default (read/write) 2361856 2361808 -48 -0.0
.text 1320120 1320072 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 888882 888838 -44 -0.0
text 628184 628138 -46 -0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 190520d 965461d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598058 598026 -32 -0.0
.app_xip_area 505640 505608 -32 -0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555926 555894 -32 -0.0
.app_xip_area 465044 465012 -32 -0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566030 565998 -32 -0.0
.app_xip_area 465444 465412 -32 -0.0
.bss 82996 82996 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919872 919824 -48 -0.0
(read/write) 128264 128264 0 0.0
.bss 126224 126224 0 0.0
.data 2040 2040 0 0.0
.text 919864 919816 -48 -0.0
BRD4161A+rpc (read only) 948700 948652 -48 -0.0
(read/write) 144220 144220 0 0.0
.bss 142000 142000 0 0.0
.data 2220 2220 0 0.0
.text 948692 948644 -48 -0.0
window-app BRD4161A (read only) 852348 852300 -48 -0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852340 852292 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 957736 957672 -64 -0.0
(read/write) 1393778 1393778 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197064 197064 0 0.0
.flash.text 957736 957672 -64 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012887 1012855 -32 -0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1007503 1007471 -32 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694492 694460 -32 -0.0
.bss 77160 77160 0 0.0
.data 1924 1924 0 0.0
.text 609608 609576 -32 -0.0
lock k32w061+release (read/write) 695292 695260 -32 -0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610456 610424 -32 -0.0
linux all-clusters-app debug (read only) 2430321 2430129 -192 -0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205637 205637 0 0.0
.text 2061698 2061506 -192 -0.0
bridge-app debug+rpc (read only) 1735493 1735269 -224 -0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141868 141836 -32 -0.0
.text 1477653 1477461 -192 -0.0
chip-tool debug (read only) 10093045 10092821 -224 -0.0
(read/write) 358168 358168 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514196 514196 0 0.0
.text 8796165 8795941 -224 -0.0
chip-tool-ipv6only arm64 (read only) 9729052 9728940 -112 -0.0
(read/write) 475969 475969 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55304 55304 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491908 491892 -16 -0.0
.text 8185956 8185860 -96 -0.0
door-lock-app debug (read only) 1949953 1949713 -240 -0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173756 173724 -32 -0.0
.text 1627554 1627346 -208 -0.0
lighting-app debug+rpc (read only) 2082121 2081913 -208 -0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165948 165948 0 0.0
.text 1760514 1760306 -208 -0.0
ota-provider-app debug (read only) 1883193 1883161 -32 -0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158963 158963 0 0.0
.text 1573506 1573474 -32 -0.0
ota-requestor-app debug (read only) 1910801 1910609 -192 -0.0
(read/write) 117864 117864 0 0.0
.bss 51584 51584 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154924 154924 0 0.0
.text 1605362 1605170 -192 -0.0
shell debug (read only) 2396513 2396305 -208 -0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205586 205586 0 0.0
.text 2034354 2034146 -208 -0.0
thermostat-no-ble arm64 (read only) 2178620 2178588 -32 -0.0
(read/write) 148817 148817 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133116 133116 0 0.0
.text 1826912 1826880 -32 -0.0
tv-app debug (read only) 2622009 2621705 -304 -0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199293 199261 -32 -0.0
.text 2248626 2248354 -272 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351356 2351388 32 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1313956 1313988 32 0.0
p6 all-clusters-app default (read/write) 2494216 2494184 -32 -0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452480 1452448 -32 -0.0
light-app default (read/write) 2398296 2398248 -48 -0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356560 1356512 -48 -0.0
lock-app default (read/write) 2361856 2361808 -48 -0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320120 1320072 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 888882 888838 -44 -0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628184 628138 -46 -0.0

@emargolis emargolis merged commit 2727739 into project-chip:master Mar 10, 2022
@emargolis emargolis mentioned this pull request Mar 10, 2022
Closed
ajwak added a commit to ajwak/connectedhomeip that referenced this pull request Jul 11, 2022
@ajwak
Remove Integer from PaseVerifierParams constructor
1923dc9 
The spec was updated to force PasscodeId to be always zero for v1.0, and this was updated in project-chip#15924. This change removes it from the corresponding JNI constructor which was missed in the original fix.
This was referenced Jul 11, 2022
Closed
Closed
@ajwak ajwak mentioned this pull request Jul 19, 2022
Merged
@woody-apple woody-apple mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @woody-apple @bzbarsky-apple @Damian-Nordic