-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Fabric removal sync #15874
Merged
jepenven-silabs
merged 3 commits into
project-chip:master
from
jepenven-silabs:group_fabric_removal
Mar 8, 2022
Merged
[Group] Fabric removal sync #15874
jepenven-silabs
merged 3 commits into
project-chip:master
from
jepenven-silabs:group_fabric_removal
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
mlepage-google
March 4, 2022 18:26
pullapprove
bot
requested review from
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 4, 2022 18:26
PR #15874: Size comparison from 40c9fd5 to ed8901f Increases above 0.2%:
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
woody-apple
approved these changes
Mar 4, 2022
bzbarsky-apple
requested changes
Mar 5, 2022
jmartinez-silabs
approved these changes
Mar 7, 2022
jepenven-silabs
force-pushed
the
group_fabric_removal
branch
from
March 7, 2022 21:34
96ac460
to
fe8e6d8
Compare
PR #15874: Size comparison from c0373bb to fe8e6d8 Increases above 0.2%:
Increases (7 builds for linux, mbed, p6, telink)
Decreases (5 builds for linux, mbed, p6)
Full report (7 builds for linux, mbed, p6, telink)
|
jepenven-silabs
force-pushed
the
group_fabric_removal
branch
from
March 8, 2022 15:53
fe8e6d8
to
43e16a9
Compare
PR #15874: Size comparison from 2822511 to 43e16a9 Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (20 builds for cyw30739, efr32, esp32, k32w, linux, p6)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 8, 2022
tcarmelveilleux
approved these changes
Mar 8, 2022
PR #15874: Size comparison from 2822511 to c77f145 Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (20 builds for cyw30739, efr32, esp32, k32w, linux, p6)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix #15166
Change overview
Added a fabric listener to update various object upon FabricIndex removal.
Testing
Unit Test and Test suite