Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AC_DEFINE description message to align with macro define value #1580

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fix AC_DEFINE description message to align with macro define value #1580

merged 1 commit into from
Jul 14, 2020

Conversation

yufengwangca
Copy link
Contributor

Problem
Some AC_DEFINE description messages do not match with macro define value, such as:
AC_DEFINE([CHIP_WITH_OPENSSL], [0], [Define to 1 to build CHIP with OpenSSL])

Summary of Changes

  • Fix AC_DEFINE description message to align with macro define value

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@woody-apple woody-apple merged commit d3c22b9 into project-chip:master Jul 14, 2020
@yufengwangca yufengwangca deleted the pr/linux/configure branch July 14, 2020 22:42
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@yufengwangca @kedars
Fix AC_DEFINE description message to align with macro define value (p…
39f9b7b 
…roject-chip#1580)
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@yufengwangca @kedars
Fix AC_DEFINE description message to align with macro define value (p…
1285485 
…roject-chip#1580)
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@yufengwangca @kedars
Fix AC_DEFINE description message to align with macro define value (p…
7b1cb9c 
…roject-chip#1580)
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@yufengwangca @kedars
Fix AC_DEFINE description message to align with macro define value (p…
aadae68 
…roject-chip#1580)
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@yufengwangca @kedars
Fix AC_DEFINE description message to align with macro define value (p…
37d58ad 
…roject-chip#1580)
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#1580: Cherry-pick: Pull request project-chi…
597e424 
…p#1560 & project-chip#1485 SMG RC_2.3.0-1.3-alpha.2 Doc updates

Merge in WMN_TOOLS/matter from cherry-pick/smg_2.3.0-1.3-alpha.2_doc_updates to silabs

Squashed commit of the following:

commit 53c2d49718e63158ea7e58fe0c19c0e31df11ffc
Author: Curtis Rahman <[email protected]>
Date:   Tue Feb 20 16:23:47 2024 -0500

    Further doc corrections

commit 4217ecc0244f20c76a4db90ff74385f398d14fed
Author: Curtis Rahman <[email protected]>
Date:   Tue Feb 13 18:10:17 2024 +0000

    Pull request project-chip#1560: [Documentation] MATTER-3043 SMG Release Documentation

    Merge in WMN_TOOLS/matter from documentation/smg_release_2.3.0-1.3-alpha.2 to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 57654c1e7894a1cc062caeec0963dc18f165d7e5
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Feb 13 10:26:23 2024 -0500

        Addressed PR comments

    commit ea2d2aa653bd027bb23b1362153e2a78c45b58ab
    Author: Mathieu Kardous <[email protected]>
    Date:   Tue Feb 13 14:56:11 2024 +0000

        Applied suggestion

    commit a263ddcccde41982506703ac4015e4766dc85553
    Author: Mathieu Kardous <[email protected]>
    Date:   Tue Feb 13 14:56:01 2024 +0000

        Applied suggestion

    ... and 13 more commits

commit 6db47039b77cd115daeac04ff48000e8a7a9222f
Author: Curtis Rahman <[email protected]>
Date:   Tue Jan 16 18:19:15 2024 +0000

    Pull request project-chip#1485: [Documentation] Update Version and Artifacts

    Merge in WMN_TOOLS/matter from documentation/update_version_v2.3.0-1.3-alpha to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 9005561ab2d421afb0248913bff0fcc8efd5bfe9
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 13:16:00 2024 -0500

        Syntax

    commit 1a0ee3bc54f5a302b480b08b5709a0d7752e1102
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 13:12:00 2024 -0500

        Removed quotes

    commit 0ab38f75baf3e5c3e8044ee67e62aada49552f0b
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 11:22:40 2024 -0500

        Added new features

    ... and 4 more commits
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#1580: Cherry-pick: Pull request project-chi…
4aa237b 
…p#1560 & project-chip#1485 SMG RC_2.3.0-1.3-alpha.2 Doc updates

Merge in WMN_TOOLS/matter from cherry-pick/smg_2.3.0-1.3-alpha.2_doc_updates to silabs

Squashed commit of the following:

commit 53c2d49718e63158ea7e58fe0c19c0e31df11ffc
Author: Curtis Rahman <[email protected]>
Date:   Tue Feb 20 16:23:47 2024 -0500

    Further doc corrections

commit 4217ecc0244f20c76a4db90ff74385f398d14fed
Author: Curtis Rahman <[email protected]>
Date:   Tue Feb 13 18:10:17 2024 +0000

    Pull request project-chip#1560: [Documentation] MATTER-3043 SMG Release Documentation

    Merge in WMN_TOOLS/matter from documentation/smg_release_2.3.0-1.3-alpha.2 to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 57654c1e7894a1cc062caeec0963dc18f165d7e5
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Feb 13 10:26:23 2024 -0500

        Addressed PR comments

    commit ea2d2aa653bd027bb23b1362153e2a78c45b58ab
    Author: Mathieu Kardous <[email protected]>
    Date:   Tue Feb 13 14:56:11 2024 +0000

        Applied suggestion

    commit a263ddcccde41982506703ac4015e4766dc85553
    Author: Mathieu Kardous <[email protected]>
    Date:   Tue Feb 13 14:56:01 2024 +0000

        Applied suggestion

    ... and 13 more commits

commit 6db47039b77cd115daeac04ff48000e8a7a9222f
Author: Curtis Rahman <[email protected]>
Date:   Tue Jan 16 18:19:15 2024 +0000

    Pull request project-chip#1485: [Documentation] Update Version and Artifacts

    Merge in WMN_TOOLS/matter from documentation/update_version_v2.3.0-1.3-alpha to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 9005561ab2d421afb0248913bff0fcc8efd5bfe9
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 13:16:00 2024 -0500

        Syntax

    commit 1a0ee3bc54f5a302b480b08b5709a0d7752e1102
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 13:12:00 2024 -0500

        Removed quotes

    commit 0ab38f75baf3e5c3e8044ee67e62aada49552f0b
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 11:22:40 2024 -0500

        Added new features

    ... and 4 more commits
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#1580: Cherry-pick: Pull request project-chi…
2c67729 
…p#1560 & project-chip#1485 SMG RC_2.3.0-1.3-alpha.2 Doc updates

Merge in WMN_TOOLS/matter from cherry-pick/smg_2.3.0-1.3-alpha.2_doc_updates to silabs

Squashed commit of the following:

commit 53c2d49718e63158ea7e58fe0c19c0e31df11ffc
Author: Curtis Rahman <[email protected]>
Date:   Tue Feb 20 16:23:47 2024 -0500

    Further doc corrections

commit 4217ecc0244f20c76a4db90ff74385f398d14fed
Author: Curtis Rahman <[email protected]>
Date:   Tue Feb 13 18:10:17 2024 +0000

    Pull request project-chip#1560: [Documentation] MATTER-3043 SMG Release Documentation

    Merge in WMN_TOOLS/matter from documentation/smg_release_2.3.0-1.3-alpha.2 to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 57654c1e7894a1cc062caeec0963dc18f165d7e5
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Feb 13 10:26:23 2024 -0500

        Addressed PR comments

    commit ea2d2aa653bd027bb23b1362153e2a78c45b58ab
    Author: Mathieu Kardous <[email protected]>
    Date:   Tue Feb 13 14:56:11 2024 +0000

        Applied suggestion

    commit a263ddcccde41982506703ac4015e4766dc85553
    Author: Mathieu Kardous <[email protected]>
    Date:   Tue Feb 13 14:56:01 2024 +0000

        Applied suggestion

    ... and 13 more commits

commit 6db47039b77cd115daeac04ff48000e8a7a9222f
Author: Curtis Rahman <[email protected]>
Date:   Tue Jan 16 18:19:15 2024 +0000

    Pull request project-chip#1485: [Documentation] Update Version and Artifacts

    Merge in WMN_TOOLS/matter from documentation/update_version_v2.3.0-1.3-alpha to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 9005561ab2d421afb0248913bff0fcc8efd5bfe9
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 13:16:00 2024 -0500

        Syntax

    commit 1a0ee3bc54f5a302b480b08b5709a0d7752e1102
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 13:12:00 2024 -0500

        Removed quotes

    commit 0ab38f75baf3e5c3e8044ee67e62aada49552f0b
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Jan 16 11:22:40 2024 -0500

        Added new features

    ... and 4 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @andy31415 @saurabhst @woody-apple