Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strongly Typed Bitmaps #15697

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Strongly Typed Bitmaps #15697

merged 1 commit into from
Mar 9, 2022

Conversation

mrjerryjohns
Copy link
Contributor

Problem

Switching some of the attributes in the test cluster of type BITMAP* to actually using the enum-like definition of the bitmap resulted in all kinds of compiler errors.

Solution

This adds support for strongly typed BITMAP* fields in the XML that in turn result in the use of the BitFlags type in the generated C++ code.

To correctly work this type for attributes, a specialization of NumericAttributeTraits has been added for BitFlags<T> to correctly handle the underlying storage type as well the special rule for nullability.

Some of other fix-ups to the chip-tool helpers were needed as well.

Tests:

  • Ensured the YAML tests for bitmaps still works.

@restyled-io restyled-io bot mentioned this pull request Mar 2, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15697: Size comparison from b250d9a to 2b8c1ea

Increases above 0.2%:

platform target config section b250d9a 2b8c1ea change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039415 1075735 36320 3.5
bss 125820 127672 1852 1.5
rodata 135904 141808 5904 4.3
text 700476 728836 28360 4.0
Increases (1 build for nrfconnect)
platform target config section b250d9a 2b8c1ea change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039415 1075735 36320 3.5
bss 125820 127672 1852 1.5
rodata 135904 141808 5904 4.3
text 700476 728836 28360 4.0
Decreases (1 build for esp32)
platform target config section b250d9a 2b8c1ea change % change
esp32 all-clusters-app m5stack (read only) 1005143 1005115 -28 -0.0
.flash.text 999759 999731 -28 -0.0
Full report (19 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section b250d9a 2b8c1ea change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600038 600038 0 0.0
.app_xip_area 504812 504812 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558026 558026 0 0.0
.app_xip_area 464336 464336 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578446 578446 0 0.0
.app_xip_area 475324 475324 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917028 917028 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917020 917020 0 0.0
BRD4161A+rpc (read only) 947112 947112 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947104 947104 0 0.0
lock-app BRD4161A+wf200 (read only) 986844 986844 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986836 986836 0 0.0
window-app BRD4161A (read only) 850956 850956 0 0.0
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850948 850948 0 0.0
esp32 all-clusters-app m5stack (read only) 1005143 1005115 -28 -0.0
(read/write) 458336 458336 0 0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999759 999731 -28 -0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692224 692224 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606948 606948 0 0.0
lock k32w061+release (read/write) 695584 695584 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610068 610068 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039415 1075735 36320 3.5
bss 125820 127672 1852 1.5
rodata 135904 141808 5904 4.3
text 700476 728836 28360 4.0
p6 all-clusters-app default (read/write) 2488688 2488688 0 0.0
.bss 118728 118728 0 0.0
.data 2696 2696 0 0.0
.text 1446952 1446952 0 0.0
light-app default (read/write) 2395896 2395896 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354160 1354160 0 0.0
lock-app default (read/write) 2359424 2359424 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317688 1317688 0 0.0
qpg lighting-app qpg6105+debug (read only) 601624 601624 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596304 596304 0 0.0
lock-app qpg6105+debug (read only) 567340 567340 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562020 562020 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883642 883642 0 0.0
bss 86400 86400 0 0.0
noinit 37160 37160 0 0.0
text 624426 624426 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Mar 2, 2022
View reviewed changes
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
@hubTab
Copy link
Contributor

hubTab commented Mar 2, 2022

I can confirm that I have rebased PR 15600 to your 15697 and scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug went through successfully.

scripts/examples/gn_build_example.sh examples/chip-tool out/debug/standalone fails with the following errors:

In file included from ../../../examples/chip-tool/main.cpp:27:
../../../examples/chip-tool/third_party/connectedhomeip/zzz_generated/chip-tool/zap-generated/test/Commands.h:66427:92: error: integer constant is so large that it is unsigned [-Werror]
66427 | static_cast<chip::BitFlagschip::app::Clusters::TestCluster::Bitmap64MaskMap>(18446744073709551614);
| ^~~~~~~~~~~~~~~~~~~~
../../../examples/chip-tool/third_party/connectedhomeip/zzz_generated/chip-tool/zap-generated/test/Commands.h:66477:92: error: integer constant is so large that it is unsigned [-Werror]
66477 | static_cast<chip::BitFlagschip::app::Clusters::TestCluster::Bitmap64MaskMap>(18446744073709551615);
| ^~~~~~~~~~~~~~~~~~~~
cc1plus: error: unrecognized command line option '-Wno-unknown-warning-option' [-Werror]
cc1plus: all warnings being treated as errors
[166/475] c++ obj/third_party/connectedhomeip/src/app/server/libCHIPAppServer.Dnssd.cpp.o
ninja: build stopped: subcommand failed.

@hubTab hubTab mentioned this pull request Mar 2, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15697: Size comparison from 40c9fd5 to 61bf373

Increases above 0.2%:

platform target config section 40c9fd5 61bf373 change % change
linux chip-tool debug (read only) 9511901 9662829 150928 1.6
(read/write) 330512 331280 768 0.2
.data.rel.ro 297792 298560 768 0.3
.text 8291029 8440037 149008 1.8
chip-tool-ipv6only arm64 (read only) 9201620 9340116 138496 1.5
(read/write) 443265 444993 1728 0.4
.data.rel.ro 342552 343704 1152 0.3
.got 51880 52456 576 1.1
.rodata 475004 476540 1536 0.3
.text 7748356 7881284 132928 1.7
Increases (2 builds for linux)
platform target config section 40c9fd5 61bf373 change % change
linux chip-tool debug (read only) 9511901 9662829 150928 1.6
(read/write) 330512 331280 768 0.2
.data.rel.ro 297792 298560 768 0.3
.text 8291029 8440037 149008 1.8
chip-tool-ipv6only arm64 (read only) 9201620 9340116 138496 1.5
(read/write) 443265 444993 1728 0.4
.data.rel.ro 342552 343704 1152 0.3
.got 51880 52456 576 1.1
.rodata 475004 476540 1536 0.3
.text 7748356 7881284 132928 1.7
Decreases (1 build for linux)
platform target config section 40c9fd5 61bf373 change % change
linux shell debug (read only) 2391761 2391745 -16 -0.0
.text 2029570 2029554 -16 -0.0
Full report (28 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 40c9fd5 61bf373 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600874 600874 0 0.0
.app_xip_area 505832 505832 0 0.0
.bss 77724 77724 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558794 558794 0 0.0
.app_xip_area 465288 465288 0 0.0
.bss 76228 76228 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 580738 580738 0 0.0
.app_xip_area 477560 477560 0 0.0
.bss 85548 85548 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920140 920140 0 0.0
(read/write) 128824 128824 0 0.0
.bss 126744 126744 0 0.0
.data 2080 2080 0 0.0
.text 920132 920132 0 0.0
BRD4161A+rpc (read only) 948944 948944 0 0.0
(read/write) 144784 144784 0 0.0
.bss 142520 142520 0 0.0
.data 2260 2260 0 0.0
.text 948936 948936 0 0.0
lock-app BRD4161A+wf200 (read only) 988428 988428 0 0.0
(read/write) 120352 120352 0 0.0
.bss 118420 118420 0 0.0
.data 1932 1932 0 0.0
.text 988420 988420 0 0.0
window-app BRD4161A (read only) 853424 853424 0 0.0
(read/write) 126824 126824 0 0.0
.bss 124896 124896 0 0.0
.data 1924 1924 0 0.0
.text 853416 853416 0 0.0
k32w light k32w061+release (read/write) 694144 694144 0 0.0
.bss 77680 77680 0 0.0
.data 1964 1964 0 0.0
.text 608700 608700 0 0.0
lock k32w061+release (read/write) 695992 695992 0 0.0
.bss 77656 77656 0 0.0
.data 1972 1972 0 0.0
.text 610564 610564 0 0.0
linux all-clusters-app debug (read only) 2425297 2425297 0 0.0
(read/write) 145656 145656 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205477 205477 0 0.0
.text 2056834 2056834 0 0.0
bridge-app debug+rpc (read only) 1730189 1730189 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1472485 1472485 0 0.0
chip-tool debug (read only) 9511901 9662829 150928 1.6
(read/write) 330512 331280 768 0.2
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 297792 298560 768 0.3
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 499381 499381 0 0.0
.text 8291029 8440037 149008 1.8
chip-tool-ipv6only arm64 (read only) 9201620 9340116 138496 1.5
(read/write) 443265 444993 1728 0.4
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 342552 343704 1152 0.3
.dynamic 560 560 0 0.0
.got 51880 52456 576 1.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475004 476540 1536 0.3
.text 7748356 7881284 132928 1.7
door-lock-app debug (read only) 1944481 1944481 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622194 1622194 0 0.0
lighting-app debug+rpc (read only) 2076673 2076673 0 0.0
(read/write) 124368 124368 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165788 165788 0 0.0
.text 1755250 1755250 0 0.0
ota-provider-app debug (read only) 1876985 1876985 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1567378 1567378 0 0.0
ota-requestor-app debug (read only) 1893105 1893105 0 0.0
(read/write) 117016 117016 0 0.0
.bss 51232 51232 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 58856 58856 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152972 152972 0 0.0
.text 1590722 1590722 0 0.0
shell debug (read only) 2391761 2391745 -16 -0.0
(read/write) 147920 147920 0 0.0
.bss 68232 68232 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205426 205426 0 0.0
.text 2029570 2029554 -16 -0.0
thermostat-no-ble arm64 (read only) 2173524 2173524 0 0.0
(read/write) 148497 148497 0 0.0
.bss 65185 65185 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822128 1822128 0 0.0
tv-app debug (read only) 2615201 2615201 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2241586 2241586 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350324 2350324 0 0.0
.bss 186068 186068 0 0.0
.data 5800 5800 0 0.0
.text 1312924 1312924 0 0.0
p6 all-clusters-app default (read/write) 2493648 2493648 0 0.0
.bss 119488 119488 0 0.0
.data 2696 2696 0 0.0
.text 1451912 1451912 0 0.0
light-app default (read/write) 2397112 2397112 0 0.0
.bss 112960 112960 0 0.0
.data 2544 2544 0 0.0
.text 1355376 1355376 0 0.0
lock-app default (read/write) 2360544 2360544 0 0.0
.bss 112704 112704 0 0.0
.data 2504 2504 0 0.0
.text 1318808 1318808 0 0.0
qpg lighting-app qpg6105+debug (read only) 603400 603400 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91056 91056 0 0.0
.data 1164 1164 0 0.0
.text 598080 598080 0 0.0
lock-app qpg6105+debug (read only) 569012 569012 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1116 1116 0 0.0
.text 563692 563692 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888490 888490 0 0.0
bss 86912 86912 0 0.0
noinit 37160 37160 0 0.0
text 627902 627902 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 4, 2022
View reviewed changes
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
@woody-apple
Copy link
Contributor

/rebase

@mrjerryjohns
Strongly Typed Bitmaps
e81f416 
Switching some of the attributes in the test cluster of type BITMAP* to
actually using the enum-like definition of the bitmap resulted in all
kinds of compiler errors.

This adds support for strongly typed BITMAP* fields in the XML that in
turn result in the use of the BitFlags type in the generated C++ code.

To correctly work this type for attributes, a specialization of
NumericAttributeTraits has been added for BitFlags<T> to correctly
handle the underlying storage type as well the special rule for
nullability.

Some of other fix-ups to the chip-tool helpers were needed as well.

Tests:
Ensured the YAML tests for bitmaps still works.
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

PR #15697: Size comparison from cd44f9b to e81f416

Increases above 0.2%:

platform target config section cd44f9b e81f416 change % change
linux chip-tool debug (read only) 9937749 10089125 151376 1.5
(read/write) 356152 356920 768 0.2
.data.rel.ro 323336 324104 768 0.2
.text 8645413 8794869 149456 1.7
chip-tool-ipv6only arm64 (read only) 9586076 9724924 138848 1.4
(read/write) 472945 474673 1728 0.4
.data.rel.ro 369312 370464 1152 0.3
.got 54680 55256 576 1.1
.rodata 490436 491972 1536 0.3
.text 8051508 8184788 133280 1.7
Increases (2 builds for linux)
platform target config section cd44f9b e81f416 change % change
linux chip-tool debug (read only) 9937749 10089125 151376 1.5
(read/write) 356152 356920 768 0.2
.data.rel.ro 323336 324104 768 0.2
.text 8645413 8794869 149456 1.7
chip-tool-ipv6only arm64 (read only) 9586076 9724924 138848 1.4
(read/write) 472945 474673 1728 0.4
.data.rel.ro 369312 370464 1152 0.3
.got 54680 55256 576 1.1
.rodata 490436 491972 1536 0.3
.text 8051508 8184788 133280 1.7
Decreases (1 build for esp32)
platform target config section cd44f9b e81f416 change % change
esp32 all-clusters-app m5stack (read only) 1013715 1013687 -28 -0.0
.flash.text 1008331 1008303 -28 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cd44f9b e81f416 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602202 602202 0 0.0
.app_xip_area 506720 506720 0 0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560078 560078 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570226 570226 0 0.0
.app_xip_area 466584 466584 0 0.0
.bss 86012 86012 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922240 922240 0 0.0
(read/write) 128888 128888 0 0.0
.bss 126808 126808 0 0.0
.data 2080 2080 0 0.0
.text 922232 922232 0 0.0
BRD4161A+rpc (read only) 951076 951076 0 0.0
(read/write) 144844 144844 0 0.0
.bss 142584 142584 0 0.0
.data 2260 2260 0 0.0
.text 951068 951068 0 0.0
window-app BRD4161A (read only) 854412 854412 0 0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854404 854404 0 0.0
esp32 all-clusters-app c3devkit (read only) 958694 958694 0 0.0
(read/write) 1393802 1393802 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197088 197088 0 0.0
.flash.text 958694 958694 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1013715 1013687 -28 -0.0
(read/write) 461052 461052 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226056 226056 0 0.0
.flash.text 1008331 1008303 -28 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 696264 696264 0 0.0
.bss 77744 77744 0 0.0
.data 1964 1964 0 0.0
.text 610756 610756 0 0.0
lock k32w061+release (read/write) 697016 697016 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611548 611548 0 0.0
linux all-clusters-app debug (read only) 2432289 2432289 0 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205765 205765 0 0.0
.text 2063538 2063538 0 0.0
bridge-app debug+rpc (read only) 1737061 1737061 0 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 141964 0 0.0
.text 1479125 1479125 0 0.0
chip-tool debug (read only) 9937749 10089125 151376 1.5
(read/write) 356152 356920 768 0.2
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 323336 324104 768 0.2
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514452 514452 0 0.0
.text 8645413 8794869 149456 1.7
chip-tool-ipv6only arm64 (read only) 9586076 9724924 138848 1.4
(read/write) 472945 474673 1728 0.4
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 369312 370464 1152 0.3
.dynamic 560 560 0 0.0
.got 54680 55256 576 1.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 490436 491972 1536 0.3
.text 8051508 8184788 133280 1.7
door-lock-app debug (read only) 1951521 1951521 0 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173852 173852 0 0.0
.text 1629026 1629026 0 0.0
lighting-app debug+rpc (read only) 2083689 2083689 0 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166044 166044 0 0.0
.text 1761986 1761986 0 0.0
ota-provider-app debug (read only) 1884793 1884793 0 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 159091 0 0.0
.text 1574978 1574978 0 0.0
ota-requestor-app debug (read only) 1912225 1912225 0 0.0
(read/write) 117832 117832 0 0.0
.bss 51552 51552 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154892 154892 0 0.0
.text 1606818 1606818 0 0.0
shell debug (read only) 2398465 2398465 0 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205714 205714 0 0.0
.text 2036178 2036178 0 0.0
thermostat-no-ble arm64 (read only) 2180428 2180428 0 0.0
(read/write) 148833 148833 0 0.0
.bss 65409 65409 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133228 133228 0 0.0
.text 1828608 1828608 0 0.0
tv-app debug (read only) 2624745 2624745 0 0.0
(read/write) 251000 251000 0 0.0
.bss 168160 168160 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199677 199677 0 0.0
.text 2250978 2250978 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351892 2351892 0 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1314492 1314492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153379 1153379 0 0.0
bss 146848 146848 0 0.0
rodata 144476 144476 0 0.0
text 786808 786808 0 0.0
p6 all-clusters-app default (read/write) 2495488 2495488 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453752 1453752 0 0.0
light-app default (read/write) 2398960 2398960 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357224 1357224 0 0.0
lock-app default (read/write) 2362520 2362520 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320784 1320784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889826 889826 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 629098 629098 0 0.0

@mrjerryjohns mrjerryjohns merged commit 2282e97 into project-chip:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrjerryjohns @hubTab @woody-apple @yunhanw-google @bzbarsky-apple