Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI split between master (full) and PR (smoke) for NRF #15606

Merged
merged 3 commits into from
Feb 28, 2022
Merged

CI split between master (full) and PR (smoke) for NRF #15606

merged 3 commits into from
Feb 28, 2022

Conversation

andy31415
Copy link
Contributor

Problem

We spend a lot of time waiting for PR CI.

Change overview

Moved full NRF into master builds only, moved the PR builds as a "smoke test" only that is expected to finish faster (under 30 min).

PR smoke test will only do an app compile. Master pushes will compile all apps and run zephyr unit tests.

Testing

CI will validate.

@andy31415
Split NRF builds into smoketest and full
938bb5a
@andy31415
Remove unit test from smoke tests: unit tests should generally be pla…
727b238 
…tform agnostic, running them on linux/mac should be sufficient for a smoke test
@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

PR #15606: Size comparison from c1d14cc to 727b238

Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c1d14cc 727b238 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599614 599614 0 0.0
.app_xip_area 504460 504460 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557686 557686 0 0.0
.app_xip_area 464068 464068 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578210 578210 0 0.0
.app_xip_area 475160 475160 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916556 916556 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916548 916548 0 0.0
BRD4161A+rpc (read only) 946644 946644 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946636 946636 0 0.0
lock-app BRD4161A+wf200 (read only) 986476 986476 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986468 986468 0 0.0
window-app BRD4161A (read only) 850620 850620 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850612 850612 0 0.0
esp32 all-clusters-app c3devkit (read only) 956550 956550 0 0.0
(read/write) 1393010 1393010 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197272 197272 0 0.0
.flash.text 956550 956550 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004691 1004691 0 0.0
(read/write) 458288 458288 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224624 224624 0 0.0
.flash.text 999307 999307 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691972 691972 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606768 606768 0 0.0
lock k32w061+release (read/write) 695244 695244 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609792 609792 0 0.0
linux all-clusters-app debug (read only) 2394729 2394729 0 0.0
(read/write) 144696 144696 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204709 204709 0 0.0
.text 2027250 2027250 0 0.0
bridge-app debug+rpc (read only) 1720805 1720805 0 0.0
(read/write) 92744 92744 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141492 141492 0 0.0
.text 1463509 1463509 0 0.0
chip-tool debug (read only) 9002309 9002309 0 0.0
(read/write) 298816 298816 0 0.0
.bss 40448 40448 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 251144 251144 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 481109 481109 0 0.0
.text 7912293 7912293 0 0.0
chip-tool-ipv6only arm64 (read only) 8756588 8756588 0 0.0
(read/write) 412033 412033 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51496 51496 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456964 456964 0 0.0
.text 7434388 7434388 0 0.0
door-lock-app debug (read only) 1936273 1936273 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173532 0 0.0
.text 1614258 1614258 0 0.0
lighting-app debug+rpc (read only) 2071137 2071137 0 0.0
(read/write) 124496 124496 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166129 166129 0 0.0
.text 1749554 1749554 0 0.0
ota-provider-app debug (read only) 1868393 1868393 0 0.0
(read/write) 114800 114800 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158739 158739 0 0.0
.text 1559090 1559090 0 0.0
ota-requestor-app debug (read only) 1879385 1879385 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152452 152452 0 0.0
.text 1578098 1578098 0 0.0
shell debug (read only) 2362961 2362961 0 0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204658 204658 0 0.0
.text 2001746 2001746 0 0.0
thermostat-no-ble arm64 (read only) 2162948 2162948 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132980 132980 0 0.0
.text 1811664 1811664 0 0.0
tv-app debug (read only) 2589489 2589489 0 0.0
(read/write) 148632 148632 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198653 0 0.0
.text 2217074 2217074 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449728 2449728 0 0.0
.bss 191016 191016 0 0.0
.data 5512 5512 0 0.0
.text 1412300 1412300 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2414424 2414424 0 0.0
.bss 188188 188188 0 0.0
.data 5800 5800 0 0.0
.text 1376996 1376996 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350244 2350244 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312844 1312844 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340240 2340240 0 0.0
.bss 185736 185736 0 0.0
.data 5608 5608 0 0.0
.text 1302812 1302812 0 0.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 931259 931259 0 0.0
bss 120280 120280 0 0.0
rodata 104996 104996 0 0.0
text 628928 628928 0 0.0
p6 all-clusters-app default (read/write) 2488128 2488128 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446392 1446392 0 0.0
light-app default (read/write) 2395344 2395344 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353608 1353608 0 0.0
lock-app default (read/write) 2358920 2358920 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317184 1317184 0 0.0
qpg lighting-app qpg6105+debug (read only) 601248 601248 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595928 595928 0 0.0
lock-app qpg6105+debug (read only) 567044 567044 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561724 561724 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883158 883158 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623996 623996 0 0.0

@andy31415 andy31415 merged commit fd915e5 into project-chip:master Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15606: Size comparison from 12ffb01 to 3b91a2c

Increases above 0.2%:

platform target config section 12ffb01 3b91a2c change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1075211 36304 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700036 728396 28360 4.1
Increases (1 build for nrfconnect)
platform target config section 12ffb01 3b91a2c change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1075211 36304 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700036 728396 28360 4.1
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ffb01 3b91a2c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599542 599542 0 0.0
.app_xip_area 504388 504388 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 557614 0 0.0
.app_xip_area 463996 463996 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578138 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 916516 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 916508 0 0.0
BRD4161A+rpc (read only) 946604 946604 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 946596 0 0.0
lock-app BRD4161A+wf200 (read only) 986436 986436 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 986428 0 0.0
window-app BRD4161A (read only) 850596 850596 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 850588 0 0.0
esp32 all-clusters-app c3devkit (read only) 956534 956534 0 0.0
(read/write) 1392986 1392986 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197248 0 0.0
.flash.text 956534 956534 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004671 1004671 0 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999287 999287 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 691904 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 606700 0 0.0
lock k32w061+release (read/write) 695176 695176 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 609724 0 0.0
linux all-clusters-app debug (read only) 2394761 2394761 0 0.0
(read/write) 144696 144696 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204709 204709 0 0.0
.text 2027282 2027282 0 0.0
bridge-app debug+rpc (read only) 1720741 1720741 0 0.0
(read/write) 92744 92744 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141460 141460 0 0.0
.text 1463477 1463477 0 0.0
chip-tool debug (read only) 9003269 9003269 0 0.0
(read/write) 298816 298816 0 0.0
.bss 40448 40448 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 251144 251144 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 481173 481173 0 0.0
.text 7913189 7913189 0 0.0
chip-tool-ipv6only arm64 (read only) 8757372 8757372 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456996 456996 0 0.0
.text 7435092 7435092 0 0.0
door-lock-app debug (read only) 1936305 1936305 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173532 0 0.0
.text 1614290 1614290 0 0.0
lighting-app debug+rpc (read only) 2071137 2071137 0 0.0
(read/write) 124496 124496 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166097 166097 0 0.0
.text 1749586 1749586 0 0.0
ota-provider-app debug (read only) 1868393 1868393 0 0.0
(read/write) 114800 114800 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158707 158707 0 0.0
.text 1559122 1559122 0 0.0
ota-requestor-app debug (read only) 1879369 1879369 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152420 152420 0 0.0
.text 1578114 1578114 0 0.0
shell debug (read only) 2362977 2362977 0 0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204658 204658 0 0.0
.text 2001762 2001762 0 0.0
thermostat-no-ble arm64 (read only) 2162916 2162916 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1811648 1811648 0 0.0
tv-app debug (read only) 2589505 2589505 0 0.0
(read/write) 148632 148632 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198653 0 0.0
.text 2217090 2217090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350140 2350140 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312740 1312740 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1075211 36304 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700036 728396 28360 4.1
p6 all-clusters-app default (read/write) 2488104 2488104 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1446368 0 0.0
light-app default (read/write) 2395304 2395304 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1353568 0 0.0
lock-app default (read/write) 2358880 2358880 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317144 0 0.0
qpg lighting-app qpg6105+debug (read only) 601168 601168 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595848 595848 0 0.0
lock-app qpg6105+debug (read only) 566964 566964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 561644 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883086 883086 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623942 623942 0 0.0

Damian-Nordic added a commit to Damian-Nordic/connectedhomeip that referenced this pull request Mar 3, 2022
@Damian-Nordic
Revert "CI split between master (full) and PR (smoke) for NRF (projec…
b03039e 
…t-chip#15606)"

This reverts commit fd915e5.
@Damian-Nordic Damian-Nordic mentioned this pull request Mar 3, 2022
Merged
andy31415 pushed a commit that referenced this pull request Mar 3, 2022
@Damian-Nordic
[nrfconnect] Better filter which application to build on each PR (#15791
cb986fe 
)

* Revert "CI split between master (full) and PR (smoke) for NRF (#15606)"

This reverts commit fd915e5.

* [nrfconnect] Filter nRF workflow steps by changed paths

On a pull request, verify just all-clusters-app with the DFU
and add other steps only if specific paths like "nrfconnect",
"Zephyr" or "tests" have been modified.
krypton36 pushed a commit to krypton36/connectedhomeip that referenced this pull request Mar 3, 2022
@Damian-Nordic @krypton36
[nrfconnect] Better filter which application to build on each PR (pro…
edf8ec9 
…ject-chip#15791)

* Revert "CI split between master (full) and PR (smoke) for NRF (project-chip#15606)"

This reverts commit fd915e5.

* [nrfconnect] Filter nRF workflow steps by changed paths

On a pull request, verify just all-clusters-app with the DFU
and add other steps only if specific paths like "nrfconnect",
"Zephyr" or "tests" have been modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
github review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @mrjerryjohns @bzbarsky-apple @Damian-Nordic