Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EFR32 Network Commissioning WiFi Driver #15356

Merged
merged 3 commits into from
Feb 18, 2022
Merged

EFR32 Network Commissioning WiFi Driver #15356

merged 3 commits into from
Feb 18, 2022

Conversation

jmartinez-silabs
Copy link
Member

Problem

Efr32 lighting-app wifi options fail to build
Cannot commission WiFI example because Network Commissioning WiFi Driver isn't implemented for EFR32

Change overview

Fix efr32 wifi lighting-app build
Implement the Network Commissioning WiFi Driver
Instantiated the cluster driver for each example if built with WiFi option
Update efr32_sdk submodule to support wifi Scanning.
Some small Clean up in the examples build.gn files
Fix an issue with deleting some keys from nvm storage

Testing

Build efr32 examples with different wifi options
./scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/rs911x_lighting BRD4161A --wifi rs911x
./scripts/examples/gn_efr32_example.sh examples/lock-app/efr32/ out/wf200_lock BRD4161A --wifi wf200
Commision with chip-tool and test scan network command

@jmartinez-silabs
Fix light-app wifi builds. Fix efr32_sdk submodule that was brought b…
e792fcf 
…ack by mistake I assume
@jmartinez-silabs
Implement NetworkCommissioning Wifi Driver and add suport for the wif…
959877e 
…i examples. Set efr32 examples setupPinCode to match the certs expected value
@jmartinez-silabs
Update submodule to support wifi scanning + clean/fix build.gn issue
e588cb1 
Fix wifi provisionning issue, add ScanNetwork behaviour, fix factory reset for config keys - Restyle

Fix scan for ssid update efr32 submodule hash
@github-actions
Copy link

github-actions bot commented Feb 18, 2022 •
edited
Loading

PR #15356: Size comparison from a8cdb57 to e588cb1

Increases (8 builds for efr32, k32w, qpg, telink)
platform target config section a8cdb57 e588cb1 change % change
efr32 lighting-app BRD4161A (read only) 916220 916284 64 0.0
.text 916212 916276 64 0.0
BRD4161A+rpc (read only) 944928 944992 64 0.0
.text 944920 944984 64 0.0
window-app BRD4161A (read only) 850044 850108 64 0.0
.text 850036 850100 64 0.0
k32w light k32w061+release (read/write) 692492 692500 8 0.0
.text 606388 606404 16 0.0
lock k32w061+release (read/write) 695040 695048 8 0.0
.text 608680 608696 16 0.0
qpg lighting-app qpg6105+debug (read only) 600132 600148 16 0.0
.text 594812 594828 16 0.0
lock-app qpg6105+debug (read only) 565900 565916 16 0.0
.text 560580 560596 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 878750 878766 16 0.0
text 618916 618928 12 0.0
Decreases (20 builds for cyw30739, efr32, k32w, nrfconnect, qpg, telink)
platform target config section a8cdb57 e588cb1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599310 599298 -12 -0.0
.app_xip_area 503236 503232 -4 -0.0
.bss 78772 78764 -8 -0.0
lock cyw930739m2evb_01 (read/write) 557346 557334 -12 -0.0
.app_xip_area 462816 462812 -4 -0.0
.bss 77268 77260 -8 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 578582 578570 -12 -0.0
.app_xip_area 474628 474624 -4 -0.0
.bss 86364 86356 -8 -0.0
efr32 lighting-app BRD4161A (read/write) 129508 129500 -8 -0.0
.bss 127472 127464 -8 -0.0
BRD4161A+rpc (read/write) 146424 146416 -8 -0.0
.bss 144248 144240 -8 -0.0
window-app BRD4161A (read/write) 127424 127416 -8 -0.0
.bss 125520 125512 -8 -0.0
k32w light k32w061+release .bss 78392 78384 -8 -0.0
lock k32w061+release .bss 78608 78600 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 123532 123528 -4 -0.0
nrf52840dk_nrf52840+rpc bss 120720 120716 -4 -0.0
nrf52840dongle_nrf52840 bss 124752 124748 -4 -0.0
nrf5340dk_nrf5340_cpuapp bss 120092 120088 -4 -0.0
lock-app nrf52840dk_nrf52840 bss 121760 121756 -4 -0.0
nrf5340dk_nrf5340_cpuapp bss 118352 118348 -4 -0.0
pump-app nrf52840dk_nrf52840 bss 121480 121476 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 bss 121484 121480 -4 -0.0
shell nrf52840dk_nrf52840 bss 113328 113324 -4 -0.0
text 540684 540680 -4 -0.0
qpg lighting-app qpg6105+debug .bss 90952 90944 -8 -0.0
lock-app qpg6105+debug .bss 90960 90952 -8 -0.0
telink lighting-app tlsr9518adk80d bss 87504 87500 -4 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a8cdb57 e588cb1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599310 599298 -12 -0.0
.app_xip_area 503236 503232 -4 -0.0
.bss 78772 78764 -8 -0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557346 557334 -12 -0.0
.app_xip_area 462816 462812 -4 -0.0
.bss 77268 77260 -8 -0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578582 578570 -12 -0.0
.app_xip_area 474628 474624 -4 -0.0
.bss 86364 86356 -8 -0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916220 916284 64 0.0
(read/write) 129508 129500 -8 -0.0
.bss 127472 127464 -8 -0.0
.data 2036 2036 0 0.0
.text 916212 916276 64 0.0
BRD4161A+rpc (read only) 944928 944992 64 0.0
(read/write) 146424 146416 -8 -0.0
.bss 144248 144240 -8 -0.0
.data 2176 2176 0 0.0
.text 944920 944984 64 0.0
window-app BRD4161A (read only) 850044 850108 64 0.0
(read/write) 127424 127416 -8 -0.0
.bss 125520 125512 -8 -0.0
.data 1904 1904 0 0.0
.text 850036 850100 64 0.0
esp32 all-clusters-app c3devkit (read only) 950408 950408 0 0.0
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67144 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 950408 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 999903 0 0.0
(read/write) 465560 465560 0 0.0
.dram0.bss 72296 72296 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 994519 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692492 692500 8 0.0
.bss 78392 78384 -8 -0.0
.data 1912 1912 0 0.0
.text 606388 606404 16 0.0
lock k32w061+release (read/write) 695040 695048 8 0.0
.bss 78608 78600 -8 -0.0
.data 1952 1952 0 0.0
.text 608680 608696 16 0.0
linux all-clusters-app debug (read only) 2386393 2386393 0 0.0
(read/write) 149696 149696 0 0.0
.bss 64032 64032 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206949 206949 0 0.0
.text 2015906 2015906 0 0.0
bridge-app debug+rpc (read only) 1734973 1734973 0 0.0
(read/write) 94840 94840 0 0.0
.bss 49312 49312 0 0.0
.data 2010 2010 0 0.0
.data.rel.ro 38376 38376 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142644 142644 0 0.0
.text 1475493 1475493 0 0.0
chip-tool debug (read only) 8989309 8989309 0 0.0
(read/write) 319568 319568 0 0.0
.bss 40728 40728 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 271624 271624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 474005 474005 0 0.0
.text 7857029 7857029 0 0.0
chip-tool-ipv6only arm64 (read only) 8714828 8714828 0 0.0
(read/write) 431361 431361 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 316816 316816 0 0.0
.dynamic 560 560 0 0.0
.got 50560 50560 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 450500 450500 0 0.0
.text 7352884 7352884 0 0.0
door-lock-app debug (read only) 1947505 1947505 0 0.0
(read/write) 120904 120904 0 0.0
.bss 52000 52000 0 0.0
.data 986 986 0 0.0
.data.rel.ro 62496 62496 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 174172 174172 0 0.0
.text 1623826 1623826 0 0.0
lighting-app debug+rpc (read only) 2073969 2073969 0 0.0
(read/write) 125880 125880 0 0.0
.bss 52992 52992 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 65984 65984 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166737 166737 0 0.0
.text 1751586 1751586 0 0.0
ota-provider-app debug (read only) 1880873 1880873 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51872 51872 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159003 159003 0 0.0
.text 1570258 1570258 0 0.0
ota-requestor-app debug (read only) 1893905 1893905 0 0.0
(read/write) 117952 117952 0 0.0
.bss 52288 52288 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 59080 59080 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153388 153388 0 0.0
.text 1590578 1590578 0 0.0
shell debug (read only) 2361265 2361265 0 0.0
(read/write) 152112 152112 0 0.0
.bss 72384 72384 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73216 73216 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207986 207986 0 0.0
.text 1995874 1995874 0 0.0
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
tv-app debug (read only) 2543385 2543385 0 0.0
(read/write) 152064 152064 0 0.0
.bss 69248 69248 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 199117 199117 0 0.0
.text 2169922 2169922 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2430660 0 0.0
.bss 194564 194564 0 0.0
.data 5328 5328 0 0.0
.text 1393232 1393232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2392780 0 0.0
.bss 188432 188432 0 0.0
.data 5632 5632 0 0.0
.text 1355352 1355352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328224 0 0.0
.bss 187432 187432 0 0.0
.data 5608 5608 0 0.0
.text 1290824 1290824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319124 0 0.0
.bss 185980 185980 0 0.0
.data 5440 5440 0 0.0
.text 1281696 1281696 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023355 1023355 0 0.0
bss 123532 123528 -4 -0.0
rodata 120904 120904 0 0.0
text 699908 699908 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 992667 992667 0 0.0
bss 120720 120716 -4 -0.0
rodata 112448 112448 0 0.0
text 679812 679812 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038111 1038111 0 0.0
bss 124752 124748 -4 -0.0
rodata 119736 119736 0 0.0
text 703720 703720 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929966 929966 0 0.0
bss 120092 120088 -4 -0.0
rodata 114160 114160 0 0.0
text 614936 614936 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952119 952119 0 0.0
bss 121760 121756 -4 -0.0
rodata 109740 109740 0 0.0
text 642024 642024 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859598 859598 0 0.0
bss 118352 118348 -4 -0.0
rodata 102912 102912 0 0.0
text 557828 557828 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950695 950695 0 0.0
bss 121480 121476 -4 -0.0
rodata 108692 108692 0 0.0
text 641844 641844 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946659 946659 0 0.0
bss 121484 121480 -4 -0.0
rodata 108392 108392 0 0.0
text 638084 638084 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811335 811335 0 0.0
bss 113328 113324 -4 -0.0
rodata 79676 79676 0 0.0
text 540684 540680 -4 -0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600132 600148 16 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90944 -8 -0.0
.data 1112 1112 0 0.0
.text 594812 594828 16 0.0
lock-app qpg6105+debug (read only) 565900 565916 16 0.0
(read/write) 146940 146940 0 0.0
.bss 90960 90952 -8 -0.0
.data 1064 1064 0 0.0
.text 560580 560596 16 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878750 878766 16 0.0
bss 87504 87500 -4 -0.0
noinit 37160 37160 0 0.0
text 618916 618928 12 0.0

woody-apple
woody-apple approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@woody-apple woody-apple merged commit cff9f21 into project-chip:master Feb 18, 2022
@jmartinez-silabs jmartinez-silabs mentioned this pull request Feb 18, 2022
Closed
15 tasks
@jmartinez-silabs jmartinez-silabs deleted the wifi_build branch March 31, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
efr32 examples fast track openthread platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartinez-silabs @woody-apple