Fix TC_SWDIAG_3_1.yaml test case on Linux #15215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #15215: Size comparison from 01ae39f to e520970 Increases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mlepage-google
approved these changes
Feb 15, 2022
woody-apple
approved these changes
Feb 15, 2022
bzbarsky-apple
approved these changes
Feb 16, 2022
|
Instead of your own script to regenerate tests, I have opened #15246 that should do what you want (in a faster way) |
jmeg-sfy
approved these changes
Feb 16, 2022
|
/rebase |
- The test case previously expected used/free heap value of 0. - Now the SDK is implementing heap read properly from Linux when built with glibc. This made the code return a real value that fails the test. - Overall, there is no "value" value for heap, we just need a value. The explicit value was replaced with expecting a returned value back.
woody-apple
force-pushed
the
fix-linux-tc-swdiag-3-1
branch
from
e520970 to
d3fdd38
Compare
|
PR #15215: Size comparison from 6103a69 to d3fdd38 Increases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* Fix TC_SWDIAG_3_1.yaml test case on Linux - The test case previously expected used/free heap value of 0. - Now the SDK is implementing heap read properly from Linux when built with glibc. This made the code return a real value that fails the test. - Overall, there is no "value" value for heap, we just need a value. The explicit value was replaced with expecting a returned value back. * Restyled by whitespace * Restyled by shfmt Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
built with glibc. This made the code return a real value
that fails the test.
a value.
Change overview
a returned value back.
save time when regenerating ZAP for just chip-tool
Testing
Ran the modified integration test, now passes on Linux