Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10592 [ota-provider-app] Make various values to ApplyUpdateResponse Command configurable #15208

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Issue #10592 [ota-provider-app] Make various values to ApplyUpdateResponse Command configurable #15208

merged 3 commits into from
Feb 15, 2022

Conversation

isiu-apple
Copy link
Contributor

@isiu-apple isiu-apple commented Feb 15, 2022 •
edited
Loading

Problem

The following fields of the ApplyUpdateResponse command are currently not configurable.

The Action field of the ApplyUpdateResponse command can be:

  • Proceed
  • AwaitNextAction
  • Discontinue

The DelayedActionTime field

The user should be able to configure the app to return any valid Action and/or DelayedActionTime values when handling the command.

Fixes: #10592

Change overview

  • Added -a command line argument to the OTA Provider app to allow specifying one of the 3 valid arguments for the Action field of the ApplyUpdateResponse command.

Testing

  • Tested all combinations of proceed, awaitNextAction, and discontinue, for the Action field value with 0 and 120 values for DelayedActionTime.

@isiu-apple
Issue project-chip#10592 - [ota-provider-app] Make various values to …
fc02d06 
…ApplyUpdateResponse Command configurable project-chip#10592

- Added -a command line option to ota-provider-app so that the action field of ApplyUpdateResponse can be configurable.

Tested various -a and -t command line options for ApplyUpdateResponse.
@isiu-apple
Update readme.md to add the comments for the new -a command line argu…
88921d5 
…ment.
@isiu-apple
Add applyUpdateAction to the wordlist for spellchecker.
a92c3a5
@boring-cyborg boring-cyborg bot added the github label Feb 15, 2022
@github-actions
Copy link

github-actions bot commented Feb 15, 2022 •
edited
Loading

PR #15208: Size comparison from 101ff17 to a92c3a5

Increases (1 build for linux)
platform target config section 101ff17 a92c3a5 change % change
linux ota-provider-app debug (read only) 1866161 1866729 568 0.0
.rodata 157867 158155 288 0.2
.text 1557634 1557890 256 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 101ff17 a92c3a5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593786 593786 0 0.0
.app_xip_area 499384 499384 0 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 551846 551846 0 0.0
.app_xip_area 459012 459012 0 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570394 570394 0 0.0
.app_xip_area 468304 468304 0 0.0
.bss 84500 84500 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 911220 911220 0 0.0
(read/write) 127264 127264 0 0.0
.bss 125232 125232 0 0.0
.data 2032 2032 0 0.0
.text 911212 911212 0 0.0
BRD4161A+rpc (read only) 939928 939928 0 0.0
(read/write) 144184 144184 0 0.0
.bss 142008 142008 0 0.0
.data 2172 2172 0 0.0
.text 939920 939920 0 0.0
window-app BRD4161A (read only) 846432 846432 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846424 846424 0 0.0
esp32 all-clusters-app c3devkit (read only) 946006 946006 0 0.0
(read/write) 1398882 1398882 0 0.0
.dram0.bss 66248 66248 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199464 199464 0 0.0
.flash.text 946006 946006 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995839 995839 0 0.0
(read/write) 464144 464144 0 0.0
.dram0.bss 71392 71392 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226560 226560 0 0.0
.flash.text 990455 990455 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 685044 685044 0 0.0
.bss 76536 76536 0 0.0
.data 1904 1904 0 0.0
.text 600804 600804 0 0.0
lock k32w061+release (read/write) 690528 690528 0 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 605852 605852 0 0.0
linux all-clusters-app debug (read only) 2361761 2361761 0 0.0
(read/write) 141760 141760 0 0.0
.bss 56288 56288 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205893 205893 0 0.0
.text 1993522 1993522 0 0.0
bridge-app debug+rpc (read only) 1728077 1728077 0 0.0
(read/write) 85672 85672 0 0.0
.bss 40400 40400 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141868 141868 0 0.0
.text 1469589 1469589 0 0.0
chip-tool debug (read only) 8552181 8552181 0 0.0
(read/write) 245952 245952 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4792 4792 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459541 459541 0 0.0
.text 7576149 7576149 0 0.0
chip-tool-ipv6only arm64 (read only) 8312420 8312420 0 0.0
(read/write) 353729 353729 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49240 49240 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435500 435500 0 0.0
.text 7114292 7114292 0 0.0
door-lock-app debug (read only) 1933377 1933377 0 0.0
(read/write) 111576 111576 0 0.0
.bss 43088 43088 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173330 173330 0 0.0
.text 1611458 1611458 0 0.0
lighting-app debug+rpc (read only) 2057025 2057025 0 0.0
(read/write) 116920 116920 0 0.0
.bss 44192 44192 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165649 165649 0 0.0
.text 1736562 1736562 0 0.0
ota-provider-app debug (read only) 1866161 1866729 568 0.0
(read/write) 107320 107320 0 0.0
.bss 42976 42976 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157867 158155 288 0.2
.text 1557634 1557890 256 0.0
ota-requestor-app debug (read only) 1861601 1861601 0 0.0
(read/write) 108376 108376 0 0.0
.bss 43232 43232 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58536 58536 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151452 151452 0 0.0
.text 1561234 1561234 0 0.0
shell debug (read only) 2343321 2343321 0 0.0
(read/write) 144560 144560 0 0.0
.bss 64864 64864 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73192 73192 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206770 206770 0 0.0
.text 1979698 1979698 0 0.0
thermostat-no-ble arm64 (read only) 2152780 2152780 0 0.0
(read/write) 141809 141809 0 0.0
.bss 58641 58641 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133052 133052 0 0.0
.text 1801472 1801472 0 0.0
tv-app debug (read only) 2530873 2530873 0 0.0
(read/write) 142432 142432 0 0.0
.bss 60192 60192 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197669 197669 0 0.0
.text 2160162 2160162 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398544 2398544 0 0.0
.bss 188252 188252 0 0.0
.data 5320 5320 0 0.0
.text 1361144 1361144 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360768 2360768 0 0.0
.bss 180864 180864 0 0.0
.data 5624 5624 0 0.0
.text 1323368 1323368 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324368 2324368 0 0.0
.bss 180752 180752 0 0.0
.data 5600 5600 0 0.0
.text 1286968 1286968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309324 2309324 0 0.0
.bss 178004 178004 0 0.0
.data 5424 5424 0 0.0
.text 1271896 1271896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1017347 1017347 0 0.0
bss 121292 121292 0 0.0
rodata 120304 120304 0 0.0
text 696800 696800 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 986639 986639 0 0.0
bss 118480 118480 0 0.0
rodata 111828 111828 0 0.0
text 676700 676700 0 0.0
nrf52840dongle_nrf52840 (read/write) 1033207 1033207 0 0.0
bss 122680 122680 0 0.0
rodata 119184 119184 0 0.0
text 701420 701420 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 923990 923990 0 0.0
bss 117856 117856 0 0.0
rodata 113544 113544 0 0.0
text 611816 611816 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947075 947075 0 0.0
bss 119664 119664 0 0.0
rodata 109064 109064 0 0.0
text 639832 639832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 854602 854602 0 0.0
bss 116256 116256 0 0.0
rodata 102236 102236 0 0.0
text 555624 555624 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945891 945891 0 0.0
bss 119384 119384 0 0.0
rodata 108016 108016 0 0.0
text 639888 639888 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941839 941839 0 0.0
bss 119388 119388 0 0.0
rodata 107716 107716 0 0.0
text 636128 636128 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807447 807447 0 0.0
bss 111236 111236 0 0.0
rodata 79132 79132 0 0.0
text 539384 539384 0 0.0
p6 all-clusters-app default (read/write) 2484072 2484072 0 0.0
.bss 117608 117608 0 0.0
.data 2672 2672 0 0.0
.text 1442336 1442336 0 0.0
light-app default (read/write) 2390920 2390920 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349184 1349184 0 0.0
lock-app default (read/write) 2354384 2354384 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1312648 1312648 0 0.0
qpg lighting-app qpg6105+debug (read only) 596228 596228 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88928 88928 0 0.0
.data 1108 1108 0 0.0
.text 590908 590908 0 0.0
lock-app qpg6105+debug (read only) 561972 561972 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88912 88912 0 0.0
.data 1060 1060 0 0.0
.text 556652 556652 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 876614 876614 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616262 616262 0 0.0

@carol-apple carol-apple merged commit 62164cb into project-chip:master Feb 15, 2022
This was referenced Mar 22, 2022
Closed
Closed
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@isiu-apple @fuxingguo16
Issue project-chip#10592 [ota-provider-app] Make various values to Ap…
b3ef893 
…plyUpdateResponse Command configurable (project-chip#15208)

* Issue project-chip#10592 - [ota-provider-app] Make various values to ApplyUpdateResponse Command configurable project-chip#10592

- Added -a command line option to ota-provider-app so that the action field of ApplyUpdateResponse can be configurable.

Tested various -a and -t command line options for ApplyUpdateResponse.

* Update readme.md to add the comments for the new -a command line argument.

* Add applyUpdateAction to the wordlist for spellchecker.
@isiu-apple isiu-apple mentioned this pull request Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carol-apple carol-apple carol-apple approved these changes

@harsha-rajendran harsha-rajendran harsha-rajendran approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ota-provider-app] Make various values to ApplyUpdateResponse Command configurable
3 participants
@isiu-apple @harsha-rajendran @carol-apple