-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chip-tool resolve command to work. #15206
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-resolve
Feb 16, 2022
Merged
Fix chip-tool resolve command to work. #15206
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-resolve
Feb 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to use the global resolver directly only works for minimal mdns. Switch to using the supported ResolverProxy API.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex and
hawk248
February 15, 2022 18:33
pullapprove
bot
requested review from
turon,
vijs,
msandstedt,
sagar-apple,
vivien-apple,
wbschiller,
saurabhst,
woody-apple,
selissia,
tecimovic,
xylophone21,
yufengwangca and
yunhanw-google
February 15, 2022 18:33
PR #15206: Size comparison from 17dc4b0 to 3651a1b Full report (22 builds for cyw30739, efr32, esp32, k32w, mbed, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking tooling updates
jmartinez-silabs
approved these changes
Feb 16, 2022
saurabhst
approved these changes
Feb 16, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
Trying to use the global resolver directly only works for minimal mdns. Switch to using the supported ResolverProxy API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the global resolver directly only works for minimal mdns.
Switch to using the supported ResolverProxy API.
Problem
Running
chip-tool discover resolve node-id fabric-id
does not work because we end up trying to use a never-inited resolver proxy (mResolverProxy
in the platform mdns stuff).Change overview
Use ResolverProxy directly to make this work.
Testing
Ran that command, resolved the node id to an IP.