Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chip-tool resolve command to work. #15206

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Trying to use the global resolver directly only works for minimal mdns.
Switch to using the supported ResolverProxy API.

Problem

Running chip-tool discover resolve node-id fabric-id does not work because we end up trying to use a never-inited resolver proxy (mResolverProxy in the platform mdns stuff).

Change overview

Use ResolverProxy directly to make this work.

Testing

Ran that command, resolved the node id to an IP.

Trying to use the global resolver directly only works for minimal mdns.
Switch to using the supported ResolverProxy API.
@github-actions
Copy link

github-actions bot commented Feb 15, 2022

PR #15206: Size comparison from 17dc4b0 to 3651a1b

Full report (22 builds for cyw30739, efr32, esp32, k32w, mbed, p6, qpg, telink)
platform target config section 17dc4b0 3651a1b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593786 593786 0 0.0
.app_xip_area 499384 499384 0 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 551846 551846 0 0.0
.app_xip_area 459012 459012 0 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570394 570394 0 0.0
.app_xip_area 468304 468304 0 0.0
.bss 84500 84500 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 911220 911220 0 0.0
(read/write) 127264 127264 0 0.0
.bss 125232 125232 0 0.0
.data 2032 2032 0 0.0
.text 911212 911212 0 0.0
BRD4161A+rpc (read only) 939928 939928 0 0.0
(read/write) 144184 144184 0 0.0
.bss 142008 142008 0 0.0
.data 2172 2172 0 0.0
.text 939920 939920 0 0.0
window-app BRD4161A (read only) 846432 846432 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846424 846424 0 0.0
esp32 all-clusters-app c3devkit (read only) 946006 946006 0 0.0
(read/write) 1398882 1398882 0 0.0
.dram0.bss 66248 66248 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199464 199464 0 0.0
.flash.text 946006 946006 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995839 995839 0 0.0
(read/write) 464144 464144 0 0.0
.dram0.bss 71392 71392 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226560 226560 0 0.0
.flash.text 990455 990455 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 685044 685044 0 0.0
.bss 76536 76536 0 0.0
.data 1904 1904 0 0.0
.text 600804 600804 0 0.0
lock k32w061+release (read/write) 690528 690528 0 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 605852 605852 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398544 2398544 0 0.0
.bss 188252 188252 0 0.0
.data 5320 5320 0 0.0
.text 1361144 1361144 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360768 2360768 0 0.0
.bss 180864 180864 0 0.0
.data 5624 5624 0 0.0
.text 1323368 1323368 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324368 2324368 0 0.0
.bss 180752 180752 0 0.0
.data 5600 5600 0 0.0
.text 1286968 1286968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309324 2309324 0 0.0
.bss 178004 178004 0 0.0
.data 5424 5424 0 0.0
.text 1271896 1271896 0 0.0
p6 all-clusters-app default (read/write) 2484072 2484072 0 0.0
.bss 117608 117608 0 0.0
.data 2672 2672 0 0.0
.text 1442336 1442336 0 0.0
light-app default (read/write) 2390920 2390920 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349184 1349184 0 0.0
lock-app default (read/write) 2354384 2354384 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1312648 1312648 0 0.0
qpg lighting-app qpg6105+debug (read only) 596228 596228 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88928 88928 0 0.0
.data 1108 1108 0 0.0
.text 590908 590908 0 0.0
lock-app qpg6105+debug (read only) 561972 561972 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88912 88912 0 0.0
.data 1060 1060 0 0.0
.text 556652 556652 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 876614 876614 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616262 616262 0 0.0

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking tooling updates

@bzbarsky-apple bzbarsky-apple merged commit 02d93e2 into project-chip:master Feb 16, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-chip-tool-resolve branch February 16, 2022 03:53
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
Trying to use the global resolver directly only works for minimal mdns.
Switch to using the supported ResolverProxy API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants