Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the device is under commissioning before accessing/storing inf… #15204

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Verify the device is under commissioning before accessing/storing inf… #15204

merged 1 commit into from
Feb 15, 2022

Conversation

yufengwangca
Copy link
Contributor

…ormation in fabric

Problem

What is being fixed? Examples:

  • The device commissioning window might be closed due to various reasons (e.g. failsafe timeout, already commissioned and commissioning window not reopened). Current operational credentials cluster does not check if gFabricBeingCommissioned is valid before storing information in it. The code should check the validity of gFabricBeingCommissioned before accessing/storing information in it.
  • Fixes Verify the device is under commissioning before processing OpCreds cluster commands #8919

Change overview

  • Verify the device is under commissioning before accessing/storing information in fabric
  • Close the commissioning window after commissioning complete or timeout

Testing

How was this tested? (at least one bullet point required)

On Server Side:
./chip-all-clusters-app

On Client Side:
./chip-tool pairing ethernet 12344321 20202021 3840 ::1 5540

Confirm the commissioning complete successfully.

@boring-cyborg boring-cyborg bot added the app label Feb 15, 2022
@github-actions
Copy link

github-actions bot commented Feb 15, 2022 •
edited
Loading

PR #15204: Size comparison from 17dc4b0 to 719c311

Increases (28 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 17dc4b0 719c311 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593786 593838 52 0.0
.app_xip_area 499384 499436 52 0.0
lock cyw930739m2evb_01 (read/write) 551846 551898 52 0.0
.app_xip_area 459012 459064 52 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570394 570446 52 0.0
.app_xip_area 468304 468356 52 0.0
efr32 lighting-app BRD4161A (read only) 911220 911268 48 0.0
.text 911212 911260 48 0.0
BRD4161A+rpc (read only) 939928 939992 64 0.0
.text 939920 939984 64 0.0
window-app BRD4161A (read only) 846432 846480 48 0.0
.text 846424 846472 48 0.0
esp32 all-clusters-app c3devkit (read only) 946006 946056 50 0.0
.flash.text 946006 946056 50 0.0
m5stack (read only) 995839 995887 48 0.0
.flash.text 990455 990503 48 0.0
k32w light k32w061+release (read/write) 685044 685092 48 0.0
.text 600804 600852 48 0.0
lock k32w061+release (read/write) 690528 690592 64 0.0
.text 605852 605916 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2398544 2398888 344 0.0
.text 1361144 1361488 344 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2360768 2361120 352 0.0
.text 1323368 1323720 352 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2324368 2324712 344 0.0
.text 1286968 1287312 344 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2309324 2309676 352 0.0
.text 1271896 1272248 352 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1017347 1017395 48 0.0
text 696800 696852 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 986639 986687 48 0.0
text 676700 676752 52 0.0
nrf52840dongle_nrf52840 (read/write) 1033207 1033255 48 0.0
text 701420 701472 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 923990 924038 48 0.0
text 611816 611872 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947075 947139 64 0.0
text 639832 639888 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 854602 854666 64 0.0
text 555624 555680 56 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945891 945939 48 0.0
text 639888 639944 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941839 941903 64 0.0
text 636128 636184 56 0.0
p6 all-clusters-app default (read/write) 2484072 2484120 48 0.0
.text 1442336 1442384 48 0.0
light-app default (read/write) 2390920 2390984 64 0.0
.text 1349184 1349248 64 0.0
lock-app default (read/write) 2354384 2354432 48 0.0
.text 1312648 1312696 48 0.0
qpg lighting-app qpg6105+debug (read only) 596228 596292 64 0.0
.text 590908 590972 64 0.0
lock-app qpg6105+debug (read only) 561972 562036 64 0.0
.text 556652 556716 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 876614 876654 40 0.0
text 616262 616298 36 0.0
Full report (32 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 17dc4b0 719c311 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593786 593838 52 0.0
.app_xip_area 499384 499436 52 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 551846 551898 52 0.0
.app_xip_area 459012 459064 52 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570394 570446 52 0.0
.app_xip_area 468304 468356 52 0.0
.bss 84500 84500 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 911220 911268 48 0.0
(read/write) 127264 127264 0 0.0
.bss 125232 125232 0 0.0
.data 2032 2032 0 0.0
.text 911212 911260 48 0.0
BRD4161A+rpc (read only) 939928 939992 64 0.0
(read/write) 144184 144184 0 0.0
.bss 142008 142008 0 0.0
.data 2172 2172 0 0.0
.text 939920 939984 64 0.0
window-app BRD4161A (read only) 846432 846480 48 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846424 846472 48 0.0
esp32 all-clusters-app c3devkit (read only) 946006 946056 50 0.0
(read/write) 1398882 1398882 0 0.0
.dram0.bss 66248 66248 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199464 199464 0 0.0
.flash.text 946006 946056 50 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995839 995887 48 0.0
(read/write) 464144 464144 0 0.0
.dram0.bss 71392 71392 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226560 226560 0 0.0
.flash.text 990455 990503 48 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 685044 685092 48 0.0
.bss 76536 76536 0 0.0
.data 1904 1904 0 0.0
.text 600804 600852 48 0.0
lock k32w061+release (read/write) 690528 690592 64 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 605852 605916 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398544 2398888 344 0.0
.bss 188252 188252 0 0.0
.data 5320 5320 0 0.0
.text 1361144 1361488 344 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360768 2361120 352 0.0
.bss 180864 180864 0 0.0
.data 5624 5624 0 0.0
.text 1323368 1323720 352 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324368 2324712 344 0.0
.bss 180752 180752 0 0.0
.data 5600 5600 0 0.0
.text 1286968 1287312 344 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309324 2309676 352 0.0
.bss 178004 178004 0 0.0
.data 5424 5424 0 0.0
.text 1271896 1272248 352 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1017347 1017395 48 0.0
bss 121292 121292 0 0.0
rodata 120304 120304 0 0.0
text 696800 696852 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 986639 986687 48 0.0
bss 118480 118480 0 0.0
rodata 111828 111828 0 0.0
text 676700 676752 52 0.0
nrf52840dongle_nrf52840 (read/write) 1033207 1033255 48 0.0
bss 122680 122680 0 0.0
rodata 119184 119184 0 0.0
text 701420 701472 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 923990 924038 48 0.0
bss 117856 117856 0 0.0
rodata 113544 113544 0 0.0
text 611816 611872 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947075 947139 64 0.0
bss 119664 119664 0 0.0
rodata 109064 109064 0 0.0
text 639832 639888 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 854602 854666 64 0.0
bss 116256 116256 0 0.0
rodata 102236 102236 0 0.0
text 555624 555680 56 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945891 945939 48 0.0
bss 119384 119384 0 0.0
rodata 108016 108016 0 0.0
text 639888 639944 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941839 941903 64 0.0
bss 119388 119388 0 0.0
rodata 107716 107716 0 0.0
text 636128 636184 56 0.0
shell nrf52840dk_nrf52840 (read/write) 807447 807447 0 0.0
bss 111236 111236 0 0.0
rodata 79132 79132 0 0.0
text 539384 539384 0 0.0
p6 all-clusters-app default (read/write) 2484072 2484120 48 0.0
.bss 117608 117608 0 0.0
.data 2672 2672 0 0.0
.text 1442336 1442384 48 0.0
light-app default (read/write) 2390920 2390984 64 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349184 1349248 64 0.0
lock-app default (read/write) 2354384 2354432 48 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1312648 1312696 48 0.0
qpg lighting-app qpg6105+debug (read only) 596228 596292 64 0.0
(read/write) 146936 146936 0 0.0
.bss 88928 88928 0 0.0
.data 1108 1108 0 0.0
.text 590908 590972 64 0.0
lock-app qpg6105+debug (read only) 561972 562036 64 0.0
(read/write) 146936 146936 0 0.0
.bss 88912 88912 0 0.0
.data 1060 1060 0 0.0
.text 556652 556716 64 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 876614 876654 40 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616262 616298 36 0.0

@yufengwangca yufengwangca merged commit 6c28ec3 into project-chip:master Feb 15, 2022
@yufengwangca yufengwangca deleted the pr/cluster/opcreds branch February 15, 2022 23:44
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 16, 2022
Closed
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@yufengwangca @fuxingguo16
Verify the device is under commissioning before accessing/storing inf…
6554d42 
…ormation in fabric (project-chip#15204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@cecille cecille cecille approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify the device is under commissioning before processing OpCreds cluster commands
3 participants
@yufengwangca @cecille @jmartinez-silabs