-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logging] Log the error message when the StartUp and ShutDown event a… #15141
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Logging_Basic_LogEvent_Failures
Feb 23, 2022
Merged
[Logging] Log the error message when the StartUp and ShutDown event a… #15141
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Logging_Basic_LogEvent_Failures
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
mrjerryjohns
February 14, 2022 12:21
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 14, 2022 12:21
PR #15141: Size comparison from bd10d1a to eba09fc Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Feb 14, 2022
bzbarsky-apple
approved these changes
Feb 15, 2022
andy31415
approved these changes
Feb 16, 2022
vivien-apple
force-pushed
the
Logging_Basic_LogEvent_Failures
branch
from
February 21, 2022 16:08
eba09fc
to
1ca0733
Compare
PR #15141: Size comparison from e71be1c to 1ca0733 Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Feb 21, 2022
/rebase |
woody-apple
force-pushed
the
Logging_Basic_LogEvent_Failures
branch
from
February 21, 2022 17:39
1ca0733
to
70268b0
Compare
PR #15141: Size comparison from 6107c13 to 70268b0 Increases (37 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
vivien-apple
force-pushed
the
Logging_Basic_LogEvent_Failures
branch
from
February 22, 2022 15:47
70268b0
to
38710f8
Compare
PR #15141: Size comparison from cbdecce to 38710f8 Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…re not dispatched in the basic cluster
vivien-apple
force-pushed
the
Logging_Basic_LogEvent_Failures
branch
from
February 23, 2022 11:01
38710f8
to
42b71ff
Compare
PR #15141: Size comparison from 9fa5641 to 42b71ff Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re not dispatched in the basic cluster
Problem
When the
StartUp
event or theShutDown
event fails to be dispatched inBasic.cpp
the specific reason is not logged. I'm trying to debug some failures to launch theShutDown
event on Darwin and this is not helping at first sight.Change overview
Testing
Tried by running some code where the
ShutDown
event is not dispatch for "some" reason. With this patch I can clearly identify where the failures comes from, which is that the session manager is off...