-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data version support for IM write #15101
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/add_data_version_write
Feb 12, 2022
Merged
Add data version support for IM write #15101
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/add_data_version_write
Feb 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02 and
mlepage-google
February 11, 2022 20:16
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 11, 2022 20:16
yunhanw-google
force-pushed
the
feature/add_data_version_write
branch
2 times, most recently
from
February 11, 2022 20:46
52fdf51
to
3cd108d
Compare
PR #15101: Size comparison from d344a98 to 3cd108d Increases above 0.2%:
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 11, 2022
yunhanw-google
force-pushed
the
feature/add_data_version_write
branch
from
February 11, 2022 21:54
3cd108d
to
676eb53
Compare
jmartinez-silabs
approved these changes
Feb 11, 2022
PR #15101: Size comparison from dabb721 to 676eb53 Increases above 0.2%:
Increases (10 builds for cyw30739, k32w, linux, qpg, telink)
Full report (11 builds for cyw30739, k32w, linux, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_data_version_write
branch
from
February 11, 2022 22:19
676eb53
to
bd94dd6
Compare
PR #15101: Size comparison from dabb721 to bd94dd6 Increases above 0.2%:
Increases (13 builds for cyw30739, k32w, linux, p6, qpg, telink)
Full report (14 builds for cyw30739, k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_data_version_write
branch
from
February 11, 2022 22:51
bd94dd6
to
eb0159d
Compare
PR #15101: Size comparison from 6d99e64 to eb0159d Increases above 0.2%:
Increases (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_data_version_write
branch
2 times, most recently
from
February 12, 2022 00:08
0ca60c0
to
15c416b
Compare
yunhanw-google
force-pushed
the
feature/add_data_version_write
branch
from
February 12, 2022 00:21
15c416b
to
f751ff3
Compare
PR #15101: Size comparison from 2155328 to f751ff3 Increases above 0.2%:
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yufengwangca
approved these changes
Feb 12, 2022
This was referenced Feb 12, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per IM spec, need to add optional data version for attributeDataIB when sending IM write request, and process it in write handler, when version mismatch happens, the data would not be written.
Change overview
--Add support to inject optional data version for attributeDataIB in IM write request, and process it in write handler. when version mismatch happens, the data would not be written, and generate version mismatch status.
--Update python test
--Add chip-tool support on it.
Testing
Add unit test for IM write to check version allowed and version mismatch for particular cluster
Add python e2e test to write matched version and mismatched version, and check the returned result.
Run manual chip-tool testing.