Stop using PRI*8 printf formats. #15099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not supported on some embedded/minimal libcs. Use %u/%d/%x
instead, since [u]int8_t will get promoted to int anyway when passed
via varargs.
This commit was generated by installing the git-extras package and running:
git sed -f g '" PRIu8 "' 'u'
git sed -f g '" PRIu8' 'u"'
git sed -f g '" PRIx8 "' 'x'
git sed -f g '" PRIx8' 'x"'
git sed -f g '" PRIX8 "' 'X'
git sed -f g '" PRIX8' 'X"'
git sed -f g '" PRId8 "' 'd'
git sed -f g '" PRId8' 'd"'
followed by the following manual fixups:
1) Fixing a comment in src/app/MessageDef/StatusIB.cpp
2) Deleting an unused macro in src/system/SystemStats.h
3) Reverting the change the above git sed commands caused in
third_party/lwip/repo/lwip/src/include/lwip/arch.h
4) Adding a lint.
5) Running restyle.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
tcarmelveilleux
approved these changes
Feb 11, 2022
|
PR #15099: Size comparison from 23d423f to f3c4fac Decreases (29 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mlepage-google
approved these changes
Feb 11, 2022
jmartinez-silabs
approved these changes
Feb 11, 2022
saurabhst
approved these changes
Feb 11, 2022
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Feb 12, 2022
This reverts commit 2155328.
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
These are not supported on some embedded/minimal libcs. Use %u/%d/%x
instead, since [u]int8_t will get promoted to int anyway when passed
via varargs.
This commit was generated by installing the git-extras package and running:
git sed -f g '" PRIu8 "' 'u'
git sed -f g '" PRIu8' 'u"'
git sed -f g '" PRIx8 "' 'x'
git sed -f g '" PRIx8' 'x"'
git sed -f g '" PRIX8 "' 'X'
git sed -f g '" PRIX8' 'X"'
git sed -f g '" PRId8 "' 'd'
git sed -f g '" PRId8' 'd"'
followed by the following manual fixups:
1) Fixing a comment in src/app/MessageDef/StatusIB.cpp
2) Deleting an unused macro in src/system/SystemStats.h
3) Reverting the change the above git sed commands caused in
third_party/lwip/repo/lwip/src/include/lwip/arch.h
4) Adding a lint.
5) Running restyle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not supported on some embedded/minimal libcs. Use %u/%d/%x
instead, since [u]int8_t will get promoted to int anyway when passed
via varargs.
This commit was generated by installing the git-extras package and running:
followed by the following manual fixups:
third_party/lwip/repo/lwip/src/include/lwip/arch.h
Problem
Log statements can print garbage or even crash, due to libcs ignoring these and ending up with format/args mismatches.
Change overview
See above.
Testing
Ideally no behavior changes in our CI, and fewer logging problems on devices.