Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YAML] Get nodeId to be an optional parameter for tests #15072

Merged
merged 4 commits into from
Feb 11, 2022
Merged

[YAML] Get nodeId to be an optional parameter for tests #15072

merged 4 commits into from
Feb 11, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

WaitForCommissionee which is used to retrieve a device when the test starts, or when a new device has been paired uses a nodeId that comes from the command line. But this nodeId is not exposed to YAML and there may be different nodeIds for tests that uses multiple fabrics.

Change overview

  • Get nodeId to be an optional parameter by declaring it on the config section
  • Update all the tests to use it

Testing

I have updated all the tests...

@vivien-apple vivien-apple force-pushed the YAML_nodeIdOptionalParameter branch from f52e387 to e6b3ec3 Compare February 11, 2022 09:54
@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

PR #15072: Size comparison from 0edb9f9 to e6b3ec3

Increases above 0.2%:

platform target config section 0edb9f9 e6b3ec3 change % change
linux chip-tool-ipv6only arm64 .text 6972292 6990292 18000 0.3
Increases (1 build for linux)
platform target config section 0edb9f9 e6b3ec3 change % change
linux chip-tool-ipv6only arm64 (read only) 8135596 8153612 18016 0.2
.rodata 433956 433972 16 0.0
.text 6972292 6990292 18000 0.3
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0edb9f9 e6b3ec3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595150 595150 0 0.0
.app_xip_area 496564 496564 0 0.0
.bss 81284 81284 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552954 552954 0 0.0
.app_xip_area 455936 455936 0 0.0
.bss 79756 79756 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571890 571890 0 0.0
.app_xip_area 465616 465616 0 0.0
.bss 88684 88684 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909560 909560 0 0.0
(read/write) 129104 129104 0 0.0
.bss 127072 127072 0 0.0
.data 2032 2032 0 0.0
.text 909552 909552 0 0.0
BRD4161A+rpc (read only) 897020 897020 0 0.0
(read/write) 145764 145764 0 0.0
.bss 143632 143632 0 0.0
.data 2132 2132 0 0.0
.text 897012 897012 0 0.0
window-app BRD4161A (read only) 844640 844640 0 0.0
(read/write) 127168 127168 0 0.0
.bss 125264 125264 0 0.0
.data 1900 1900 0 0.0
.text 844632 844632 0 0.0
esp32 all-clusters-app c3devkit (read only) 945430 945430 0 0.0
(read/write) 1400306 1400306 0 0.0
.dram0.bss 68128 68128 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199016 199016 0 0.0
.flash.text 945430 945430 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995071 995071 0 0.0
(read/write) 465576 465576 0 0.0
.dram0.bss 73272 73272 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226112 226112 0 0.0
.flash.text 989687 989687 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 685636 685636 0 0.0
.bss 78376 78376 0 0.0
.data 1904 1904 0 0.0
.text 599556 599556 0 0.0
lock k32w061+release (read/write) 691064 691064 0 0.0
.bss 78768 78768 0 0.0
.data 1948 1948 0 0.0
.text 604548 604548 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8135596 8153612 18016 0.2
(read/write) 341217 341217 0 0.0
.bss 51681 51681 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 235568 235568 0 0.0
.dynamic 560 560 0 0.0
.got 48952 48952 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 433956 433972 16 0.0
.text 6972292 6990292 18000 0.3
thermostat-no-ble arm64 (read only) 2150204 2150204 0 0.0
(read/write) 142225 142225 0 0.0
.bss 59105 59105 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74984 74984 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132876 132876 0 0.0
.text 1799184 1799184 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398264 2398264 0 0.0
.bss 190196 190196 0 0.0
.data 5320 5320 0 0.0
.text 1360864 1360864 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360152 2360152 0 0.0
.bss 182808 182808 0 0.0
.data 5624 5624 0 0.0
.text 1322752 1322752 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323680 2323680 0 0.0
.bss 182696 182696 0 0.0
.data 5600 5600 0 0.0
.text 1286280 1286280 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309116 2309116 0 0.0
.bss 179948 179948 0 0.0
.data 5424 5424 0 0.0
.text 1271688 1271688 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1017907 1017907 0 0.0
bss 123132 123132 0 0.0
rodata 119984 119984 0 0.0
text 695896 695896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 986735 986735 0 0.0
bss 120320 120320 0 0.0
rodata 111348 111348 0 0.0
text 675508 675508 0 0.0
nrf52840dongle_nrf52840 (read/write) 1033731 1033731 0 0.0
bss 124520 124520 0 0.0
rodata 118844 118844 0 0.0
text 700484 700484 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 924646 924646 0 0.0
bss 119696 119696 0 0.0
rodata 113224 113224 0 0.0
text 610932 610932 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947731 947731 0 0.0
bss 121504 121504 0 0.0
rodata 108728 108728 0 0.0
text 638900 638900 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 855210 855210 0 0.0
bss 118096 118096 0 0.0
rodata 101900 101900 0 0.0
text 554708 554708 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 946575 946575 0 0.0
bss 121224 121224 0 0.0
rodata 107708 107708 0 0.0
text 638956 638956 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 942495 942495 0 0.0
bss 121228 121228 0 0.0
rodata 107380 107380 0 0.0
text 635196 635196 0 0.0
shell nrf52840dk_nrf52840 (read/write) 806207 806207 0 0.0
bss 112376 112376 0 0.0
rodata 78948 78948 0 0.0
text 537304 537304 0 0.0
p6 all-clusters-app default (read/write) 2483960 2483960 0 0.0
.bss 119816 119816 0 0.0
.data 2672 2672 0 0.0
.text 1442224 1442224 0 0.0
light-app default (read/write) 2390544 2390544 0 0.0
.bss 109464 109464 0 0.0
.data 2520 2520 0 0.0
.text 1348808 1348808 0 0.0
lock-app default (read/write) 2354016 2354016 0 0.0
.bss 109184 109184 0 0.0
.data 2480 2480 0 0.0
.text 1312280 1312280 0 0.0
qpg lighting-app qpg6105+debug (read only) 595528 595528 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90656 90656 0 0.0
.data 1108 1108 0 0.0
.text 590208 590208 0 0.0
lock-app qpg6105+debug (read only) 561280 561280 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90640 90640 0 0.0
.data 1060 1060 0 0.0
.text 555960 555960 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877134 877134 0 0.0
bss 90456 90456 0 0.0
noinit 37160 37160 0 0.0
text 615198 615198 0 0.0

@vivien-apple vivien-apple self-assigned this Feb 11, 2022
@vivien-apple vivien-apple force-pushed the YAML_nodeIdOptionalParameter branch from e6b3ec3 to 64094bb Compare February 11, 2022 13:46
@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

PR #15072: Size comparison from ad68b4b to 64094bb

Full report (15 builds for cyw30739, efr32, k32w, p6, qpg, telink)
platform target config section ad68b4b 64094bb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595258 595258 0 0.0
.app_xip_area 496672 496672 0 0.0
.bss 81284 81284 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 553062 553062 0 0.0
.app_xip_area 456044 456044 0 0.0
.bss 79756 79756 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571998 571998 0 0.0
.app_xip_area 465724 465724 0 0.0
.bss 88684 88684 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909688 909688 0 0.0
(read/write) 129104 129104 0 0.0
.bss 127072 127072 0 0.0
.data 2032 2032 0 0.0
.text 909680 909680 0 0.0
BRD4161A+rpc (read only) 897132 897132 0 0.0
(read/write) 145764 145764 0 0.0
.bss 143632 143632 0 0.0
.data 2132 2132 0 0.0
.text 897124 897124 0 0.0
window-app BRD4161A (read only) 844752 844752 0 0.0
(read/write) 127168 127168 0 0.0
.bss 125264 125264 0 0.0
.data 1900 1900 0 0.0
.text 844744 844744 0 0.0
k32w light k32w061+release (read/write) 685744 685744 0 0.0
.bss 78376 78376 0 0.0
.data 1904 1904 0 0.0
.text 599664 599664 0 0.0
lock k32w061+release (read/write) 691172 691172 0 0.0
.bss 78768 78768 0 0.0
.data 1948 1948 0 0.0
.text 604656 604656 0 0.0
p6 all-clusters-app default (read/write) 2484056 2484056 0 0.0
.bss 119816 119816 0 0.0
.data 2672 2672 0 0.0
.text 1442320 1442320 0 0.0
light-app default (read/write) 2390640 2390640 0 0.0
.bss 109464 109464 0 0.0
.data 2520 2520 0 0.0
.text 1348904 1348904 0 0.0
lock-app default (read/write) 2354096 2354096 0 0.0
.bss 109184 109184 0 0.0
.data 2480 2480 0 0.0
.text 1312360 1312360 0 0.0
qpg lighting-app qpg6105+debug (read only) 595636 595636 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90656 90656 0 0.0
.data 1108 1108 0 0.0
.text 590316 590316 0 0.0
lock-app qpg6105+debug (read only) 561388 561388 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90640 90640 0 0.0
.data 1060 1060 0 0.0
.text 556068 556068 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877134 877134 0 0.0
bss 90456 90456 0 0.0
noinit 37160 37160 0 0.0
text 615198 615198 0 0.0

@vivien-apple vivien-apple force-pushed the YAML_nodeIdOptionalParameter branch from 64094bb to cf21dad Compare February 11, 2022 14:27
woody-apple
woody-apple approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking test tool changes.

@vivien-apple vivien-apple merged commit 0e47f35 into project-chip:master Feb 11, 2022
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@vivien-apple @fuxingguo16
[YAML] Get nodeId to be an optional parameter for tests (project-chip…
f69dd18 
…#15072)

* [YAML] Get NodeId to be an optional parameter of the test run

* [YAML] Update the tests to have a nodeId optional parameters, and to use it into WaitForCommissionee

* [YAML] Update src/darwin/Framework/CHIP test template

* Update generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
app examples fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivien-apple @woody-apple