-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Darwin framework errors to represend all IM errors. #14973
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-errors
Feb 10, 2022
Merged
Allow Darwin framework errors to represend all IM errors. #14973
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-errors
Feb 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
requested review from
anush-apple,
sagar-apple and
vivien-apple
February 9, 2022 19:32
pullapprove
bot
requested review from
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02 and
msandstedt
February 9, 2022 19:32
pullapprove
bot
requested review from
mspang,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple and
xylophone21
February 9, 2022 19:32
woody-apple
approved these changes
Feb 9, 2022
Fast tracking platform changes. |
PR #14973: Size comparison from 1744422 to ee1a99c Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-errors
branch
from
February 9, 2022 20:54
ee1a99c
to
3e5da41
Compare
PR #14973: Size comparison from 482e6fd to 3e5da41 Decreases (1 build for linux)
Full report (2 builds for linux)
|
We kept having to add IM errors one at a time. Just add them all at once. Also more clearly disambiguates "IM error status returned" from "something went wrong on our end".
bzbarsky-apple
force-pushed
the
darwin-errors
branch
from
February 9, 2022 23:12
3e5da41
to
3aff950
Compare
yunhanw-google
approved these changes
Feb 9, 2022
PR #14973: Size comparison from d42c084 to 3aff950 Increases (24 builds for cyw30739, efr32, k32w, mbed, nrfconnect, p6, qpg)
Decreases (6 builds for linux)
Full report (41 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We kept having to add IM errors one at a time. Just add them all at
once.
Also more clearly disambiguates "IM error status returned" from
"something went wrong on our end".
Problem
See above.
Change overview
See above.
Testing
Should be no behavior changes. Tests all pass. Framework consumers can get more informative errors.