Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FabricIndex be a common thing across all sessions. #14904

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Make FabricIndex be a common thing across all sessions. #14904

merged 7 commits into from
Feb 9, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Fabric index getting is often required for all session types, including group and secure sessions.
Having separation requires special handling between session types and the existing code of AsSecureSession()->GetFabricIndex() would crash for group sessions.

Change overview

Move fabric index to common code (Session.h) and use it from Secure and Group session.

fixes #13396

Testing

Flashed a devkit-c and commissioned it with chip-tool running the changed code.

@restyled-io restyled-io bot mentioned this pull request Feb 8, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14904: Size comparison from 8d0fd6b to 539b1d1

Increases (1 build for esp32)
platform target config section 8d0fd6b 539b1d1 change % change
esp32 all-clusters-app m5stack (read only) 987351 987355 4 0.0
.flash.text 981967 981971 4 0.0
Decreases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8d0fd6b 539b1d1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595362 595250 -112 -0.0
.app_xip_area 500896 500880 -16 -0.0
.bss 77188 77092 -96 -0.1
lock cyw930739m2evb_01 (read/write) 556314 556210 -104 -0.0
.app_xip_area 463384 463376 -8 -0.0
.bss 75684 75588 -96 -0.1
ota-requestor cyw930739m2evb_01 (read/write) 577278 577166 -112 -0.0
.app_xip_area 475052 475036 -16 -0.0
.bss 84652 84556 -96 -0.1
efr32 lighting-app BRD4161A (read only) 866340 866308 -32 -0.0
(read/write) 126684 126588 -96 -0.1
.bss 124760 124664 -96 -0.1
.text 866332 866300 -32 -0.0
BRD4161A+rpc (read only) 853788 853772 -16 -0.0
(read/write) 143344 143248 -96 -0.1
.bss 141320 141224 -96 -0.1
.text 853780 853764 -16 -0.0
window-app BRD4161A (read only) 838544 838528 -16 -0.0
(read/write) 125328 125232 -96 -0.1
.bss 123448 123352 -96 -0.1
.text 838536 838520 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 939198 939158 -40 -0.0
(read/write) 1401874 1401778 -96 -0.0
.dram0.bss 70024 69928 -96 -0.1
.flash.text 939198 939158 -40 -0.0
m5stack (read/write) 466892 466796 -96 -0.0
.dram0.bss 75160 75064 -96 -0.1
k32w light k32w061+release (read/write) 679164 679052 -112 -0.0
.bss 76632 76536 -96 -0.1
.text 594848 594832 -16 -0.0
lock k32w061+release (read/write) 683980 683868 -112 -0.0
.bss 76984 76888 -96 -0.1
.text 599268 599252 -16 -0.0
linux all-clusters-app debug (read only) 2334441 2334425 -16 -0.0
(read/write) 140640 140512 -128 -0.1
.bss 55200 55072 -128 -0.2
.text 1967218 1967202 -16 -0.0
bridge-app debug+rpc (read only) 1705893 1705877 -16 -0.0
(read/write) 84328 84200 -128 -0.2
.bss 39088 38960 -128 -0.3
.text 1449013 1448997 -16 -0.0
chip-tool debug (read only) 7472957 7472925 -32 -0.0
(read/write) 197624 197496 -128 -0.1
.bss 32360 32232 -128 -0.4
.text 6656741 6656709 -32 -0.0
chip-tool-ipv6only arm64 (read/write) 301857 301729 -128 -0.0
.bss 50641 50513 -128 -0.3
door-lock-app debug (read only) 1910601 1910585 -16 -0.0
(read/write) 110680 110552 -128 -0.1
.bss 42160 42032 -128 -0.3
.text 1590226 1590210 -16 -0.0
lighting-app debug+rpc (read only) 2005161 2005145 -16 -0.0
(read/write) 115632 115504 -128 -0.1
.bss 43104 42976 -128 -0.3
.text 1687458 1687442 -16 -0.0
ota-provider-app debug (read only) 1714489 1714473 -16 -0.0
(read/write) 81368 81240 -128 -0.2
.bss 41120 40992 -128 -0.3
.text 1443874 1443858 -16 -0.0
ota-requestor-app debug (read only) 1703145 1703129 -16 -0.0
(read/write) 83320 83192 -128 -0.2
.bss 42272 42144 -128 -0.3
.text 1441202 1441186 -16 -0.0
shell debug (read only) 2307913 2307897 -16 -0.0
(read/write) 142224 141968 -256 -0.2
.bss 62592 62336 -256 -0.4
.text 1945746 1945730 -16 -0.0
thermostat-no-ble arm64 (read/write) 141009 140881 -128 -0.1
.bss 57953 57825 -128 -0.2
tv-app debug (read only) 2521065 2521033 -32 -0.0
(read/write) 140056 139928 -128 -0.1
.bss 57568 57440 -128 -0.2
.text 2150786 2150754 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2390960 2390896 -64 -0.0
.bss 188932 188836 -96 -0.1
.text 1353560 1353496 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2349384 -64 -0.0
.bss 181000 180904 -96 -0.1
.text 1312048 1311984 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2317344 -64 -0.0
.bss 180912 180816 -96 -0.1
.text 1280008 1279944 -64 -0.0
shell CY8CPROTO_062_4343W+release .bss 178164 178068 -96 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005691 1005547 -144 -0.0
bss 121352 121256 -96 -0.1
text 687028 687012 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 974535 974391 -144 -0.0
bss 118540 118444 -96 -0.1
text 666644 666624 -20 -0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022223 -160 -0.0
bss 122716 122620 -96 -0.1
text 692600 692580 -20 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912306 912178 -128 -0.0
bss 117912 117816 -96 -0.1
text 602056 602036 -20 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 940759 940615 -144 -0.0
bss 119720 119624 -96 -0.1
text 634936 634912 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848218 848106 -112 -0.0
bss 116312 116216 -96 -0.1
text 550732 550712 -20 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 940179 940035 -144 -0.0
bss 119440 119344 -96 -0.1
text 635192 635168 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935519 935375 -144 -0.0
bss 119444 119348 -96 -0.1
text 631224 631204 -20 -0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803783 -128 -0.0
bss 111304 111208 -96 -0.1
text 536272 536264 -8 -0.0
p6 all-clusters-app default (read/write) 2465504 2465472 -32 -0.0
.bss 118544 118448 -96 -0.1
.text 1423768 1423736 -32 -0.0
light-app default (read/write) 2367760 2367728 -32 -0.0
.bss 107664 107568 -96 -0.1
.text 1326024 1325992 -32 -0.0
lock-app default (read/write) 2336584 2336536 -48 -0.0
.bss 107400 107304 -96 -0.1
.text 1294848 1294800 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 586352 586328 -24 -0.0
.bss 88920 88824 -96 -0.1
.text 581032 581008 -24 -0.0
lock-app qpg6105+debug (read only) 535308 535284 -24 -0.0
.bss 88392 88296 -96 -0.1
.text 529988 529964 -24 -0.0
telink lighting-app tlsr9518adk80d (read/write) 870150 870014 -136 -0.0
bss 88680 88584 -96 -0.1
text 611492 611446 -46 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8d0fd6b 539b1d1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595362 595250 -112 -0.0
.app_xip_area 500896 500880 -16 -0.0
.bss 77188 77092 -96 -0.1
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556314 556210 -104 -0.0
.app_xip_area 463384 463376 -8 -0.0
.bss 75684 75588 -96 -0.1
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577278 577166 -112 -0.0
.app_xip_area 475052 475036 -16 -0.0
.bss 84652 84556 -96 -0.1
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866340 866308 -32 -0.0
(read/write) 126684 126588 -96 -0.1
.bss 124760 124664 -96 -0.1
.data 1924 1924 0 0.0
.text 866332 866300 -32 -0.0
BRD4161A+rpc (read only) 853788 853772 -16 -0.0
(read/write) 143344 143248 -96 -0.1
.bss 141320 141224 -96 -0.1
.data 2024 2024 0 0.0
.text 853780 853764 -16 -0.0
window-app BRD4161A (read only) 838544 838528 -16 -0.0
(read/write) 125328 125232 -96 -0.1
.bss 123448 123352 -96 -0.1
.data 1880 1880 0 0.0
.text 838536 838520 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 939198 939158 -40 -0.0
(read/write) 1401874 1401778 -96 -0.0
.dram0.bss 70024 69928 -96 -0.1
.dram0.data 14260 14260 0 0.0
.flash.rodata 198680 198680 0 0.0
.flash.text 939198 939158 -40 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987351 987355 4 0.0
(read/write) 466892 466796 -96 -0.0
.dram0.bss 75160 75064 -96 -0.1
.dram0.data 34024 34024 0 0.0
.flash.rodata 225580 225580 0 0.0
.flash.text 981967 981971 4 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679164 679052 -112 -0.0
.bss 76632 76536 -96 -0.1
.data 1884 1884 0 0.0
.text 594848 594832 -16 -0.0
lock k32w061+release (read/write) 683980 683868 -112 -0.0
.bss 76984 76888 -96 -0.1
.data 1928 1928 0 0.0
.text 599268 599252 -16 -0.0
linux all-clusters-app debug (read only) 2334441 2334425 -16 -0.0
(read/write) 140640 140512 -128 -0.1
.bss 55200 55072 -128 -0.2
.data 1168 1168 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204901 204901 0 0.0
.text 1967218 1967202 -16 -0.0
bridge-app debug+rpc (read only) 1705893 1705877 -16 -0.0
(read/write) 84328 84200 -128 -0.2
.bss 39088 38960 -128 -0.3
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1449013 1448997 -16 -0.0
chip-tool debug (read only) 7472957 7472925 -32 -0.0
(read/write) 197624 197496 -128 -0.1
.bss 32360 32232 -128 -0.4
.data 1152 1152 0 0.0
.data.rel.ro 158088 158088 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 414773 414773 0 0.0
.text 6656741 6656709 -32 -0.0
chip-tool-ipv6only arm64 (read only) 7393100 7393100 0 0.0
(read/write) 301857 301729 -128 -0.0
.bss 50641 50513 -128 -0.3
.data 1176 1176 0 0.0
.data.rel.ro 199792 199792 0 0.0
.dynamic 560 560 0 0.0
.got 46448 46448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397508 397508 0 0.0
.text 6357140 6357140 0 0.0
door-lock-app debug (read only) 1910601 1910585 -16 -0.0
(read/write) 110680 110552 -128 -0.1
.bss 42160 42032 -128 -0.3
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171858 0 0.0
.text 1590226 1590210 -16 -0.0
lighting-app debug+rpc (read only) 2005161 2005145 -16 -0.0
(read/write) 115632 115504 -128 -0.1
.bss 43104 42976 -128 -0.3
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163057 0 0.0
.text 1687458 1687442 -16 -0.0
ota-provider-app debug (read only) 1714489 1714473 -16 -0.0
(read/write) 81368 81240 -128 -0.2
.bss 41120 40992 -128 -0.3
.data 1160 1160 0 0.0
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 151910 0 0.0
.text 1443874 1443858 -16 -0.0
ota-requestor-app debug (read only) 1703145 1703129 -16 -0.0
(read/write) 83320 83192 -128 -0.2
.bss 42272 42144 -128 -0.3
.data 1128 1128 0 0.0
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145047 145047 0 0.0
.text 1441202 1441186 -16 -0.0
shell debug (read only) 2307913 2307897 -16 -0.0
(read/write) 142224 141968 -256 -0.2
.bss 62592 62336 -256 -0.4
.data 768 768 0 0.0
.data.rel.ro 73168 73168 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205650 205650 0 0.0
.text 1945746 1945730 -16 -0.0
thermostat-no-ble arm64 (read only) 2134844 2134844 0 0.0
(read/write) 141009 140881 -128 -0.1
.bss 57953 57825 -128 -0.2
.data 984 984 0 0.0
.data.rel.ro 74952 74952 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132316 0 0.0
.text 1784368 1784368 0 0.0
tv-app debug (read only) 2521065 2521033 -32 -0.0
(read/write) 140056 139928 -128 -0.1
.bss 57568 57440 -128 -0.2
.data 3168 3168 0 0.0
.data.rel.ro 73288 73288 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196908 196908 0 0.0
.text 2150786 2150754 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390960 2390896 -64 -0.0
.bss 188932 188836 -96 -0.1
.data 5288 5288 0 0.0
.text 1353560 1353496 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349384 -64 -0.0
.bss 181000 180904 -96 -0.1
.data 5600 5600 0 0.0
.text 1312048 1311984 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317344 -64 -0.0
.bss 180912 180816 -96 -0.1
.data 5584 5584 0 0.0
.text 1280008 1279944 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303340 0 0.0
.bss 178164 178068 -96 -0.1
.data 5400 5400 0 0.0
.text 1265912 1265912 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005691 1005547 -144 -0.0
bss 121352 121256 -96 -0.1
rodata 118312 118312 0 0.0
text 687028 687012 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 974535 974391 -144 -0.0
bss 118540 118444 -96 -0.1
rodata 109700 109700 0 0.0
text 666644 666624 -20 -0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022223 -160 -0.0
bss 122716 122620 -96 -0.1
rodata 117200 117200 0 0.0
text 692600 692580 -20 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912306 912178 -128 -0.0
bss 117912 117816 -96 -0.1
rodata 111572 111572 0 0.0
text 602056 602036 -20 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 940759 940615 -144 -0.0
bss 119720 119624 -96 -0.1
rodata 107540 107540 0 0.0
text 634936 634912 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848218 848106 -112 -0.0
bss 116312 116216 -96 -0.1
rodata 100708 100708 0 0.0
text 550732 550712 -20 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940179 940035 -144 -0.0
bss 119440 119344 -96 -0.1
rodata 106896 106896 0 0.0
text 635192 635168 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935519 935375 -144 -0.0
bss 119444 119348 -96 -0.1
rodata 106188 106188 0 0.0
text 631224 631204 -20 -0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803783 -128 -0.0
bss 111304 111208 -96 -0.1
rodata 78716 78716 0 0.0
text 536272 536264 -8 -0.0
p6 all-clusters-app default (read/write) 2465504 2465472 -32 -0.0
.bss 118544 118448 -96 -0.1
.data 2568 2568 0 0.0
.text 1423768 1423736 -32 -0.0
light-app default (read/write) 2367760 2367728 -32 -0.0
.bss 107664 107568 -96 -0.1
.data 2432 2432 0 0.0
.text 1326024 1325992 -32 -0.0
lock-app default (read/write) 2336584 2336536 -48 -0.0
.bss 107400 107304 -96 -0.1
.data 2400 2400 0 0.0
.text 1294848 1294800 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 586352 586328 -24 -0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88824 -96 -0.1
.data 1084 1084 0 0.0
.text 581032 581008 -24 -0.0
lock-app qpg6105+debug (read only) 535308 535284 -24 -0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88296 -96 -0.1
.data 1028 1028 0 0.0
.text 529988 529964 -24 -0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 870150 870014 -136 -0.0
bss 88680 88584 -96 -0.1
noinit 37160 37160 0 0.0
text 611492 611446 -46 -0.0

bzbarsky-apple
bzbarsky-apple approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/WriteHandler.cpp Outdated Show resolved Hide resolved
src/transport/Session.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14904: Size comparison from 90c8884 to 2296d37

Decreases (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 90c8884 2296d37d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595166 -208 -0.0
.app_xip_area 500908 500796 -112 -0.0
.bss 77188 77092 -96 -0.1
lock cyw930739m2evb_01 (read/write) 556326 556118 -208 -0.0
.app_xip_area 463396 463284 -112 -0.0
.bss 75684 75588 -96 -0.1
ota-requestor cyw930739m2evb_01 (read/write) 577226 577018 -208 -0.0
.app_xip_area 475048 474936 -112 -0.0
.bss 84604 84508 -96 -0.1
efr32 lighting-app BRD4161A (read only) 866532 866308 -224 -0.0
(read/write) 126684 126588 -96 -0.1
.bss 124760 124664 -96 -0.1
.text 866524 866300 -224 -0.0
BRD4161A+rpc (read only) 853996 853788 -208 -0.0
(read/write) 143344 143248 -96 -0.1
.bss 141320 141224 -96 -0.1
.text 853988 853780 -208 -0.0
window-app BRD4161A (read only) 838752 838544 -208 -0.0
(read/write) 125328 125232 -96 -0.1
.bss 123448 123352 -96 -0.1
.text 838744 838536 -208 -0.0
esp32 all-clusters-app c3devkit (read only) 938970 938818 -152 -0.0
(read/write) 1397658 1397562 -96 -0.0
.dram0.bss 66328 66232 -96 -0.1
.flash.text 938970 938818 -152 -0.0
m5stack (read only) 987163 987095 -68 -0.0
(read/write) 462680 462584 -96 -0.0
.dram0.bss 71472 71376 -96 -0.1
.flash.text 981779 981711 -68 -0.0
k32w light k32w061+release (read/write) 679116 678908 -208 -0.0
.bss 76584 76488 -96 -0.1
.text 594848 594736 -112 -0.0
lock k32w061+release (read/write) 683996 683788 -208 -0.0
.bss 76984 76888 -96 -0.1
.text 599284 599172 -112 -0.0
linux chip-tool-ipv6only arm64 (read only) 7390428 7390172 -256 -0.0
(read/write) 301313 301185 -128 -0.0
.bss 50641 50513 -128 -0.3
.text 6355892 6355636 -256 -0.0
thermostat-no-ble arm64 (read only) 2131052 2130796 -256 -0.0
(read/write) 140673 140545 -128 -0.1
.bss 57665 57537 -128 -0.2
.text 1780880 1780624 -256 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389944 2389816 -128 -0.0
.bss 188404 188308 -96 -0.1
.text 1352544 1352416 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2349320 -128 -0.0
.bss 181000 180904 -96 -0.1
.text 1312048 1311920 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2317280 -128 -0.0
.bss 180912 180816 -96 -0.1
.text 1280008 1279880 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2303212 -128 -0.0
.bss 178164 178068 -96 -0.1
.text 1265912 1265784 -128 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1006427 1006315 -112 -0.0
bss 121320 121224 -96 -0.1
text 687896 687784 -112 -0.0
nrf52840dk_nrf52840+rpc (read/write) 975271 975159 -112 -0.0
bss 118508 118412 -96 -0.1
text 667512 667396 -116 -0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022143 -240 -0.0
bss 122716 122620 -96 -0.1
text 692608 692492 -116 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 913138 912930 -208 -0.0
bss 117880 117784 -96 -0.1
text 602924 602808 -116 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 940775 940519 -256 -0.0
bss 119720 119624 -96 -0.1
text 634944 634824 -120 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848234 848026 -208 -0.0
bss 116312 116216 -96 -0.1
text 550744 550624 -120 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 940195 939955 -240 -0.0
bss 119440 119344 -96 -0.1
text 635200 635084 -116 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935535 935279 -256 -0.0
bss 119444 119348 -96 -0.1
text 631236 631116 -120 -0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803783 -128 -0.0
bss 111304 111208 -96 -0.1
text 536272 536264 -8 -0.0
p6 all-clusters-app default (read/write) 2476616 2476392 -224 -0.0
.bss 117656 117560 -96 -0.1
.text 1434880 1434656 -224 -0.0
light-app default (read/write) 2380312 2380088 -224 -0.0
.bss 107296 107200 -96 -0.1
.text 1338576 1338352 -224 -0.0
lock-app default (read/write) 2349136 2348896 -240 -0.0
.bss 107040 106944 -96 -0.1
.text 1307400 1307160 -240 -0.0
qpg lighting-app qpg6105+debug (read only) 586320 586200 -120 -0.0
.bss 88872 88776 -96 -0.1
.text 581000 580880 -120 -0.0
lock-app qpg6105+debug (read only) 535316 535204 -112 -0.0
.bss 88392 88296 -96 -0.1
.text 529996 529884 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 866774 866526 -248 -0.0
bss 88664 88568 -96 -0.1
text 608368 608210 -158 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 90c8884 2296d37d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595166 -208 -0.0
.app_xip_area 500908 500796 -112 -0.0
.bss 77188 77092 -96 -0.1
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 556118 -208 -0.0
.app_xip_area 463396 463284 -112 -0.0
.bss 75684 75588 -96 -0.1
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577226 577018 -208 -0.0
.app_xip_area 475048 474936 -112 -0.0
.bss 84604 84508 -96 -0.1
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866532 866308 -224 -0.0
(read/write) 126684 126588 -96 -0.1
.bss 124760 124664 -96 -0.1
.data 1924 1924 0 0.0
.text 866524 866300 -224 -0.0
BRD4161A+rpc (read only) 853996 853788 -208 -0.0
(read/write) 143344 143248 -96 -0.1
.bss 141320 141224 -96 -0.1
.data 2024 2024 0 0.0
.text 853988 853780 -208 -0.0
window-app BRD4161A (read only) 838752 838544 -208 -0.0
(read/write) 125328 125232 -96 -0.1
.bss 123448 123352 -96 -0.1
.data 1880 1880 0 0.0
.text 838744 838536 -208 -0.0
esp32 all-clusters-app c3devkit (read only) 938970 938818 -152 -0.0
(read/write) 1397658 1397562 -96 -0.0
.dram0.bss 66328 66232 -96 -0.1
.dram0.data 14260 14260 0 0.0
.flash.rodata 198160 198160 0 0.0
.flash.text 938970 938818 -152 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987163 987095 -68 -0.0
(read/write) 462680 462584 -96 -0.0
.dram0.bss 71472 71376 -96 -0.1
.dram0.data 34024 34024 0 0.0
.flash.rodata 225056 225056 0 0.0
.flash.text 981779 981711 -68 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679116 678908 -208 -0.0
.bss 76584 76488 -96 -0.1
.data 1884 1884 0 0.0
.text 594848 594736 -112 -0.0
lock k32w061+release (read/write) 683996 683788 -208 -0.0
.bss 76984 76888 -96 -0.1
.data 1928 1928 0 0.0
.text 599284 599172 -112 -0.0
linux chip-tool-ipv6only arm64 (read only) 7390428 7390172 -256 -0.0
(read/write) 301313 301185 -128 -0.0
.bss 50641 50513 -128 -0.3
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 46400 46400 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397252 397252 0 0.0
.text 6355892 6355636 -256 -0.0
thermostat-no-ble arm64 (read only) 2131052 2130796 -256 -0.0
(read/write) 140673 140545 -128 -0.1
.bss 57665 57537 -128 -0.2
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132108 0 0.0
.text 1780880 1780624 -256 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389944 2389816 -128 -0.0
.bss 188404 188308 -96 -0.1
.data 5280 5280 0 0.0
.text 1352544 1352416 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349320 -128 -0.0
.bss 181000 180904 -96 -0.1
.data 5600 5600 0 0.0
.text 1312048 1311920 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317280 -128 -0.0
.bss 180912 180816 -96 -0.1
.data 5584 5584 0 0.0
.text 1280008 1279880 -128 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303212 -128 -0.0
.bss 178164 178068 -96 -0.1
.data 5400 5400 0 0.0
.text 1265912 1265784 -128 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1006427 1006315 -112 -0.0
bss 121320 121224 -96 -0.1
rodata 118312 118312 0 0.0
text 687896 687784 -112 -0.0
nrf52840dk_nrf52840+rpc (read/write) 975271 975159 -112 -0.0
bss 118508 118412 -96 -0.1
rodata 109700 109700 0 0.0
text 667512 667396 -116 -0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022143 -240 -0.0
bss 122716 122620 -96 -0.1
rodata 117200 117200 0 0.0
text 692608 692492 -116 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 913138 912930 -208 -0.0
bss 117880 117784 -96 -0.1
rodata 111572 111572 0 0.0
text 602924 602808 -116 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 940775 940519 -256 -0.0
bss 119720 119624 -96 -0.1
rodata 107540 107540 0 0.0
text 634944 634824 -120 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848234 848026 -208 -0.0
bss 116312 116216 -96 -0.1
rodata 100708 100708 0 0.0
text 550744 550624 -120 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940195 939955 -240 -0.0
bss 119440 119344 -96 -0.1
rodata 106896 106896 0 0.0
text 635200 635084 -116 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935535 935279 -256 -0.0
bss 119444 119348 -96 -0.1
rodata 106188 106188 0 0.0
text 631236 631116 -120 -0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803783 -128 -0.0
bss 111304 111208 -96 -0.1
rodata 78716 78716 0 0.0
text 536272 536264 -8 -0.0
p6 all-clusters-app default (read/write) 2476616 2476392 -224 -0.0
.bss 117656 117560 -96 -0.1
.data 2632 2632 0 0.0
.text 1434880 1434656 -224 -0.0
light-app default (read/write) 2380312 2380088 -224 -0.0
.bss 107296 107200 -96 -0.1
.data 2496 2496 0 0.0
.text 1338576 1338352 -224 -0.0
lock-app default (read/write) 2349136 2348896 -240 -0.0
.bss 107040 106944 -96 -0.1
.data 2464 2464 0 0.0
.text 1307400 1307160 -240 -0.0
qpg lighting-app qpg6105+debug (read only) 586320 586200 -120 -0.0
(read/write) 146936 146936 0 0.0
.bss 88872 88776 -96 -0.1
.data 1084 1084 0 0.0
.text 581000 580880 -120 -0.0
lock-app qpg6105+debug (read only) 535316 535204 -112 -0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88296 -96 -0.1
.data 1028 1028 0 0.0
.text 529996 529884 -112 -0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866774 866526 -248 -0.0
bss 88664 88568 -96 -0.1
noinit 37160 37160 0 0.0
text 608368 608210 -158 -0.0

@andy31415 andy31415 merged commit 1744422 into project-chip:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt Awaiting requested review from msandstedt

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples fast track review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of GetFabricIndex was broken in session handle refactor
3 participants
@andy31415 @woody-apple @bzbarsky-apple