-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ota] Parse OTA image header in nRF Connect and Linux platforms #14875
Merged
Damian-Nordic
merged 2 commits into
project-chip:master
from
Damian-Nordic:ota-header-nrf
Feb 9, 2022
Merged
[ota] Parse OTA image header in nRF Connect and Linux platforms #14875
Damian-Nordic
merged 2 commits into
project-chip:master
from
Damian-Nordic:ota-header-nrf
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kghost
February 8, 2022 09:41
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 8, 2022 09:41
PR #14875: Size comparison from 2f785f4 to 51970f9 Decreases (2 builds for cyw30739, qpg)
Full report (7 builds for cyw30739, qpg, telink)
|
Damian-Nordic
force-pushed
the
ota-header-nrf
branch
from
February 8, 2022 10:04
51970f9
to
ed0a394
Compare
PR #14875: Size comparison from 2f785f4 to ed0a394 Increases (3 builds for nrfconnect)
Decreases (7 builds for cyw30739, k32w, mbed, nrfconnect, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 8, 2022
Damian-Nordic
force-pushed
the
ota-header-nrf
branch
from
February 8, 2022 16:22
ed0a394
to
fea443a
Compare
tcarmelveilleux
approved these changes
Feb 8, 2022
PR #14875: Size comparison from b080024 to fea443a Increases (3 builds for nrfconnect)
Decreases (7 builds for cyw30739, k32w, mbed, nrfconnect, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
reviewed
Feb 8, 2022
selissia
reviewed
Feb 8, 2022
1. Make the OTA image header parser stateful to ease processing small blocks of the image. 2. Use the parser in the image processor for nRF Connect and Linux platforms.
Damian-Nordic
force-pushed
the
ota-header-nrf
branch
from
February 9, 2022 08:12
fea443a
to
19b661b
Compare
PR #14875: Size comparison from ce5f36b to 19b661b Increases (3 builds for nrfconnect)
Decreases (7 builds for cyw30739, k32w, mbed, nrfconnect, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current OTA image processors don't handle Matter-compliant OTA image header.
Change overview
Testing
Enhanced unit tests. Also, tested manually using Linux OTA requestor app and nRF Connect lighting-app (including that the download progress is finally working correctly).