-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Update group demo to include encryption configuration #14862
Merged
woody-apple
merged 7 commits into
project-chip:master
from
mkardous-silabs:test/group_demo
Feb 9, 2022
Merged
[Group] Update group demo to include encryption configuration #14862
woody-apple
merged 7 commits into
project-chip:master
from
mkardous-silabs:test/group_demo
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt and
harsha-rajendran
February 7, 2022 21:56
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 7, 2022 21:57
PR #14862: Size comparison from 6f9fa8e to f59316f Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for qpg)
Full report (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 8, 2022
/rebase |
woody-apple
force-pushed
the
test/group_demo
branch
from
February 8, 2022 07:05
f59316f
to
6be0272
Compare
PR #14862: Size comparison from 29e6a34 to 6be0272 Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mkardous-silabs
force-pushed
the
test/group_demo
branch
from
February 8, 2022 13:01
6be0272
to
4f5c4f8
Compare
PR #14862: Size comparison from 2f785f4 to 4f5c4f8 Increases above 0.2%:
Increases (14 builds for cyw30739, efr32, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (41 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Feb 8, 2022
woody-apple
approved these changes
Feb 8, 2022
bzbarsky-apple
approved these changes
Feb 9, 2022
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
jmartinez-silabs
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing