Restyle Dac fixup for pid vid change #14846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
We are moving to have the certificate verification check the VID and PID between the basic cluster and the DAC/CD. Right now, none of the examples pass prorperly because the VIDs and PIDs do not match. In order to facilitate development while platforms are developing their own DeviceAttestationCredentialsProvider, we have provided a new set of development certs that can be used for development only. This new scheme is backed by the test PAA in attestation/test/. This was done to reduce the number of changes required to the controllers, which already contain this PAA in their trusted certs. The PAI has been changed to omit the PID. This means the we can use a common PAI cert for all products. The vendor ID for the PAI is 0xFFF1, which a known test vendor for Matter. The DACs below are signed by the new PAI and include certs and keys for PIDs 0x8000-0x801F.
Test: Can commission linux lighting app using pid 0x8000
This new CD will veryify against all products with VID 0xFFF1
and PIDs in the range of 0x8000-0x8063.
Test: Verified on linux lighitng app by forcing app and controller
to use pid 0x8001
Please see documentation in docs/examples.
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
restyled-io
bot
force-pushed
the
restyled/dac_fixup_for_pid_vid_change
branch
from
25d7d67 to
928d7a5
Compare
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
restyled-io
bot
force-pushed
the
restyled/dac_fixup_for_pid_vid_change
branch
from
928d7a5 to
dbdf21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #14845 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.