Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure buff size constraints in chip logging module name fetch #14844

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Ensure buff size constraints in chip logging module name fetch #14844

merged 4 commits into from
Feb 7, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Potential buffer overflow in CHIPLogging.cpp

Change overview

Fixes it.

Fixes #4730

Testing

Compiled and ran chip-tool, saw logs looking good.

@boring-cyborg boring-cyborg bot added the lib label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14844: Size comparison from d5d9dc7 to d66215b

Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section d5d9dc7 d66215b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 587750 16 0.0
.app_xip_area 494468 494484 16 0.0
lock cyw930739m2evb_01 (read/write) 545646 545662 16 0.0
.app_xip_area 453940 453956 16 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570090 570106 16 0.0
.app_xip_area 469064 469080 16 0.0
efr32 lighting-app BRD4161A (read only) 857524 857540 16 0.0
.text 857516 857532 16 0.0
BRD4161A+rpc (read only) 844900 844916 16 0.0
.text 844892 844908 16 0.0
window-app BRD4161A (read only) 829776 829792 16 0.0
.text 829768 829784 16 0.0
esp32 all-clusters-app c3devkit (read only) 937038 937060 22 0.0
.flash.text 937038 937060 22 0.0
m5stack (read only) 985011 985023 12 0.0
.flash.text 979627 979639 12 0.0
k32w light k32w061+release (read/write) 672292 672324 32 0.0
.text 588920 588952 32 0.0
lock k32w061+release (read/write) 673760 673792 32 0.0
.text 590020 590052 32 0.0
linux chip-tool-ipv6only arm64 (read only) 7239492 7239572 80 0.0
.text 6241876 6241956 80 0.0
thermostat-no-ble arm64 (read only) 2127652 2127732 80 0.0
.text 1778288 1778368 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2312384 2312448 64 0.0
.text 1274984 1275048 64 0.0
p6 all-clusters-app default (read/write) 2450352 2450368 16 0.0
.text 1408616 1408632 16 0.0
light-app default (read/write) 2353784 2353800 16 0.0
.text 1312048 1312064 16 0.0
lock-app default (read/write) 2318984 2319000 16 0.0
.text 1277248 1277264 16 0.0
qpg lighting-app qpg6105+debug (read only) 580504 580520 16 0.0
.text 575184 575200 16 0.0
lock-app qpg6105+debug (read only) 526572 526588 16 0.0
.text 521252 521268 16 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107164 24 0.0
.text 101820 101844 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 859166 859182 16 0.0
text 602234 602254 20 0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section d5d9dc7 d66215b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 587750 16 0.0
.app_xip_area 494468 494484 16 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545662 16 0.0
.app_xip_area 453940 453956 16 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570090 570106 16 0.0
.app_xip_area 469064 469080 16 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857524 857540 16 0.0
(read/write) 125740 125740 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857516 857532 16 0.0
BRD4161A+rpc (read only) 844900 844916 16 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844892 844908 16 0.0
window-app BRD4161A (read only) 829776 829792 16 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829768 829784 16 0.0
esp32 all-clusters-app c3devkit (read only) 937038 937060 22 0.0
(read/write) 1401242 1401242 0 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 937038 937060 22 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985011 985023 12 0.0
(read/write) 465592 465592 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 979627 979639 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672292 672324 32 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588920 588952 32 0.0
lock k32w061+release (read/write) 673760 673792 32 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590020 590052 32 0.0
linux chip-tool-ipv6only arm64 (read only) 7239492 7239572 80 0.0
(read/write) 287921 287921 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186528 0 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392780 392780 0 0.0
.text 6241876 6241956 80 0.0
thermostat-no-ble arm64 (read only) 2127652 2127732 80 0.0
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131412 0 0.0
.text 1778288 1778368 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389200 2389200 0 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351800 1351800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348464 2348464 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311064 1311064 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312384 2312448 64 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274984 1275048 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302836 2302836 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265408 1265408 0 0.0
p6 all-clusters-app default (read/write) 2450352 2450368 16 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408616 1408632 16 0.0
light-app default (read/write) 2353784 2353800 16 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312048 1312064 16 0.0
lock-app default (read/write) 2318984 2319000 16 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277248 1277264 16 0.0
qpg lighting-app qpg6105+debug (read only) 580504 580520 16 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575184 575200 16 0.0
lock-app qpg6105+debug (read only) 526572 526588 16 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521252 521268 16 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107164 24 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101844 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 859166 859182 16 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602234 602254 20 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14844: Size comparison from d5d9dc7 to b16c62d

Increases above 0.2%:

platform target config section d5d9dc7 b16c62d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 594502 6768 1.2
.app_xip_area 494468 500356 5888 1.2
.bss 75988 76868 880 1.2
lock cyw930739m2evb_01 (read/write) 545646 552406 6760 1.2
.app_xip_area 453940 459820 5880 1.3
.bss 74460 75340 880 1.2
ota-requestor cyw930739m2evb_01 (read/write) 570090 576446 6356 1.1
.app_xip_area 469064 474540 5476 1.2
.bss 83452 84332 880 1.1
k32w light k32w061+release (read/write) 672292 678616 6324 0.9
.bss 75688 76568 880 1.2
.text 588920 594364 5444 0.9
lock k32w061+release (read/write) 673760 680500 6740 1.0
.bss 76016 76896 880 1.2
.text 590020 595880 5860 1.0
linux chip-tool-ipv6only arm64 (read only) 7239492 7263268 23776 0.3
.got 45784 45904 120 0.3
.text 6241876 6264244 22368 0.4
thermostat-no-ble arm64 .rodata 131412 131716 304 0.2
qpg lighting-app qpg6105+debug (read only) 580504 585936 5432 0.9
.bss 87976 88856 880 1.0
.text 575184 580616 5432 0.9
lock-app qpg6105+debug (read only) 526572 532004 5432 1.0
.bss 87424 88304 880 1.0
.text 521252 526684 5432 1.0
telink lighting-app tlsr9518adk80d (read/write) 859166 866366 7200 0.8
bss 88332 89208 876 1.0
text 602234 607664 5430 0.9
Increases (10 builds for cyw30739, k32w, linux, qpg, telink)
platform target config section d5d9dc7 b16c62d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 594502 6768 1.2
.app_xip_area 494468 500356 5888 1.2
.bss 75988 76868 880 1.2
lock cyw930739m2evb_01 (read/write) 545646 552406 6760 1.2
.app_xip_area 453940 459820 5880 1.3
.bss 74460 75340 880 1.2
ota-requestor cyw930739m2evb_01 (read/write) 570090 576446 6356 1.1
.app_xip_area 469064 474540 5476 1.2
.bss 83452 84332 880 1.1
k32w light k32w061+release (read/write) 672292 678616 6324 0.9
.bss 75688 76568 880 1.2
.text 588920 594364 5444 0.9
lock k32w061+release (read/write) 673760 680500 6740 1.0
.bss 76016 76896 880 1.2
.text 590020 595880 5860 1.0
linux chip-tool-ipv6only arm64 (read only) 7239492 7263268 23776 0.3
(read/write) 287921 288385 464 0.2
.data.rel.ro 186528 186872 344 0.2
.got 45784 45904 120 0.3
.rodata 392780 393132 352 0.1
.text 6241876 6264244 22368 0.4
thermostat-no-ble arm64 (read only) 2127652 2130212 2560 0.1
.rodata 131412 131716 304 0.2
.text 1778288 1780544 2256 0.1
qpg lighting-app qpg6105+debug (read only) 580504 585936 5432 0.9
.bss 87976 88856 880 1.0
.text 575184 580616 5432 0.9
lock-app qpg6105+debug (read only) 526572 532004 5432 1.0
.bss 87424 88304 880 1.0
.text 521252 526684 5432 1.0
telink lighting-app tlsr9518adk80d (read/write) 859166 866366 7200 0.8
bss 88332 89208 876 1.0
text 602234 607664 5430 0.9
Decreases (1 build for qpg)
platform target config section d5d9dc7 b16c62d change % change
qpg persistent-storage-app qpg6105+debug (read only) 107140 99520 -7620 -7.1
.bss 38504 24004 -14500 -37.7
.data 288 176 -112 -38.9
.text 101820 94200 -7620 -7.5
Full report (11 builds for cyw30739, k32w, linux, qpg, telink)
platform target config section d5d9dc7 b16c62d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 594502 6768 1.2
.app_xip_area 494468 500356 5888 1.2
.bss 75988 76868 880 1.2
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 552406 6760 1.2
.app_xip_area 453940 459820 5880 1.3
.bss 74460 75340 880 1.2
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570090 576446 6356 1.1
.app_xip_area 469064 474540 5476 1.2
.bss 83452 84332 880 1.1
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 672292 678616 6324 0.9
.bss 75688 76568 880 1.2
.data 1884 1884 0 0.0
.text 588920 594364 5444 0.9
lock k32w061+release (read/write) 673760 680500 6740 1.0
.bss 76016 76896 880 1.2
.data 1924 1924 0 0.0
.text 590020 595880 5860 1.0
linux chip-tool-ipv6only arm64 (read only) 7239492 7263268 23776 0.3
(read/write) 287921 288385 464 0.2
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186872 344 0.2
.dynamic 560 560 0 0.0
.got 45784 45904 120 0.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392780 393132 352 0.1
.text 6241876 6264244 22368 0.4
thermostat-no-ble arm64 (read only) 2127652 2130212 2560 0.1
(read/write) 140561 140561 0 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131716 304 0.2
.text 1778288 1780544 2256 0.1
qpg lighting-app qpg6105+debug (read only) 580504 585936 5432 0.9
(read/write) 146940 146940 0 0.0
.bss 87976 88856 880 1.0
.data 1088 1088 0 0.0
.text 575184 580616 5432 0.9
lock-app qpg6105+debug (read only) 526572 532004 5432 1.0
(read/write) 146940 146940 0 0.0
.bss 87424 88304 880 1.0
.data 1024 1024 0 0.0
.text 521252 526684 5432 1.0
persistent-storage-app qpg6105+debug (read only) 107140 99520 -7620 -7.1
(read/write) 146940 146940 0 0.0
.bss 38504 24004 -14500 -37.7
.data 288 176 -112 -38.9
.text 101820 94200 -7620 -7.5
telink lighting-app tlsr9518adk80d (read/write) 859166 866366 7200 0.8
bss 88332 89208 876 1.0
noinit 37160 37160 0 0.0
text 602234 607664 5430 0.9

@andy31415
Copy link
Contributor Author

size increases are not reasonable. Trying to re-trigger with master merge.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14844: Size comparison from 6f9fa8e to 9734954

Decreases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6f9fa8e 9734954 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594518 594502 -16 -0.0
.app_xip_area 500372 500356 -16 -0.0
lock cyw930739m2evb_01 (read/write) 552422 552406 -16 -0.0
.app_xip_area 459836 459820 -16 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 576462 576446 -16 -0.0
.app_xip_area 474556 474540 -16 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 853356 853340 -16 -0.0
.text 853348 853332 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 937480 937452 -28 -0.0
.flash.text 937480 937452 -28 -0.0
m5stack (read only) 985307 985291 -16 -0.0
.flash.text 979923 979907 -16 -0.0
k32w light k32w061+release (read/write) 678648 678616 -32 -0.0
.text 594396 594364 -32 -0.0
lock k32w061+release (read/write) 680532 680500 -32 -0.0
.text 595912 595880 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 7263300 7263268 -32 -0.0
.text 6264276 6264244 -32 -0.0
thermostat-no-ble arm64 (read only) 2129316 2129284 -32 -0.0
.text 1779504 1779472 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389760 2389696 -64 -0.0
.text 1352360 1352296 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read/write) 1139712 1139648 -64 -0.0
.text 103096 103032 -64 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2302884 2302820 -64 -0.0
.text 1265456 1265392 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004827 1004811 -16 -0.0
text 686540 686524 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 976319 976303 -16 -0.0
text 671188 671168 -20 -0.0
nrf52840dongle_nrf52840 (read/write) 1021647 1021631 -16 -0.0
text 692112 692096 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911506 911490 -16 -0.0
text 601568 601552 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 937083 937067 -16 -0.0
text 632460 632444 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844594 844578 -16 -0.0
text 548260 548244 -16 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541747 -32 -0.0
text 376940 376920 -20 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 939331 939315 -16 -0.0
text 634704 634688 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934671 934655 -16 -0.0
text 630740 630724 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 803343 803327 -16 -0.0
text 536004 535988 -16 -0.0
p6 all-clusters-app default (read/write) 2450984 2450968 -16 -0.0
.text 1409248 1409232 -16 -0.0
light-app default (read/write) 2354432 2354416 -16 -0.0
.text 1312696 1312680 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 585960 585936 -24 -0.0
.text 580640 580616 -24 -0.0
lock-app qpg6105+debug (read only) 532028 532004 -24 -0.0
.text 526708 526684 -24 -0.0
persistent-storage-app qpg6105+debug (read only) 99548 99520 -28 -0.0
.text 94228 94200 -28 -0.0
telink lighting-app tlsr9518adk80d (read/write) 865822 865790 -32 -0.0
text 607738 607706 -32 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6f9fa8e 9734954 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594518 594502 -16 -0.0
.app_xip_area 500372 500356 -16 -0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552422 552406 -16 -0.0
.app_xip_area 459836 459820 -16 -0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576462 576446 -16 -0.0
.app_xip_area 474556 474540 -16 -0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865884 865884 0 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865876 865876 0 0.0
BRD4161A+rpc (read only) 853356 853340 -16 -0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853348 853332 -16 -0.0
window-app BRD4161A (read only) 838104 838104 0 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 838096 838096 0 0.0
esp32 all-clusters-app c3devkit (read only) 937480 937452 -28 -0.0
(read/write) 1400986 1400986 0 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198352 198352 0 0.0
.flash.text 937480 937452 -28 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985307 985291 -16 -0.0
(read/write) 465320 465320 0 0.0
.dram0.bss 74200 74200 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224952 224952 0 0.0
.flash.text 979923 979907 -16 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678648 678616 -32 -0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594396 594364 -32 -0.0
lock k32w061+release (read/write) 680532 680500 -32 -0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595912 595880 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 7263300 7263268 -32 -0.0
(read/write) 288385 288385 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186872 186872 0 0.0
.dynamic 560 560 0 0.0
.got 45904 45904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 393132 393132 0 0.0
.text 6264276 6264244 -32 -0.0
thermostat-no-ble arm64 (read only) 2129316 2129284 -32 -0.0
(read/write) 140625 140625 0 0.0
.bss 57665 57665 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131860 131860 0 0.0
.text 1779504 1779472 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389760 2389696 -64 -0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352360 1352296 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348928 2348928 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311528 1311528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312848 2312848 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275448 1275448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139648 -64 -0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103032 -64 -0.1
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302884 2302820 -64 -0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265456 1265392 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004827 1004811 -16 -0.0
bss 121280 121280 0 0.0
rodata 118072 118072 0 0.0
text 686540 686524 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 976319 976303 -16 -0.0
bss 117136 117136 0 0.0
rodata 109532 109532 0 0.0
text 671188 671168 -20 -0.0
nrf52840dongle_nrf52840 (read/write) 1021647 1021631 -16 -0.0
bss 122644 122644 0 0.0
rodata 116960 116960 0 0.0
text 692112 692096 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911506 911490 -16 -0.0
bss 117840 117840 0 0.0
rodata 111332 111332 0 0.0
text 601568 601552 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 937083 937067 -16 -0.0
bss 119616 119616 0 0.0
rodata 106472 106472 0 0.0
text 632460 632444 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844594 844578 -16 -0.0
bss 116212 116212 0 0.0
rodata 99644 99644 0 0.0
text 548260 548244 -16 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541747 -32 -0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376920 -20 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 939331 939315 -16 -0.0
bss 119368 119368 0 0.0
rodata 106656 106656 0 0.0
text 634704 634688 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934671 934655 -16 -0.0
bss 119372 119372 0 0.0
rodata 105948 105948 0 0.0
text 630740 630724 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 803343 803327 -16 -0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 536004 535988 -16 -0.0
p6 all-clusters-app default (read/write) 2450984 2450968 -16 -0.0
.bss 116512 116512 0 0.0
.data 2584 2584 0 0.0
.text 1409248 1409232 -16 -0.0
light-app default (read/write) 2354432 2354416 -16 -0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312696 1312680 -16 -0.0
lock-app default (read/write) 2319616 2319616 0 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277880 1277880 0 0.0
qpg lighting-app qpg6105+debug (read only) 585960 585936 -24 -0.0
(read/write) 146940 146940 0 0.0
.bss 88856 88856 0 0.0
.data 1088 1088 0 0.0
.text 580640 580616 -24 -0.0
lock-app qpg6105+debug (read only) 532028 532004 -24 -0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526708 526684 -24 -0.0
persistent-storage-app qpg6105+debug (read only) 99548 99520 -28 -0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94228 94200 -28 -0.0
telink lighting-app tlsr9518adk80d (read/write) 865822 865790 -32 -0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607738 607706 -32 -0.0

@andy31415 andy31415 merged commit b99ce47 into project-chip:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetModuleName can write out of bounds on its buffer
3 participants
@andy31415 @msandstedt @bzbarsky-apple