-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CHIPClusters.cpp and various things it called into #14581
Merged
andy31415
merged 5 commits into
project-chip:master
from
bzbarsky-apple:remove-CHIPClusters-command-coden
Jan 31, 2022
Merged
Remove CHIPClusters.cpp and various things it called into #14581
andy31415
merged 5 commits into
project-chip:master
from
bzbarsky-apple:remove-CHIPClusters-command-coden
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google and
msandstedt
January 29, 2022 10:50
pullapprove
bot
requested review from
turon,
vijs,
wbschiller,
woody-apple and
xylophone21
January 29, 2022 10:50
bzbarsky-apple
force-pushed
the
remove-CHIPClusters-command-coden
branch
2 times, most recently
from
January 29, 2022 10:55
aa94ff1
to
d0bddac
Compare
PR #14581: Size comparison from 43a1e1a to d0bddac Decreases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 29, 2022
yunhanw-google
approved these changes
Jan 29, 2022
bzbarsky-apple
force-pushed
the
remove-CHIPClusters-command-coden
branch
from
January 29, 2022 17:06
cb9a643
to
e15f0ae
Compare
PR #14581: Size comparison from ddb7ce7 to e15f0ae Decreases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
remove-CHIPClusters-command-coden
branch
from
January 30, 2022 16:09
e15f0ae
to
1a480da
Compare
PR #14581: Size comparison from 8b503ad to 1a480da Decreases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
remove-CHIPClusters-command-coden
branch
from
January 31, 2022 02:30
1a480da
to
f3a8296
Compare
PR #14581: Size comparison from 8b503ad to f3a8296 Decreases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code is now dead, since we always go through InvokeInteraction for sending commands.
Change overview
Remove lots of dead code.
Testing
Should be no behavior changes. Just less code.