Support building CHIP with GN #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses build infrastructure from pigweed to enable building CHIP with GN.
|
This pull request introduces 4 alerts when merging 908aac8 into 8119459 - view on LGTM.com new alerts:
|
andy31415
approved these changes
Jul 7, 2020
woody-apple
requested changes
Jul 7, 2020
@mspang ? |
|
@mspang Main feedback for me is, either some docs for how to build, and some scripts to help :) Once those are in, I'm happy to make the GitHub workflow to help out too. |
And use the secondary_source feature to still allow loading them via
//build. This breaks using ${chip_root} in superproject builds, but that
was unnecessary anyway.
We should try to unwind this later as it causes some confusion about
what path to specify.
|
|
There is a script ./gn_build.sh at the top level to help get started. Looking at the github workflows now. |
The usual case is to source activate.sh, not bootstrap.sh, so move that first. bootstrap.sh is only needed after an update.
|
Added github workflows for standalone. |
BroderickCarlin
approved these changes
Jul 8, 2020
Remove a broken link that was left behind after moving build files to //gn.
|
nice work |
This was unmerged by a recent commit.
woody-apple
approved these changes
Jul 9, 2020
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Builds (especially configuration, incrementals) can be much faster.
Summary of Changes
A port of CHIP's automake build to the GN build system for Linux, Mac, & nRF5 example app.
fixes #1443