Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIP Config Cleanup: Removed Legacy (Unused) Security Configs #14553

Conversation

emargolis
Copy link
Contributor

Problem

There are many legacy configs that are not currently used in the latest SDK code.

Change overview

removed unused configs

Testing

@github-actions
Copy link

github-actions bot commented Jan 28, 2022

PR #14553: Size comparison from eb628d3 to fb6fe11

Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eb628d3 fb6fe11 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578126 578126 0 0.0
.app_xip_area 484220 484220 0 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536146 536146 0 0.0
.app_xip_area 443784 443784 0 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842968 842968 0 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842960 842960 0 0.0
BRD4161A+rpc (read only) 830320 830320 0 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830312 830312 0 0.0
window-app BRD4161A (read only) 815576 815576 0 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815568 815568 0 0.0
esp32 all-clusters-app c3devkit (read only) 933644 933644 0 0.0
(read/write) 1398082 1398082 0 0.0
.dram0.bss 69680 69680 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 195256 195256 0 0.0
.flash.text 933644 933644 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981471 981471 0 0.0
(read/write) 462452 462452 0 0.0
.dram0.bss 74432 74432 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221868 221868 0 0.0
.flash.text 976087 976087 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662956 662956 0 0.0
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578860 578860 0 0.0
lock k32w061+release (read/write) 663844 663844 0 0.0
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579460 579460 0 0.0
linux all-clusters-app debug (read only) 2288873 2288873 0 0.0
(read/write) 146288 146288 0 0.0
.bss 62560 62560 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 76824 76824 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 203957 203957 0 0.0
.text 1924258 1924258 0 0.0
bridge-app debug+rpc (read only) 1624021 1624021 0 0.0
(read/write) 88936 88936 0 0.0
.bss 44896 44896 0 0.0
.data 1794 1794 0 0.0
.data.rel.ro 37088 37088 0 0.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 137460 137460 0 0.0
.text 1371781 1371781 0 0.0
chip-tool debug (read only) 6959877 6959877 0 0.0
(read/write) 180336 180336 0 0.0
.bss 37240 37240 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 136016 136016 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 415745 415745 0 0.0
.text 6193605 6193605 0 0.0
chip-tool-ipv6only arm64 (read only) 6928124 6928124 0 0.0
(read/write) 283281 283281 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178312 178312 0 0.0
.dynamic 560 560 0 0.0
.got 44528 44528 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 396580 396580 0 0.0
.text 5949252 5949252 0 0.0
door-lock-app debug (read only) 1845633 1845633 0 0.0
(read/write) 119040 119040 0 0.0
.bss 51136 51136 0 0.0
.data 994 994 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170780 170780 0 0.0
.text 1527122 1527122 0 0.0
lighting-app debug+rpc (read only) 1945561 1945561 0 0.0
(read/write) 123968 123968 0 0.0
.bss 52056 52056 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 65040 65040 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 160785 160785 0 0.0
.text 1631026 1631026 0 0.0
ota-provider-app debug (read only) 1624809 1624809 0 0.0
(read/write) 88808 88808 0 0.0
.bss 50080 50080 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 32168 32168 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 147302 147302 0 0.0
.text 1360450 1360450 0 0.0
ota-requestor-app debug (read only) 1633217 1633217 0 0.0
(read/write) 91840 91840 0 0.0
.bss 51360 51360 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 34088 34088 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 143735 143735 0 0.0
.text 1373458 1373458 0 0.0
shell debug (read only) 2263785 2263785 0 0.0
(read/write) 148064 148064 0 0.0
.bss 70272 70272 0 0.0
.data 768 768 0 0.0
.data.rel.ro 71344 71344 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204690 204690 0 0.0
.text 1904370 1904370 0 0.0
thermostat-no-ble arm64 (read only) 2080748 2080748 0 0.0
(read/write) 149537 149537 0 0.0
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 129932 129932 0 0.0
.text 1733472 1733472 0 0.0
tv-app debug (read only) 2338913 2338913 0 0.0
(read/write) 321440 321440 0 0.0
.bss 241056 241056 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 71408 71408 0 0.0
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 198764 198764 0 0.0
.text 1970466 1970466 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2383808 2383808 0 0.0
.bss 188580 188580 0 0.0
.data 5288 5288 0 0.0
.text 1346408 1346408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338200 2338200 0 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300800 1300800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302240 2302240 0 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264840 1264840 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2292980 0 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255552 1255552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981375 0 0.0
bss 119660 119660 0 0.0
rodata 115684 115684 0 0.0
text 668228 668228 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 966923 0 0.0
bss 116704 116704 0 0.0
rodata 107160 107160 0 0.0
text 664672 664672 0 0.0
nrf52840dongle_nrf52840 (read/write) 997443 997443 0 0.0
bss 120832 120832 0 0.0
rodata 114516 114516 0 0.0
text 673652 673652 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890546 0 0.0
bss 116448 116448 0 0.0
rodata 108964 108964 0 0.0
text 584416 584416 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913971 913971 0 0.0
bss 118040 118040 0 0.0
rodata 104320 104320 0 0.0
text 614216 614216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824022 824022 0 0.0
bss 114856 114856 0 0.0
rodata 97528 97528 0 0.0
text 531176 531176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 916819 0 0.0
bss 117792 117792 0 0.0
rodata 104832 104832 0 0.0
text 616744 616744 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912019 912019 0 0.0
bss 117816 117816 0 0.0
rodata 103936 103936 0 0.0
text 612800 612800 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2443056 2443056 0 0.0
.bss 116732 116732 0 0.0
.data 2584 2584 0 0.0
.text 1401320 1401320 0 0.0
light-app default (read/write) 2338552 2338552 0 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296816 1296816 0 0.0
lock-app default (read/write) 2304048 2304048 0 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262312 1262312 0 0.0
qpg lighting-app qpg6105+debug (read only) 570884 570884 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565564 565564 0 0.0
lock-app qpg6105+debug (read only) 516996 516996 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511676 511676 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845786 845786 0 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592518 592518 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 6ba06b2 into project-chip:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants