-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIP Config Cleanup: Removed Legacy (Unused) Security Configs #14553
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/chip_config_cleanup
Jan 29, 2022
Merged
CHIP Config Cleanup: Removed Legacy (Unused) Security Configs #14553
bzbarsky-apple
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/chip_config_cleanup
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
config
darwin
efr32
esp32
examples
lib
linux
nrf connect
platform
telink
labels
Jan 28, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248 and
jelderton
January 28, 2022 22:50
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
January 28, 2022 22:50
PR #14553: Size comparison from eb628d3 to fb6fe11 Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 28, 2022
tcarmelveilleux
approved these changes
Jan 28, 2022
yufengwangca
approved these changes
Jan 29, 2022
msandstedt
approved these changes
Jan 29, 2022
bzbarsky-apple
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are many legacy configs that are not currently used in the latest SDK code.
Change overview
removed unused configs
Testing