-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Information cluster attribute cleanup #14489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attribute 0 (InteractionModelVersion) was changed to DataModelRevision in the spec. This commit updates the code. In the process, it was found that light-switch-app had been added with old ZAP JSON for Basic Info cluster and so it was updated. ZAP regen.
NodeLabel and LocalConfigDisabled are nonvolatile, but where listed in .zap files as RAM instead of NVM. Also, noticed second instance of Basic Info cluster in light-switch-app .zap that was outdated.
Set Basic Info cluster DataModelRevision to 10 (revision for initial release of spec).
boring-cyborg
bot
added
documentation
Improvements or additions to documentation
examples
labels
Jan 28, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda and
mrjerryjohns
January 28, 2022 08:57
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 28, 2022 08:57
PR #14489: Size comparison from d2fded9 to 91f88a1 Decreases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
And ZAP regen.
PR #14489: Size comparison from e2faf8f to 2909bbb Decreases (12 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
BasicClientFragment.kt still had a couple outdated and typoed symbols.
PR #14489: Size comparison from e2faf8f to 2ea5848 Increases (8 builds for nrfconnect)
Full report (10 builds for nrfconnect)
|
bzbarsky-apple
approved these changes
Jan 29, 2022
andy31415
approved these changes
Jan 31, 2022
jmeg-sfy
approved these changes
Feb 1, 2022
And ZAP regen.
PR #14489: Size comparison from cb9b046 to 4e79ddf Decreases (2 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
examples
fast track
github
review - pending
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Change InteractionModelVersion to DataModelRevision.
Update light-switch-app ZAP JSON.
Change NodeLabel and LocalConfigDisabled to NVM in ZAP JSON.
ZAP regen.
Testing
How was this tested? (at least one bullet point required)