-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear FabricID during factory reset for Infineon P6 Platform #14483
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
praveenCY:topic/pucn_factoryreset
Jan 29, 2022
Merged
Clear FabricID during factory reset for Infineon P6 Platform #14483
bzbarsky-apple
merged 1 commit into
project-chip:master
from
praveenCY:topic/pucn_factoryreset
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
pan-apple
January 28, 2022 07:20
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 28, 2022 07:20
PR #14483: Size comparison from d2fded9 to 789721e Increases (3 builds for p6)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 28, 2022
tcarmelveilleux
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving platform-only change with basic oversight
jmartinez-silabs
approved these changes
Jan 28, 2022
/rebase |
woody-apple
force-pushed
the
topic/pucn_factoryreset
branch
from
January 29, 2022 00:29
789721e
to
0a06840
Compare
PR #14483: Size comparison from 4e1a999 to 0a06840 Increases (3 builds for p6)
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Infineon P6 device stuck in non-commissioning mode after factory reset
Error message after factory reset ""Fabric already commissioned. Disabling BLE advertisement"
Change overview
Testing
Tested lock app for P6 and Commissioning works properly after factory-reset