Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the name in all .zap files #14445

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Update the name in all .zap files #14445

merged 1 commit into from
Jan 28, 2022

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Jan 27, 2022 •
edited
Loading

Problem

What is being fixed? Examples:

  • some names in zap file are out of date, such as all attributes should be set its reportable bit to 1 by default

Change overview

Run ./scripts/tools/zap_convert_all.py to update the name in all the .zap files.
Run `./scripts/tools/zap_regen_all.py to generate content from the updated files

Testing

How was this tested? (at least one bullet point required)

  • autogen update only, regression is covered by CI

@yufengwangca yufengwangca changed the title Update the name in all the .zap files Update the name in all .zap files Jan 27, 2022
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14445: Size comparison from 7119eaa to 9e2436e

Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 7119eaa 9e2436e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580794 580794 0 0.0
.app_xip_area 485592 485592 0 0.0
.bss 77948 77948 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538806 538806 0 0.0
.app_xip_area 445148 445148 0 0.0
.bss 76444 76444 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 844292 844292 0 0.0
(read/write) 127492 127492 0 0.0
.bss 125592 125592 0 0.0
.data 1900 1900 0 0.0
.text 844284 844284 0 0.0
BRD4161A+rpc (read only) 831640 831640 0 0.0
(read/write) 144152 144152 0 0.0
.bss 142152 142152 0 0.0
.data 2000 2000 0 0.0
.text 831632 831632 0 0.0
window-app BRD4161A (read only) 816868 816868 0 0.0
(read/write) 126148 126148 0 0.0
.bss 124292 124292 0 0.0
.data 1856 1856 0 0.0
.text 816860 816860 0 0.0
k32w light k32w061+release (read/write) 665592 665592 0 0.0
.bss 77724 77724 0 0.0
.data 1868 1868 0 0.0
.text 580200 580200 0 0.0
lock k32w061+release (read/write) 666544 666544 0 0.0
.bss 77988 77988 0 0.0
.data 1892 1892 0 0.0
.text 580864 580864 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6765620 6765620 0 0.0
(read/write) 279201 279201 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 175984 0 0.0
.dynamic 560 560 0 0.0
.got 42784 42784 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 386892 386892 0 0.0
.text 5806628 5806628 0 0.0
thermostat-no-ble arm64 (read only) 2083308 2083308 0 0.0
(read/write) 152129 152129 0 0.0
.bss 69761 69761 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130396 130396 0 0.0
.text 1735424 1735424 0 0.0
p6 all-clusters-app default (read/write) 2442944 2442944 0 0.0
.bss 118036 118036 0 0.0
.data 2584 2584 0 0.0
.text 1401208 1401208 0 0.0
light-app default (read/write) 2339856 2339856 0 0.0
.bss 105780 105780 0 0.0
.data 2408 2408 0 0.0
.text 1298120 1298120 0 0.0
lock-app default (read/write) 2305368 2305368 0 0.0
.bss 105524 105524 0 0.0
.data 2360 2360 0 0.0
.text 1263632 1263632 0 0.0
qpg lighting-app qpg6105+debug (read only) 572284 572284 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89936 89936 0 0.0
.data 1060 1060 0 0.0
.text 566964 566964 0 0.0
lock-app qpg6105+debug (read only) 518404 518404 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89408 89408 0 0.0
.data 992 992 0 0.0
.text 513084 513084 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848562 848562 0 0.0
bss 87736 87736 0 0.0
noinit 37160 37160 0 0.0
text 593542 593542 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14445: Size comparison from 33c4854 to 0227474

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 33c4854 0227474 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580794 580794 0 0.0
.app_xip_area 485592 485592 0 0.0
.bss 77948 77948 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538806 538806 0 0.0
.app_xip_area 445148 445148 0 0.0
.bss 76444 76444 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 844292 844292 0 0.0
(read/write) 127492 127492 0 0.0
.bss 125592 125592 0 0.0
.data 1900 1900 0 0.0
.text 844284 844284 0 0.0
BRD4161A+rpc (read only) 831640 831640 0 0.0
(read/write) 144152 144152 0 0.0
.bss 142152 142152 0 0.0
.data 2000 2000 0 0.0
.text 831632 831632 0 0.0
window-app BRD4161A (read only) 816868 816868 0 0.0
(read/write) 126148 126148 0 0.0
.bss 124292 124292 0 0.0
.data 1856 1856 0 0.0
.text 816860 816860 0 0.0
esp32 all-clusters-app c3devkit (read only) 933614 933614 0 0.0
(read/write) 1399146 1399146 0 0.0
.dram0.bss 70984 70984 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 195008 195008 0 0.0
.flash.text 933614 933614 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981223 981223 0 0.0
(read/write) 463500 463500 0 0.0
.dram0.bss 75728 75728 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221620 221620 0 0.0
.flash.text 975839 975839 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665592 665592 0 0.0
.bss 77724 77724 0 0.0
.data 1868 1868 0 0.0
.text 580200 580200 0 0.0
lock k32w061+release (read/write) 666544 666544 0 0.0
.bss 77988 77988 0 0.0
.data 1892 1892 0 0.0
.text 580864 580864 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6765620 6765620 0 0.0
(read/write) 279201 279201 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 175984 0 0.0
.dynamic 560 560 0 0.0
.got 42784 42784 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 386892 386892 0 0.0
.text 5806628 5806628 0 0.0
thermostat-no-ble arm64 (read only) 2083308 2083308 0 0.0
(read/write) 152129 152129 0 0.0
.bss 69761 69761 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130396 130396 0 0.0
.text 1735424 1735424 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2383488 2383488 0 0.0
.bss 189692 189692 0 0.0
.data 5288 5288 0 0.0
.text 1346088 1346088 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341360 2341360 0 0.0
.bss 181200 181200 0 0.0
.data 5584 5584 0 0.0
.text 1303960 1303960 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308112 2308112 0 0.0
.bss 181096 181096 0 0.0
.data 5568 5568 0 0.0
.text 1270712 1270712 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294324 2294324 0 0.0
.bss 177828 177828 0 0.0
.data 5384 5384 0 0.0
.text 1256896 1256896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984063 984063 0 0.0
bss 120956 120956 0 0.0
rodata 116180 116180 0 0.0
text 669136 669136 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 969643 969643 0 0.0
bss 118000 118000 0 0.0
rodata 107656 107656 0 0.0
text 665580 665580 0 0.0
nrf52840dongle_nrf52840 (read/write) 1000183 1000183 0 0.0
bss 122128 122128 0 0.0
rodata 115032 115032 0 0.0
text 674564 674564 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 893282 893282 0 0.0
bss 117744 117744 0 0.0
rodata 109476 109476 0 0.0
text 585316 585316 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916675 916675 0 0.0
bss 119336 119336 0 0.0
rodata 104816 104816 0 0.0
text 615120 615120 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826714 826714 0 0.0
bss 116152 116152 0 0.0
rodata 98044 98044 0 0.0
text 532072 532072 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919539 919539 0 0.0
bss 119088 119088 0 0.0
rodata 105328 105328 0 0.0
text 617656 617656 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914723 914723 0 0.0
bss 119112 119112 0 0.0
rodata 104432 104432 0 0.0
text 613696 613696 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2442944 2442944 0 0.0
.bss 118036 118036 0 0.0
.data 2584 2584 0 0.0
.text 1401208 1401208 0 0.0
light-app default (read/write) 2339856 2339856 0 0.0
.bss 105780 105780 0 0.0
.data 2408 2408 0 0.0
.text 1298120 1298120 0 0.0
lock-app default (read/write) 2305368 2305368 0 0.0
.bss 105524 105524 0 0.0
.data 2360 2360 0 0.0
.text 1263632 1263632 0 0.0
qpg lighting-app qpg6105+debug (read only) 572284 572284 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89936 89936 0 0.0
.data 1060 1060 0 0.0
.text 566964 566964 0 0.0
lock-app qpg6105+debug (read only) 518404 518404 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89408 89408 0 0.0
.data 992 992 0 0.0
.text 513084 513084 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848562 848562 0 0.0
bss 87736 87736 0 0.0
noinit 37160 37160 0 0.0
text 593542 593542 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

PR #14445: Size comparison from 92f8343 to 351258f

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 92f8343 351258f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578130 578130 0 0.0
.app_xip_area 484224 484224 0 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536142 536142 0 0.0
.app_xip_area 443780 443780 0 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842984 842984 0 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842976 842976 0 0.0
BRD4161A+rpc (read only) 830336 830336 0 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830328 830328 0 0.0
window-app BRD4161A (read only) 815560 815560 0 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815552 815552 0 0.0
esp32 all-clusters-app c3devkit (read only) 932734 932734 0 0.0
(read/write) 1397322 1397322 0 0.0
.dram0.bss 69688 69688 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 194480 194480 0 0.0
.flash.text 932734 932734 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980687 980687 0 0.0
(read/write) 461692 461692 0 0.0
.dram0.bss 74432 74432 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221108 221108 0 0.0
.flash.text 975303 975303 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662940 662940 0 0.0
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578844 578844 0 0.0
lock k32w061+release (read/write) 663844 663844 0 0.0
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579460 579460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6765620 6765620 0 0.0
(read/write) 279201 279201 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 175984 0 0.0
.dynamic 560 560 0 0.0
.got 42784 42784 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 386892 386892 0 0.0
.text 5806628 5806628 0 0.0
thermostat-no-ble arm64 (read only) 2080620 2080620 0 0.0
(read/write) 149537 149537 0 0.0
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 129932 129932 0 0.0
.text 1733344 1733344 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382408 2382408 0 0.0
.bss 188588 188588 0 0.0
.data 5288 5288 0 0.0
.text 1345008 1345008 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338200 2338200 0 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300800 1300800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302240 2302240 0 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264840 1264840 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2292980 0 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255552 1255552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981375 0 0.0
bss 119660 119660 0 0.0
rodata 115684 115684 0 0.0
text 668228 668228 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 966923 0 0.0
bss 116704 116704 0 0.0
rodata 107160 107160 0 0.0
text 664672 664672 0 0.0
nrf52840dongle_nrf52840 (read/write) 997459 997459 0 0.0
bss 120832 120832 0 0.0
rodata 114516 114516 0 0.0
text 673656 673656 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890546 0 0.0
bss 116448 116448 0 0.0
rodata 108964 108964 0 0.0
text 584416 584416 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913955 913955 0 0.0
bss 118040 118040 0 0.0
rodata 104320 104320 0 0.0
text 614212 614212 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824006 824006 0 0.0
bss 114856 114856 0 0.0
rodata 97528 97528 0 0.0
text 531172 531172 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 916819 0 0.0
bss 117792 117792 0 0.0
rodata 104832 104832 0 0.0
text 616748 616748 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912003 912003 0 0.0
bss 117816 117816 0 0.0
rodata 103936 103936 0 0.0
text 612788 612788 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2441656 2441656 0 0.0
.bss 116740 116740 0 0.0
.data 2584 2584 0 0.0
.text 1399920 1399920 0 0.0
light-app default (read/write) 2338568 2338568 0 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296832 1296832 0 0.0
lock-app default (read/write) 2304080 2304080 0 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262344 1262344 0 0.0
qpg lighting-app qpg6105+debug (read only) 570884 570884 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565564 565564 0 0.0
lock-app qpg6105+debug (read only) 517004 517004 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511684 511684 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845770 845770 0 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592508 592508 0 0.0

@andy31415 andy31415 merged commit bbd6bd3 into project-chip:master Jan 28, 2022
@yufengwangca yufengwangca deleted the pr/cluster/cleanup branch January 28, 2022 16:01
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@yufengwangca @selissia
Update the name in all the .zap files (project-chip#14445)
4550b82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @andy31415 @bzbarsky-apple