Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code PairDevice calls to work with network params. #14429

Merged
merged 13 commits into from
Mar 9, 2022
Merged

Update code PairDevice calls to work with network params. #14429

merged 13 commits into from
Mar 9, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Jan 27, 2022

Problem

The setup code PairDevice functions had no way to pass in commissioning parameters, which meant it wasn't possible to commission BLE devices by code.

Change overview

  • Adds a function to the auto commissioner to allow adding commissioning parameters incrementally
  • Add commissioning parameters as a function parameter to the pair device calls for setup codes
  • Adds pairing options to chip tool to allow this path

Testing

Chip tool commissioning M5 over BLE

@pullapprove pullapprove bot requested a review from isiu-apple January 29, 2022 06:46
@woody-apple
Copy link
Contributor

(Note this needs a rebase to resolve the Darwin test failure)

@stale
Copy link

stale bot commented Feb 15, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 15, 2022
@pullapprove pullapprove bot requested a review from lazarkov February 15, 2022 18:41
@caipiblack caipiblack mentioned this pull request Feb 21, 2022
Closed
@stale
Copy link

stale bot commented Feb 23, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Feb 23, 2022
@stale stale bot removed the stale Stale issue or PR label Feb 23, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 2, 2022
@stale stale bot removed the stale Stale issue or PR label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022 •
edited
Loading

PR #14429: Size comparison from 796ba98 to fd49c4f

Increases above 0.2%:

platform target config section 796ba98 fd49c4f change % change
linux chip-tool debug (read/write) 338232 339480 1248 0.4
.data.rel.ro 305504 306752 1248 0.4
chip-tool-ipv6only arm64 (read/write) 453761 455057 1296 0.3
.data.rel.ro 350648 351896 1248 0.4
Increases (2 builds for linux)
platform target config section 796ba98 fd49c4f change % change
linux chip-tool debug (read only) 9746901 9753189 6288 0.1
(read/write) 338232 339480 1248 0.4
.data.rel.ro 305504 306752 1248 0.4
.rodata 509812 509876 64 0.0
.text 8498613 8501957 3344 0.0
chip-tool-ipv6only arm64 (read only) 9420276 9426436 6160 0.1
(read/write) 453761 455057 1296 0.3
.data.rel.ro 350648 351896 1248 0.4
.got 54272 54320 48 0.1
.rodata 485612 485660 48 0.0
.text 7931956 7935044 3088 0.0
Decreases (1 build for linux)
platform target config section 796ba98 fd49c4f change % change
linux tv-app debug (read only) 2617369 2617177 -192 -0.0
.rodata 199389 199293 -96 -0.0
.text 2243698 2243602 -96 -0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 796ba98 fd49c4f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601654 601654 0 0.0
.app_xip_area 506188 506188 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559630 559630 0 0.0
.app_xip_area 465700 465700 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581826 581826 0 0.0
.app_xip_area 478216 478216 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920724 920724 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920716 920716 0 0.0
BRD4161A+rpc (read only) 949560 949560 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949552 949552 0 0.0
lock-app BRD4161A+wf200 (read only) 988692 988692 0 0.0
(read/write) 120368 120368 0 0.0
.bss 118436 118436 0 0.0
.data 1932 1932 0 0.0
.text 988684 988684 0 0.0
window-app BRD4161A (read only) 853784 853784 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853776 853776 0 0.0
esp32 all-clusters-app c3devkit (read only) 957276 957276 0 0.0
(read/write) 1393586 1393586 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957276 957276 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012079 1012079 0 0.0
(read/write) 460692 460692 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006695 1006695 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694616 694616 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609148 609148 0 0.0
lock k32w061+release (read/write) 696204 696204 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610760 610760 0 0.0
linux all-clusters-app debug (read only) 2425521 2425521 0 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205349 205349 0 0.0
.text 2057042 2057042 0 0.0
bridge-app debug+rpc (read only) 1730805 1730805 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1473013 1473013 0 0.0
chip-tool debug (read only) 9746901 9753189 6288 0.1
(read/write) 338232 339480 1248 0.4
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305504 306752 1248 0.4
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 509812 509876 64 0.0
.text 8498613 8501957 3344 0.0
chip-tool-ipv6only arm64 (read only) 9420276 9426436 6160 0.1
(read/write) 453761 455057 1296 0.3
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 350648 351896 1248 0.4
.dynamic 560 560 0 0.0
.got 54272 54320 48 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485612 485660 48 0.0
.text 7931956 7935044 3088 0.0
door-lock-app debug (read only) 1945161 1945161 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622754 1622754 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165692 165692 0 0.0
.text 1755458 1755458 0 0.0
ota-provider-app debug (read only) 1878017 1878017 0 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1568290 1568290 0 0.0
ota-requestor-app debug (read only) 1900081 1900081 0 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154124 154124 0 0.0
.text 1595730 1595730 0 0.0
shell debug (read only) 2392305 2392305 0 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205298 205298 0 0.0
.text 2030098 2030098 0 0.0
thermostat-no-ble arm64 (read only) 2174116 2174116 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 132948 0 0.0
.text 1822544 1822544 0 0.0
tv-app debug (read only) 2617369 2617177 -192 -0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199293 -96 -0.0
.text 2243698 2243602 -96 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151515 1151515 0 0.0
bss 146792 146792 0 0.0
rodata 144276 144276 0 0.0
text 785260 785260 0 0.0
p6 all-clusters-app default (read/write) 2493880 2493880 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452144 1452144 0 0.0
light-app default (read/write) 2397328 2397328 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355592 1355592 0 0.0
lock-app default (read/write) 2360808 2360808 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319072 1319072 0 0.0
qpg lighting-app qpg6105+debug (read only) 603812 603812 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1164 1164 0 0.0
.text 598492 598492 0 0.0
lock-app qpg6105+debug (read only) 569480 569480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91088 91088 0 0.0
.data 1116 1116 0 0.0
.text 564160 564160 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888670 888670 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628058 628058 0 0.0

cecille added 2 commits March 8, 2022 13:24
@cecille
Merge remote-tracking branch 'upstream/master' into setupcodepairer_n…
7073408 
…etworking
@cecille
Fix initialization
0196c04 
Something somewhere got messed becuase the initialization happens
in the destructor which is not correct for obvious reasons.
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #14429: Size comparison from 535c6c8 to 0196c04

Increases above 0.2%:

platform target config section 535c6c8 0196c04 change % change
linux chip-tool debug (read/write) 338488 339736 1248 0.4
.data.rel.ro 305816 307064 1248 0.4
chip-tool-ipv6only arm64 (read/write) 454177 455473 1296 0.3
.data.rel.ro 351000 352248 1248 0.4
Increases (2 builds for linux)
platform target config section 535c6c8 0196c04 change % change
linux chip-tool debug (read only) 9758533 9765893 7360 0.1
(read/write) 338488 339736 1248 0.4
.data.rel.ro 305816 307064 1248 0.4
.text 8508373 8512917 4544 0.1
chip-tool-ipv6only arm64 (read only) 9430548 9438004 7456 0.1
(read/write) 454177 455473 1296 0.3
.data.rel.ro 351000 352248 1248 0.4
.got 54360 54408 48 0.1
.rodata 486556 486588 32 0.0
.text 7940244 7944644 4400 0.1
Decreases (2 builds for linux)
platform target config section 535c6c8 0196c04 change % change
linux chip-tool debug .rodata 510868 510804 -64 -0.0
tv-app debug (read only) 2617097 2616665 -432 -0.0
.rodata 199453 199261 -192 -0.1
.text 2243746 2243506 -240 -0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 535c6c8 0196c04 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601818 601818 0 0.0
.app_xip_area 506360 506360 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559726 559726 0 0.0
.app_xip_area 465804 465804 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581918 581918 0 0.0
.app_xip_area 478316 478316 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920868 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920860 0 0.0
BRD4161A+rpc (read only) 949688 949688 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949680 0 0.0
window-app BRD4161A (read only) 853888 853888 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853880 0 0.0
esp32 all-clusters-app c3devkit (read only) 957506 957506 0 0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957506 957506 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012267 1012267 0 0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006883 1006883 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694852 694852 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609384 609384 0 0.0
lock k32w061+release (read/write) 696456 696456 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 611012 611012 0 0.0
linux all-clusters-app debug (read only) 2427097 2427097 0 0.0
(read/write) 145584 145584 0 0.0
.bss 60096 60096 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78360 78360 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205541 205541 0 0.0
.text 2058642 2058642 0 0.0
bridge-app debug+rpc (read only) 1731837 1731837 0 0.0
(read/write) 92560 92560 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1474213 1474213 0 0.0
chip-tool debug (read only) 9758533 9765893 7360 0.1
(read/write) 338488 339736 1248 0.4
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305816 307064 1248 0.4
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510804 -64 -0.0
.text 8508373 8512917 4544 0.1
chip-tool-ipv6only arm64 (read only) 9430548 9438004 7456 0.1
(read/write) 454177 455473 1296 0.3
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 352248 1248 0.4
.dynamic 560 560 0 0.0
.got 54360 54408 48 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486588 32 0.0
.text 7940244 7944644 4400 0.1
door-lock-app debug (read only) 1946161 1946161 0 0.0
(read/write) 119008 119008 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1623954 1623954 0 0.0
lighting-app debug+rpc (read only) 2078441 2078441 0 0.0
(read/write) 124360 124360 0 0.0
.bss 51232 51232 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66040 66040 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165820 165820 0 0.0
.text 1757058 1757058 0 0.0
ota-provider-app debug (read only) 1879017 1879017 0 0.0
(read/write) 114640 114640 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57416 57416 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1569490 1569490 0 0.0
ota-requestor-app debug (read only) 1901033 1901033 0 0.0
(read/write) 117352 117352 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59112 59112 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154220 154220 0 0.0
.text 1596850 1596850 0 0.0
shell debug (read only) 2393209 2393209 0 0.0
(read/write) 149768 149768 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205458 205458 0 0.0
.text 2031250 2031250 0 0.0
thermostat-no-ble arm64 (read only) 2174612 2174612 0 0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1823312 0 0.0
tv-app debug (read only) 2617097 2616665 -432 -0.0
(read/write) 250648 250648 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73504 73504 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199261 -192 -0.1
.text 2243746 2243506 -240 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1151827 0 0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785544 785544 0 0.0
p6 all-clusters-app default (read/write) 2494056 2494056 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452320 1452320 0 0.0
light-app default (read/write) 2397512 2397512 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355776 1355776 0 0.0
lock-app default (read/write) 2360944 2360944 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319208 1319208 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888986 888986 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628350 628350 0 0.0

@cecille
Fix auto documentation.
39a5c4a 
Functions order was confusing the documentation.
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #14429: Size comparison from 535c6c8 to 39a5c4a

Increases above 0.2%:

platform target config section 535c6c8 39a5c4a change % change
linux chip-tool debug (read/write) 338488 339864 1376 0.4
.data.rel.ro 305816 307176 1360 0.4
chip-tool-ipv6only arm64 (read/write) 454177 455633 1456 0.3
.data.rel.ro 351000 352384 1384 0.4
thermostat-no-ble arm64 .got 4216 4240 24 0.6
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 535c6c8 39a5c4a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601818 602090 272 0.0
.app_xip_area 506360 506608 248 0.0
.bss 78140 78172 32 0.0
lock cyw930739m2evb_01 (read/write) 559726 559998 272 0.0
.app_xip_area 465804 466052 248 0.1
.bss 76644 76676 32 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581918 582190 272 0.0
.app_xip_area 478316 478564 248 0.1
.bss 85972 86004 32 0.0
efr32 lighting-app BRD4161A (read only) 920868 921344 476 0.1
(read/write) 128848 128872 24 0.0
.bss 126768 126800 32 0.0
.text 920860 921336 476 0.1
BRD4161A+rpc (read only) 949688 950180 492 0.1
(read/write) 144808 144828 20 0.0
.bss 142544 142576 32 0.0
.text 949680 950172 492 0.1
window-app BRD4161A (read only) 853888 854380 492 0.1
(read/write) 126840 126852 12 0.0
.bss 124912 124936 24 0.0
.text 853880 854372 492 0.1
esp32 all-clusters-app c3devkit (read only) 957506 957942 436 0.0
(read/write) 1393618 1393674 56 0.0
.dram0.bss 63432 63480 48 0.1
.flash.rodata 197032 197056 24 0.0
.flash.text 957506 957942 436 0.0
m5stack (read only) 1012267 1012743 476 0.0
(read/write) 460724 460772 48 0.0
.dram0.bss 68960 69000 40 0.1
.flash.rodata 225848 225872 24 0.0
.flash.text 1006883 1007359 476 0.0
k32w light k32w061+release (read/write) 694852 695256 404 0.1
.bss 77704 77736 32 0.0
.text 609384 609764 380 0.1
lock k32w061+release (read/write) 696456 696860 404 0.1
.bss 77672 77704 32 0.0
.text 611012 611392 380 0.1
linux all-clusters-app debug (read only) 2427097 2428721 1624 0.1
(read/write) 145584 145712 128 0.1
.bss 60096 60192 96 0.2
.data.rel.ro 78360 78424 64 0.1
.text 2058642 2060194 1552 0.1
bridge-app debug+rpc (read only) 1731837 1733421 1584 0.1
(read/write) 92560 92656 96 0.1
.bss 47432 47496 64 0.1
.data.rel.ro 38008 38064 56 0.1
.text 1474213 1475701 1488 0.1
chip-tool debug (read only) 9758533 9768869 10336 0.1
(read/write) 338488 339864 1376 0.4
.data.rel.ro 305816 307176 1360 0.4
.text 8508373 8515701 7328 0.1
chip-tool-ipv6only arm64 (read only) 9430548 9440868 10320 0.1
(read/write) 454177 455633 1456 0.3
.data.rel.ro 351000 352384 1384 0.4
.got 54360 54424 64 0.1
.rodata 486556 486620 64 0.0
.text 7940244 7947172 6928 0.1
door-lock-app debug (read only) 1946161 1947745 1584 0.1
(read/write) 119008 119136 128 0.1
.bss 50432 50496 64 0.1
.data.rel.ro 62136 62184 48 0.1
.text 1623954 1625442 1488 0.1
lighting-app debug+rpc (read only) 2078441 2080025 1584 0.1
(read/write) 124360 124456 96 0.1
.bss 51232 51296 64 0.1
.data.rel.ro 66040 66104 64 0.1
.text 1757058 1758546 1488 0.1
ota-provider-app debug (read only) 1879017 1880601 1584 0.1
(read/write) 114640 114736 96 0.1
.bss 50240 50304 64 0.1
.data.rel.ro 57416 57464 48 0.1
.text 1569490 1570978 1488 0.1
ota-requestor-app debug (read only) 1901033 1902617 1584 0.1
(read/write) 117352 117448 96 0.1
.bss 51296 51360 64 0.1
.data.rel.ro 59112 59176 64 0.1
.text 1596850 1598338 1488 0.1
shell debug (read only) 2393209 2394833 1624 0.1
(read/write) 149768 149928 160 0.1
.bss 70216 70312 96 0.1
.data.rel.ro 73008 73064 56 0.1
.text 2031250 2032802 1552 0.1
thermostat-no-ble arm64 (read only) 2174612 2176500 1888 0.1
(read/write) 148465 148673 208 0.1
.bss 65201 65281 80 0.1
.data.rel.ro 75000 75136 136 0.2
.got 4216 4240 24 0.6
.text 1823312 1824912 1600 0.1
tv-app debug (read only) 2617097 2620105 3008 0.1
(read/write) 250648 250840 192 0.1
.bss 167904 168000 96 0.1
.data.rel.ro 73504 73624 120 0.2
.text 2243746 2246754 3008 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1152335 508 0.0
bss 146792 146832 40 0.0
rodata 144300 144328 28 0.0
text 785544 785912 368 0.0
p6 all-clusters-app default (read/write) 2494056 2494568 512 0.0
.bss 119504 119544 40 0.0
.text 1452320 1452832 512 0.0
light-app default (read/write) 2397512 2398000 488 0.0
.bss 112976 113008 32 0.0
.text 1355776 1356264 488 0.0
lock-app default (read/write) 2360944 2361432 488 0.0
.bss 112720 112752 32 0.0
.text 1319208 1319696 488 0.0
telink lighting-app tlsr9518adk80d (read/write) 888986 889534 548 0.1
bss 86928 86968 40 0.0
text 628350 628840 490 0.1
Decreases (21 builds for cyw30739, efr32, esp32, k32w, linux, p6)
platform target config section 535c6c8 39a5c4a change % change
cyw30739 light cyw930739m2evb_01 .data 660 652 -8 -1.2
lock cyw930739m2evb_01 .data 624 616 -8 -1.3
ota-requestor cyw930739m2evb_01 .data 592 584 -8 -1.4
efr32 lighting-app BRD4161A .data 2080 2072 -8 -0.4
BRD4161A+rpc .data 2260 2252 -8 -0.4
window-app BRD4161A .data 1924 1916 -8 -0.4
esp32 all-clusters-app c3devkit .dram0.data 14236 14220 -16 -0.1
m5stack .dram0.data 34080 34064 -16 -0.0
k32w light k32w061+release .data 1964 1956 -8 -0.4
lock k32w061+release .data 1972 1964 -8 -0.4
linux all-clusters-app debug .data 1392 1360 -32 -2.3
bridge-app debug+rpc .data 2048 2016 -32 -1.6
chip-tool debug .rodata 510868 510804 -64 -0.0
lighting-app debug+rpc .data 1568 1536 -32 -2.0
ota-provider-app debug .data 1352 1320 -32 -2.4
ota-requestor-app debug .data 1512 1480 -32 -2.1
thermostat-no-ble arm64 .data 1080 1048 -32 -3.0
tv-app debug .data 3200 3168 -32 -1.0
.rodata 199453 199261 -192 -0.1
p6 all-clusters-app default .data 2696 2680 -16 -0.6
light-app default .data 2544 2536 -8 -0.3
lock-app default .data 2504 2496 -8 -0.3
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 535c6c8 39a5c4a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601818 602090 272 0.0
.app_xip_area 506360 506608 248 0.0
.bss 78140 78172 32 0.0
.data 660 652 -8 -1.2
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559726 559998 272 0.0
.app_xip_area 465804 466052 248 0.1
.bss 76644 76676 32 0.0
.data 624 616 -8 -1.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581918 582190 272 0.0
.app_xip_area 478316 478564 248 0.1
.bss 85972 86004 32 0.0
.data 592 584 -8 -1.4
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 921344 476 0.1
(read/write) 128848 128872 24 0.0
.bss 126768 126800 32 0.0
.data 2080 2072 -8 -0.4
.text 920860 921336 476 0.1
BRD4161A+rpc (read only) 949688 950180 492 0.1
(read/write) 144808 144828 20 0.0
.bss 142544 142576 32 0.0
.data 2260 2252 -8 -0.4
.text 949680 950172 492 0.1
window-app BRD4161A (read only) 853888 854380 492 0.1
(read/write) 126840 126852 12 0.0
.bss 124912 124936 24 0.0
.data 1924 1916 -8 -0.4
.text 853880 854372 492 0.1
esp32 all-clusters-app c3devkit (read only) 957506 957942 436 0.0
(read/write) 1393618 1393674 56 0.0
.dram0.bss 63432 63480 48 0.1
.dram0.data 14236 14220 -16 -0.1
.flash.rodata 197032 197056 24 0.0
.flash.text 957506 957942 436 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012267 1012743 476 0.0
(read/write) 460724 460772 48 0.0
.dram0.bss 68960 69000 40 0.1
.dram0.data 34080 34064 -16 -0.0
.flash.rodata 225848 225872 24 0.0
.flash.text 1006883 1007359 476 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694852 695256 404 0.1
.bss 77704 77736 32 0.0
.data 1964 1956 -8 -0.4
.text 609384 609764 380 0.1
lock k32w061+release (read/write) 696456 696860 404 0.1
.bss 77672 77704 32 0.0
.data 1972 1964 -8 -0.4
.text 611012 611392 380 0.1
linux all-clusters-app debug (read only) 2427097 2428721 1624 0.1
(read/write) 145584 145712 128 0.1
.bss 60096 60192 96 0.2
.data 1392 1360 -32 -2.3
.data.rel.ro 78360 78424 64 0.1
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205541 205541 0 0.0
.text 2058642 2060194 1552 0.1
bridge-app debug+rpc (read only) 1731837 1733421 1584 0.1
(read/write) 92560 92656 96 0.1
.bss 47432 47496 64 0.1
.data 2048 2016 -32 -1.6
.data.rel.ro 38008 38064 56 0.1
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1474213 1475701 1488 0.1
chip-tool debug (read only) 9758533 9768869 10336 0.1
(read/write) 338488 339864 1376 0.4
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305816 307176 1360 0.4
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510804 -64 -0.0
.text 8508373 8515701 7328 0.1
chip-tool-ipv6only arm64 (read only) 9430548 9440868 10320 0.1
(read/write) 454177 455633 1456 0.3
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 352384 1384 0.4
.dynamic 560 560 0 0.0
.got 54360 54424 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486620 64 0.0
.text 7940244 7947172 6928 0.1
door-lock-app debug (read only) 1946161 1947745 1584 0.1
(read/write) 119008 119136 128 0.1
.bss 50432 50496 64 0.1
.data 1056 1056 0 0.0
.data.rel.ro 62136 62184 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1623954 1625442 1488 0.1
lighting-app debug+rpc (read only) 2078441 2080025 1584 0.1
(read/write) 124360 124456 96 0.1
.bss 51232 51296 64 0.1
.data 1568 1536 -32 -2.0
.data.rel.ro 66040 66104 64 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165820 165820 0 0.0
.text 1757058 1758546 1488 0.1
ota-provider-app debug (read only) 1879017 1880601 1584 0.1
(read/write) 114640 114736 96 0.1
.bss 50240 50304 64 0.1
.data 1352 1320 -32 -2.4
.data.rel.ro 57416 57464 48 0.1
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1569490 1570978 1488 0.1
ota-requestor-app debug (read only) 1901033 1902617 1584 0.1
(read/write) 117352 117448 96 0.1
.bss 51296 51360 64 0.1
.data 1512 1480 -32 -2.1
.data.rel.ro 59112 59176 64 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154220 154220 0 0.0
.text 1596850 1598338 1488 0.1
shell debug (read only) 2393209 2394833 1624 0.1
(read/write) 149768 149928 160 0.1
.bss 70216 70312 96 0.1
.data 864 864 0 0.0
.data.rel.ro 73008 73064 56 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205458 205458 0 0.0
.text 2031250 2032802 1552 0.1
thermostat-no-ble arm64 (read only) 2174612 2176500 1888 0.1
(read/write) 148465 148673 208 0.1
.bss 65201 65281 80 0.1
.data 1080 1048 -32 -3.0
.data.rel.ro 75000 75136 136 0.2
.dynamic 560 560 0 0.0
.got 4216 4240 24 0.6
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1824912 1600 0.1
tv-app debug (read only) 2617097 2620105 3008 0.1
(read/write) 250648 250840 192 0.1
.bss 167904 168000 96 0.1
.data 3200 3168 -32 -1.0
.data.rel.ro 73504 73624 120 0.2
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199261 -192 -0.1
.text 2243746 2246754 3008 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1152335 508 0.0
bss 146792 146832 40 0.0
rodata 144300 144328 28 0.0
text 785544 785912 368 0.0
p6 all-clusters-app default (read/write) 2494056 2494568 512 0.0
.bss 119504 119544 40 0.0
.data 2696 2680 -16 -0.6
.text 1452320 1452832 512 0.0
light-app default (read/write) 2397512 2398000 488 0.0
.bss 112976 113008 32 0.0
.data 2544 2536 -8 -0.3
.text 1355776 1356264 488 0.0
lock-app default (read/write) 2360944 2361432 488 0.0
.bss 112720 112752 32 0.0
.data 2504 2496 -8 -0.3
.text 1319208 1319696 488 0.0
telink lighting-app tlsr9518adk80d (read/write) 888986 889534 548 0.1
bss 86928 86968 40 0.0
noinit 37160 37160 0 0.0
text 628350 628840 490 0.1

@cecille cecille merged commit 3382a5f into project-chip:master Mar 9, 2022
@cecille cecille deleted the setupcodepairer_networking branch March 9, 2022 21:07
@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cecille @sagar-apple @msandstedt @woody-apple @andy31415 @bzbarsky-apple