-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark commands that require a timed interaction. #14421
Mark commands that require a timed interaction. #14421
Conversation
PR #14421: Size comparison from 54b5b69 to 82eb262 Increases (12 builds for cyw30739, efr32, k32w, p6, qpg, telink)
Full report (14 builds for cyw30739, efr32, k32w, p6, qpg, telink)
|
82eb262
to
1277faf
Compare
PR #14421: Size comparison from 2c4de1b to 1277faf Increases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
1277faf
to
4742681
Compare
PR #14421: Size comparison from 61dc703 to 4742681 Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
4742681
to
f76b2fb
Compare
PR #14421: Size comparison from 92f8343 to f76b2fb Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (23 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
f76b2fb
to
c8853a2
Compare
PR #14421: Size comparison from 9fc0d2e to c8853a2 Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
c8853a2
to
d4b78c1
Compare
PR #14421: Size comparison from c14afc5 to d4b78c1 Increases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
d4b78c1
to
1b223bf
Compare
PR #14421: Size comparison from e2faf8f to 1b223bf Increases (16 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
|
1b223bf
to
cbefae0
Compare
PR #14421: Size comparison from eb628d3 to cbefae0 Increases (25 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Full report (31 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
cbefae0
to
4a664ec
Compare
PR #14421: Size comparison from ecf9ccd to 4a664ec Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Our XML was not matching the spec in terms of which commands require timed interactions.
4a664ec
to
f781291
Compare
PR #14421: Size comparison from 019ff59 to f781291 Increases (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Our XML was not matching the spec in terms of which commands require
timed interactions.
Problem
XML not matching spec.
Change overview
Make it match the spec.
Testing
Looked at the generated code.
We'll need to add some per-cluster YAML testing too, but not sure what the state of these clusters is right now.