Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ICAC to nullable to align with spec #14411

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Set ICAC to nullable to align with spec #14411

merged 2 commits into from
Jan 27, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

Set ICAC to nullable to align with spec

Testing

How was this tested? (at least one bullet point required)

  • yufengw@yufengw-SEi:~/connectedhomeip/out/debug/standalone$ ./chip-tool operationalcredentials read nocs 12344321 0
    ....
    [1643298865.210951][573608:573613] CHIP:DMG: ReportDataMessage =
    [1643298865.210956][573608:573613] CHIP:DMG: {
    [1643298865.210961][573608:573613] CHIP:DMG: AttributeReportIBs =
    [1643298865.210969][573608:573613] CHIP:DMG: [
    [1643298865.210975][573608:573613] CHIP:DMG: AttributeReportIB =
    [1643298865.210983][573608:573613] CHIP:DMG: {
    [1643298865.210989][573608:573613] CHIP:DMG: AttributeDataIB =
    [1643298865.210996][573608:573613] CHIP:DMG: {
    [1643298865.211003][573608:573613] CHIP:DMG: DataVersion = 0x0,
    [1643298865.211011][573608:573613] CHIP:DMG: AttributePathIB =
    [1643298865.211019][573608:573613] CHIP:DMG: {
    [1643298865.211027][573608:573613] CHIP:DMG: Endpoint = 0x0,
    [1643298865.211035][573608:573613] CHIP:DMG: Cluster = 0x3e,
    [1643298865.211043][573608:573613] CHIP:DMG: Attribute = 0x0000_0000,
    [1643298865.211050][573608:573613] CHIP:DMG: }
    [1643298865.211058][573608:573613] CHIP:DMG:
    [1643298865.211065][573608:573613] CHIP:DMG: Data = [
    [1643298865.211072][573608:573613] CHIP:DMG:
    [1643298865.211079][573608:573613] CHIP:DMG: ],
    [1643298865.211085][573608:573613] CHIP:DMG: },
    [1643298865.211093][573608:573613] CHIP:DMG:
    [1643298865.211098][573608:573613] CHIP:DMG: },
    [1643298865.211110][573608:573613] CHIP:DMG:
    [1643298865.211128][573608:573613] CHIP:DMG: AttributeReportIB =
    [1643298865.211176][573608:573613] CHIP:DMG: {
    [1643298865.211181][573608:573613] CHIP:DMG: AttributeDataIB =
    [1643298865.211187][573608:573613] CHIP:DMG: {
    [1643298865.211193][573608:573613] CHIP:DMG: DataVersion = 0x0,
    [1643298865.211198][573608:573613] CHIP:DMG: AttributePathIB =
    [1643298865.211205][573608:573613] CHIP:DMG: {
    [1643298865.211211][573608:573613] CHIP:DMG: Endpoint = 0x0,
    [1643298865.211218][573608:573613] CHIP:DMG: Cluster = 0x3e,
    [1643298865.211226][573608:573613] CHIP:DMG: Attribute = 0x0000_0000,
    [1643298865.211234][573608:573613] CHIP:DMG: ListIndex = Null,
    [1643298865.211242][573608:573613] CHIP:DMG: }
    [1643298865.211250][573608:573613] CHIP:DMG:
    [1643298865.211257][573608:573613] CHIP:DMG: Data =
    [1643298865.211265][573608:573613] CHIP:DMG: {
    [1643298865.211272][573608:573613] CHIP:DMG: 0x0 = 1,
    [1643298865.211281][573608:573613] CHIP:DMG: 0x1 = [
    [1643298865.211298][573608:573613] CHIP:DMG: 0x15, 0x30, 0x1, 0x1, 0x1, 0x24, 0x2, 0x1, 0x37, 0x3, 0x24, 0x13, 0x1, 0x18, 0x26, 0x4, 0x80, 0x22, 0x81, 0x27, 0x26, 0x5, 0x80, 0x25, 0x4d, 0x3a, 0x37, 0x6, 0x24, 0x15, 0x1, 0x26, 0x11, 0x1, 0x5c, 0xbc, 0x0, 0x18, 0x24, 0x7, 0x1, 0x24, 0x8, 0x1, 0
    [1643298865.211308][573608:573613] CHIP:DMG: ]
    [1643298865.211316][573608:573613] CHIP:DMG: 0x2 = [
    [1643298865.211333][573608:573613] CHIP:DMG: 0x15, 0x30, 0x1, 0x1, 0x0, 0x24, 0x2, 0x1, 0x37, 0x3, 0x24, 0x14, 0x0, 0x18, 0x26, 0x4, 0x80, 0x22, 0x81, 0x27, 0x26, 0x5, 0x80, 0x25, 0x4d, 0x3a, 0x37, 0x6, 0x24, 0x13, 0x1, 0x18, 0x24, 0x7, 0x1, 0x24, 0x8, 0x1, 0x30, 0x9, 0x41, 0x4, 0x60, 0xaa, 0
    [1643298865.211342][573608:573613] CHIP:DMG: ]
    [1643298865.211350][573608:573613] CHIP:DMG: },
    [1643298865.211357][573608:573613] CHIP:DMG: },
    [1643298865.211367][573608:573613] CHIP:DMG:
    [1643298865.211372][573608:573613] CHIP:DMG: },
    [1643298865.211381][573608:573613] CHIP:DMG:
    [1643298865.211386][573608:573613] CHIP:DMG: ],
    [1643298865.211399][573608:573613] CHIP:DMG:
    [1643298865.211404][573608:573613] CHIP:DMG: SuppressResponse = true,
    [1643298865.211409][573608:573613] CHIP:DMG: }
    [1643298865.211503][573608:573613] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_003E Attribute 0x0000_0000
    [1643298865.211525][573608:573613] CHIP:TOO: NOCs: 1 entries
    [1643298865.211549][573608:573613] CHIP:TOO: [1]: {
    [1643298865.211555][573608:573613] CHIP:TOO: FabricIndex: 1
    [1643298865.211563][573608:573613] CHIP:TOO: Noc: Elided value too large of size 244
    [1643298865.211570][573608:573613] CHIP:TOO: Icac: Elided value too large of size 231
    [1643298865.211576][573608:573613] CHIP:TOO: }

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14411: Size comparison from 63d0c37 to 40e19ce

Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 63d0c37 40e19ce change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580918 580962 44 0.0
.app_xip_area 485716 485760 44 0.0
lock-app CYW30739 (read/write) 538922 538966 44 0.0
.app_xip_area 445264 445308 44 0.0
efr32 lighting-app BRD4161A (read only) 844508 844572 64 0.0
.text 844500 844564 64 0.0
BRD4161A+rpc (read only) 831880 831928 48 0.0
.text 831872 831920 48 0.0
window-app BRD4161A (read only) 817124 817172 48 0.0
.text 817116 817164 48 0.0
esp32 all-clusters-app c3devkit (read only) 934132 934168 36 0.0
.flash.text 934132 934168 36 0.0
m5stack (read only) 981551 981575 24 0.0
.flash.text 976167 976191 24 0.0
k32w light k32w061+release (read/write) 665716 665748 32 0.0
.text 580324 580356 32 0.0
lock k32w061+release (read/write) 666668 666716 48 0.0
.text 580988 581036 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6744396 6744476 80 0.0
.text 5785492 5785572 80 0.0
thermostat-no-ble arm64 (read only) 2084468 2085060 592 0.0
.text 1735136 1735728 592 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2383920 2383984 64 0.0
.text 1346520 1346584 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2308240 2308304 64 0.0
.text 1270840 1270904 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2294436 2294500 64 0.0
.text 1257008 1257072 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984183 984215 32 0.0
text 668944 668984 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 968047 968079 32 0.0
text 663616 663656 40 0.0
nrf52840dongle_nrf52840 (read/write) 1000303 1000351 48 0.0
text 674372 674412 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 893406 893438 32 0.0
text 585124 585164 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916799 916847 48 0.0
text 614928 614968 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826834 826866 32 0.0
text 531880 531920 40 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919663 919711 48 0.0
text 617464 617504 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914847 914879 32 0.0
text 613500 613540 40 0.0
p6 all-clusters-app default (read/write) 2443448 2443496 48 0.0
.text 1401712 1401760 48 0.0
light-app default (read/write) 2340096 2340144 48 0.0
.text 1298360 1298408 48 0.0
lock-app default (read/write) 2305600 2305664 64 0.0
.text 1263864 1263928 64 0.0
qpg lighting-app qpg6105+debug (read only) 572424 572456 32 0.0
.text 567104 567136 32 0.0
lock-app qpg6105+debug (read only) 518552 518584 32 0.0
.text 513232 513264 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 848690 848722 32 0.0
text 593356 593382 26 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 63d0c37 40e19ce change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580918 580962 44 0.0
.app_xip_area 485716 485760 44 0.0
.bss 77948 77948 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 538922 538966 44 0.0
.app_xip_area 445264 445308 44 0.0
.bss 76444 76444 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 844508 844572 64 0.0
(read/write) 127492 127492 0 0.0
.bss 125592 125592 0 0.0
.data 1900 1900 0 0.0
.text 844500 844564 64 0.0
BRD4161A+rpc (read only) 831880 831928 48 0.0
(read/write) 144152 144152 0 0.0
.bss 142152 142152 0 0.0
.data 2000 2000 0 0.0
.text 831872 831920 48 0.0
window-app BRD4161A (read only) 817124 817172 48 0.0
(read/write) 126148 126148 0 0.0
.bss 124292 124292 0 0.0
.data 1856 1856 0 0.0
.text 817116 817164 48 0.0
esp32 all-clusters-app c3devkit (read only) 934132 934168 36 0.0
(read/write) 1398698 1398698 0 0.0
.dram0.bss 70984 70984 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 194552 194552 0 0.0
.flash.text 934132 934168 36 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981551 981575 24 0.0
(read/write) 465528 465528 0 0.0
.dram0.bss 75728 75728 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 223648 223648 0 0.0
.flash.text 976167 976191 24 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665716 665748 32 0.0
.bss 77724 77724 0 0.0
.data 1868 1868 0 0.0
.text 580324 580356 32 0.0
lock k32w061+release (read/write) 666668 666716 48 0.0
.bss 77988 77988 0 0.0
.data 1892 1892 0 0.0
.text 580988 581036 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6744396 6744476 80 0.0
(read/write) 279025 279025 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175864 175864 0 0.0
.dynamic 560 560 0 0.0
.got 42744 42744 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 387684 387684 0 0.0
.text 5785492 5785572 80 0.0
thermostat-no-ble arm64 (read only) 2084468 2085060 592 0.0
(read/write) 152097 152097 0 0.0
.bss 69761 69761 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74256 74256 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1735136 1735728 592 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2383920 2383984 64 0.0
.bss 189692 189692 0 0.0
.data 5288 5288 0 0.0
.text 1346520 1346584 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341488 2341488 0 0.0
.bss 181200 181200 0 0.0
.data 5584 5584 0 0.0
.text 1304088 1304088 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308240 2308304 64 0.0
.bss 181096 181096 0 0.0
.data 5568 5568 0 0.0
.text 1270840 1270904 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294436 2294500 64 0.0
.bss 177828 177828 0 0.0
.data 5384 5384 0 0.0
.text 1257008 1257072 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 984183 984215 32 0.0
bss 120956 120956 0 0.0
rodata 116492 116492 0 0.0
text 668944 668984 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 968047 968079 32 0.0
bss 118000 118000 0 0.0
rodata 108028 108028 0 0.0
text 663616 663656 40 0.0
nrf52840dongle_nrf52840 (read/write) 1000303 1000351 48 0.0
bss 122128 122128 0 0.0
rodata 115344 115344 0 0.0
text 674372 674412 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 893406 893438 32 0.0
bss 117744 117744 0 0.0
rodata 109792 109792 0 0.0
text 585124 585164 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916799 916847 48 0.0
bss 119336 119336 0 0.0
rodata 105132 105132 0 0.0
text 614928 614968 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826834 826866 32 0.0
bss 116152 116152 0 0.0
rodata 98356 98356 0 0.0
text 531880 531920 40 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919663 919711 48 0.0
bss 119088 119088 0 0.0
rodata 105644 105644 0 0.0
text 617464 617504 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914847 914879 32 0.0
bss 119112 119112 0 0.0
rodata 104748 104748 0 0.0
text 613500 613540 40 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2443448 2443496 48 0.0
.bss 118036 118036 0 0.0
.data 2584 2584 0 0.0
.text 1401712 1401760 48 0.0
light-app default (read/write) 2340096 2340144 48 0.0
.bss 105780 105780 0 0.0
.data 2408 2408 0 0.0
.text 1298360 1298408 48 0.0
lock-app default (read/write) 2305600 2305664 64 0.0
.bss 105524 105524 0 0.0
.data 2360 2360 0 0.0
.text 1263864 1263928 64 0.0
qpg lighting-app qpg6105+debug (read only) 572424 572456 32 0.0
(read/write) 146936 146936 0 0.0
.bss 89936 89936 0 0.0
.data 1060 1060 0 0.0
.text 567104 567136 32 0.0
lock-app qpg6105+debug (read only) 518552 518584 32 0.0
(read/write) 146940 146940 0 0.0
.bss 89408 89408 0 0.0
.data 992 992 0 0.0
.text 513232 513264 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848690 848722 32 0.0
bss 87736 87736 0 0.0
noinit 37160 37160 0 0.0
text 593356 593382 26 0.0

@woody-apple woody-apple merged commit a4618fe into project-chip:master Jan 27, 2022
@yufengwangca yufengwangca deleted the pr/cluster/opc branch January 27, 2022 18:37
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@yufengwangca @selissia
Set ICAC to nullable to align with spec (project-chip#14411)
0efa9d7 
* If no ICAC is present in the chain, this field SHALL be set to null

* Run codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@emargolis emargolis emargolis approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@msandstedt msandstedt Awaiting requested review from msandstedt

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICAC in operational-credentials-cluster.xml should be nullable.
6 participants
@yufengwangca @msandstedt @emargolis @yunhanw-google @bzbarsky-apple @woody-apple