Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add CLI tab-to-autocomplete ability and implement for nrfconnect" #14384

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

woody-apple
Copy link
Contributor

@github-actions
Copy link

PR #14384: Size comparison from c62489b to 4c131de

Increases above 0.2%:

platform target config section c62489b 4c131de change % change
linux thermostat-no-ble arm64 (read/write) 150977 151873 896 0.6
.bss 68689 69585 896 1.3
Increases (1 build for linux)
platform target config section c62489b 4c131de change % change
linux thermostat-no-ble arm64 (read/write) 150977 151873 896 0.6
.bss 68689 69585 896 1.3
Full report (2 builds for linux)
platform target config section c62489b 4c131de change % change
linux chip-tool-ipv6only arm64 (read only) 8935692 8935692 0 0.0
(read/write) 394801 394801 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264512 264512 0 0.0
.dynamic 560 560 0 0.0
.got 70024 70024 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 544356 0 0.0
.text 7541700 7541700 0 0.0
thermostat-no-ble arm64 (read only) 2082804 2082804 0 0.0
(read/write) 150977 151873 896 0.6
.bss 68689 69585 896 1.3
.data 960 960 0 0.0
.data.rel.ro 74208 74208 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1733616 0 0.0

@lmpprk
Copy link
Contributor

lmpprk commented Jan 27, 2022

thanks! it was a race between PRs, I can fix this quickly by pushing a change if that works better?

@woody-apple woody-apple merged commit ba45194 into master Jan 27, 2022
@woody-apple woody-apple deleted the revert-13630-shell-cmd-suggestion branch January 27, 2022 08:45
@woody-apple
Copy link
Contributor Author

woody-apple commented Jan 27, 2022

@lmpprk Sorry for the confusion, I do need to get the tree running, but if you put up a PR, with the fix needed, I can prioritize it coming in!

@woody-apple
Copy link
Contributor Author

@lmpprk I will be online for the next hour, otherwise I can pick this up tomorrow AM! (FYI)

@lmpprk
Copy link
Contributor

lmpprk commented Jan 27, 2022

thanks no worries, mine can wait :) I'll sync and send it later. Thank you for the help in resolving!

selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples hotfix urgent fix needed, can bypass review lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants