Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YAML - Darwin] Generate saveAs code not only when the 'value' keyword is used #14322

Merged
merged 2 commits into from
Jan 26, 2022
Merged

[YAML - Darwin] Generate saveAs code not only when the 'value' keyword is used #14322

merged 2 commits into from
Jan 26, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

The saveAs keyword in YAML generates objective-c code only if a value is defined.

#fixes 14237

Change overview

  • Generates saveAs code all the time...

Testing

I have locally run the command: xcodebuild test -target "CHIP" -scheme "CHIP Framework Tests" -sdk macosx

@vivien-apple vivien-apple self-assigned this Jan 26, 2022
@boring-cyborg boring-cyborg bot added the darwin label Jan 26, 2022
woody-apple
woody-apple approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given this is adding tests to a platform.

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14322: Size comparison from 750f976 to e22bd1a

Full report (29 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 750f976 e22bd1a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580050 580050 0 0.0
.app_xip_area 484972 484972 0 0.0
.bss 77824 77824 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
esp32 all-clusters-app c3devkit (read only) 921048 921048 0 0.0
(read/write) 1384650 1384650 0 0.0
.dram0.bss 70840 70840 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180632 180632 0 0.0
.flash.text 921048 921048 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970015 970015 0 0.0
(read/write) 451664 451664 0 0.0
.dram0.bss 75584 75584 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209920 209920 0 0.0
.flash.text 964631 964631 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 664844 664844 0 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579580 579580 0 0.0
lock k32w061+release (read/write) 665840 665840 0 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580288 580288 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8900396 8900396 0 0.0
(read/write) 394561 394561 0 0.0
.bss 56289 56289 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 263688 263688 0 0.0
.dynamic 560 560 0 0.0
.got 69704 69704 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542916 542916 0 0.0
.text 7510532 7510532 0 0.0
thermostat-no-ble arm64 (read only) 2059236 2059236 0 0.0
(read/write) 147473 147473 0 0.0
.bss 65857 65857 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1712048 1712048 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355000 2355000 0 0.0
.bss 189548 189548 0 0.0
.data 5296 5296 0 0.0
.text 1317600 1317600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340992 2340992 0 0.0
.bss 181072 181072 0 0.0
.data 5584 5584 0 0.0
.text 1303592 1303592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307736 2307736 0 0.0
.bss 180968 180968 0 0.0
.data 5568 5568 0 0.0
.text 1270336 1270336 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293900 2293900 0 0.0
.bss 177700 177700 0 0.0
.data 5384 5384 0 0.0
.text 1256472 1256472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983315 983315 0 0.0
bss 120828 120828 0 0.0
rodata 116408 116408 0 0.0
text 668284 668284 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967175 967175 0 0.0
bss 117872 117872 0 0.0
rodata 107940 107940 0 0.0
text 662956 662956 0 0.0
nrf52840dongle_nrf52840 (read/write) 999499 999499 0 0.0
bss 122000 122000 0 0.0
rodata 115292 115292 0 0.0
text 673744 673744 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892518 892518 0 0.0
bss 117616 117616 0 0.0
rodata 109704 109704 0 0.0
text 584464 584464 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 915991 915991 0 0.0
bss 119208 119208 0 0.0
rodata 105076 105076 0 0.0
text 614308 614308 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826030 826030 0 0.0
bss 116024 116024 0 0.0
rodata 98304 98304 0 0.0
text 531260 531260 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918667 918667 0 0.0
bss 118952 118952 0 0.0
rodata 105464 105464 0 0.0
text 616772 616772 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 913835 913835 0 0.0
bss 118980 118980 0 0.0
rodata 104568 104568 0 0.0
text 612804 612804 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533652 533652 0 0.0
p6 all-clusters-app default (read/write) 2414912 2414912 0 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1373176 1373176 0 0.0
light-app default (read/write) 2338392 2338392 0 0.0
.bss 105652 105652 0 0.0
.data 2408 2408 0 0.0
.text 1296656 1296656 0 0.0
lock-app default (read/write) 2303928 2303928 0 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1262192 1262192 0 0.0
qpg lighting-app qpg6105+debug (read only) 571684 571684 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89808 89808 0 0.0
.data 1060 1060 0 0.0
.text 566364 566364 0 0.0
lock-app qpg6105+debug (read only) 517876 517876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512556 512556 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 847910 847910 0 0.0
bss 87608 87608 0 0.0
noinit 37160 37160 0 0.0
text 592750 592750 0 0.0

@woody-apple woody-apple linked an issue Jan 26, 2022 that may be closed by this pull request
SaveAs keyword does not seem to work in Darwin #14237
Closed
@raju-apple raju-apple mentioned this pull request Jan 26, 2022
Closed
@woody-apple
Copy link
Contributor

/rebase

@vivien-apple vivien-apple force-pushed the YAML_Darwin_SaveAs_Even_when_Value_Is_Not_Defined branch from e22bd1a to a8ecdd8 Compare January 26, 2022 20:52
@vivien-apple vivien-apple changed the title Yaml darwin save as even when value is not defined @vivien-apple [YAML - Darwin] Generate saveAs code not only when the 'value' keyword is used Jan 26, 2022
@vivien-apple vivien-apple changed the title @vivien-apple [YAML - Darwin] Generate saveAs code not only when the 'value' keyword is used [YAML - Darwin] Generate saveAs code not only when the 'value' keyword is used Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14322: Size comparison from 3bd289d to a8ecdd8

Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3bd289d a8ecdd8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580330 580330 0 0.0
.app_xip_area 485224 485224 0 0.0
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843316 843316 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843308 843308 0 0.0
BRD4161A+rpc (read only) 830672 830672 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830664 830664 0 0.0
window-app BRD4161A (read only) 815948 815948 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 815940 815940 0 0.0
esp32 all-clusters-app c3devkit (read only) 921116 921116 0 0.0
(read/write) 1384722 1384722 0 0.0
.dram0.bss 70872 70872 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180672 180672 0 0.0
.flash.text 921116 921116 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 970111 970111 0 0.0
(read/write) 451744 451744 0 0.0
.dram0.bss 75616 75616 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209968 209968 0 0.0
.flash.text 964727 964727 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665192 665192 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579896 579896 0 0.0
lock k32w061+release (read/write) 666080 666080 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580496 580496 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8904716 8904716 0 0.0
(read/write) 393649 393649 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 263656 263656 0 0.0
.dynamic 560 560 0 0.0
.got 69728 69728 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542916 542916 0 0.0
.text 7514868 7514868 0 0.0
thermostat-no-ble arm64 (read only) 2061828 2061828 0 0.0
(read/write) 148113 148113 0 0.0
.bss 66417 66417 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73712 73712 0 0.0
.dynamic 560 560 0 0.0
.got 4128 4128 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131428 131428 0 0.0
.text 1714416 1714416 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355056 2355056 0 0.0
.bss 189580 189580 0 0.0
.data 5296 5296 0 0.0
.text 1317656 1317656 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341048 2341048 0 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303648 1303648 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307792 2307792 0 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270392 1270392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294060 2294060 0 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256632 1256632 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983643 983643 0 0.0
bss 120860 120860 0 0.0
rodata 116480 116480 0 0.0
text 668512 668512 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967507 967507 0 0.0
bss 117904 117904 0 0.0
rodata 108016 108016 0 0.0
text 663184 663184 0 0.0
nrf52840dongle_nrf52840 (read/write) 999731 999731 0 0.0
bss 122032 122032 0 0.0
rodata 115332 115332 0 0.0
text 673900 673900 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892866 892866 0 0.0
bss 117648 117648 0 0.0
rodata 109780 109780 0 0.0
text 584692 584692 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916227 916227 0 0.0
bss 119240 119240 0 0.0
rodata 105120 105120 0 0.0
text 614460 614460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826246 826246 0 0.0
bss 116056 116056 0 0.0
rodata 98344 98344 0 0.0
text 531412 531412 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918883 918883 0 0.0
bss 118984 118984 0 0.0
rodata 105504 105504 0 0.0
text 616924 616924 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914067 914067 0 0.0
bss 119012 119012 0 0.0
rodata 104608 104608 0 0.0
text 612956 612956 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533652 533652 0 0.0
p6 all-clusters-app default (read/write) 2415424 2415424 0 0.0
.bss 117924 117924 0 0.0
.data 2584 2584 0 0.0
.text 1373688 1373688 0 0.0
light-app default (read/write) 2338904 2338904 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297168 1297168 0 0.0
lock-app default (read/write) 2304440 2304440 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262704 1262704 0 0.0
qpg lighting-app qpg6105+debug (read only) 571964 571964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566644 566644 0 0.0
lock-app qpg6105+debug (read only) 518060 518060 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512740 512740 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 848046 0 0.0
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592818 592818 0 0.0

@vivien-apple vivien-apple merged commit d123146 into project-chip:master Jan 26, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@vivien-apple @selissia
[YAML - Darwin] Generate saveAs code not only when the 'value' keywor…
f50152f 
…d is used (project-chip#14322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SaveAs keyword does not seem to work in Darwin
2 participants
@vivien-apple @woody-apple