Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch lighting-app back to the "more likely" output. #14302

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

ZAP CI keeps failing.

Change overview

Make it less likely to fail.

Testing

Regenerated lighting-app multiple times, and this was the one that came up the most.

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 26, 2022

PR #14302: Size comparison from 246473c to 145b0fe

Increases above 0.2%:

platform target config section 246473c 145b0fe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 579910 1448 0.3
.app_xip_area 483384 484832 1448 0.3
efr32 lighting-app BRD4161A (read only) 840836 842596 1760 0.2
.text 840828 842588 1760 0.2
BRD4161A+rpc (read only) 828208 829952 1744 0.2
.text 828200 829944 1744 0.2
qpg lighting-app qpg6105+debug (read only) 570044 571484 1440 0.3
.text 564724 566164 1440 0.3
Increases (6 builds for cyw30739, efr32, p6, qpg, telink)
platform target config section 246473c 145b0fe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 579910 1448 0.3
.app_xip_area 483384 484832 1448 0.3
efr32 lighting-app BRD4161A (read only) 840836 842596 1760 0.2
.text 840828 842588 1760 0.2
BRD4161A+rpc (read only) 828208 829952 1744 0.2
.text 828200 829944 1744 0.2
p6 light-app default (read/write) 2336424 2338168 1744 0.1
.bss 105644 105652 8 0.0
.text 1294688 1296432 1744 0.1
qpg lighting-app qpg6105+debug (read only) 570044 571484 1440 0.3
.bss 89800 89808 8 0.0
.text 564724 566164 1440 0.3
telink lighting-app tlsr9518adk80d (read/write) 846030 847718 1688 0.2
text 591096 592560 1464 0.2
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 246473c 145b0fe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 579910 1448 0.3
.app_xip_area 483384 484832 1448 0.3
.bss 77824 77824 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 840836 842596 1760 0.2
(read/write) 127364 127364 0 0.0
.bss 125464 125464 0 0.0
.data 1900 1900 0 0.0
.text 840828 842588 1760 0.2
BRD4161A+rpc (read only) 828208 829952 1744 0.2
(read/write) 144024 144024 0 0.0
.bss 142024 142024 0 0.0
.data 2000 2000 0 0.0
.text 828200 829944 1744 0.2
window-app BRD4161A (read only) 815228 815228 0 0.0
(read/write) 126020 126020 0 0.0
.bss 124164 124164 0 0.0
.data 1856 1856 0 0.0
.text 815220 815220 0 0.0
k32w light k32w061+release (read/write) 664644 664644 0 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579380 579380 0 0.0
lock k32w061+release (read/write) 665696 665696 0 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580144 580144 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8728948 8728948 0 0.0
(read/write) 392273 392273 0 0.0
.bss 56241 56241 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261872 261872 0 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534444 534444 0 0.0
.text 7352756 7352756 0 0.0
thermostat-no-ble arm64 (read only) 2058404 2058404 0 0.0
(read/write) 147457 147457 0 0.0
.bss 65857 65857 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1711248 1711248 0 0.0
p6 all-clusters-app default (read/write) 2414704 2414704 0 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1372968 1372968 0 0.0
light-app default (read/write) 2336424 2338168 1744 0.1
.bss 105644 105652 8 0.0
.data 2408 2408 0 0.0
.text 1294688 1296432 1744 0.1
lock-app default (read/write) 2303720 2303720 0 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1261984 1261984 0 0.0
qpg lighting-app qpg6105+debug (read only) 570044 571484 1440 0.3
(read/write) 146936 146936 0 0.0
.bss 89800 89808 8 0.0
.data 1060 1060 0 0.0
.text 564724 566164 1440 0.3
lock-app qpg6105+debug (read only) 517724 517724 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512404 512404 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846030 847718 1688 0.2
bss 87608 87608 0 0.0
noinit 37160 37160 0 0.0
text 591096 592560 1464 0.2

@woody-apple woody-apple merged commit 02631e5 into project-chip:master Jan 26, 2022
@bzbarsky-apple bzbarsky-apple deleted the lighting-app-zap branch January 26, 2022 08:16
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants