Remedy race condition in advertising switch

[jimlyall-q]

Problem

• Device fails to switch to slow advertising after 30s

Change overview

Race condition removed by code reorder

Testing

• Internal advertising tests
• Manual pairing after 30s with chip-tool

[github-actions]

PR #14241: Size comparison from ced87f4 to 5b2c137

Decreases (2 builds for qpg)

platform	target	config	section	ced87f4	5b2c137	change	% change
qpg	lighting-app	qpg6105+debug	(read only)	567364	567356	-8	-0.0
			.text	562044	562036	-8	-0.0
	lock-app	qpg6105+debug	(read only)	516024	516008	-16	-0.0
			.text	510704	510688	-16	-0.0

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	ced87f4	5b2c137	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	573714	573714	0	0.0
			.app_xip_area	479016	479016	0	0.0
			.bss	77444	77444	0	0.0
			.data	596	596	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
efr32	lighting-app	BRD4161A	(read only)	835484	835484	0	0.0
			(read/write)	126980	126980	0	0.0
			.bss	125080	125080	0	0.0
			.data	1900	1900	0	0.0
			.text	835476	835476	0	0.0
		BRD4161A+rpc	(read only)	822864	822864	0	0.0
			(read/write)	143640	143640	0	0.0
			.bss	141640	141640	0	0.0
			.data	2000	2000	0	0.0
			.text	822856	822856	0	0.0
	window-app	BRD4161A	(read only)	806324	806324	0	0.0
			(read/write)	125624	125624	0	0.0
			.bss	123768	123768	0	0.0
			.data	1856	1856	0	0.0
			.text	806316	806316	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	919376	919376	0	0.0
			(read/write)	1376938	1376938	0	0.0
			.dram0.bss	67376	67376	0	0.0
			.dram0.data	14244	14244	0	0.0
			.flash.rodata	176192	176192	0	0.0
			.flash.text	919376	919376	0	0.0
			.iram0.text	62056	62056	0	0.0
		m5stack	(read only)	968011	968011	0	0.0
			(read/write)	443800	443800	0	0.0
			.dram0.bss	72128	72128	0	0.0
			.dram0.data	34032	34032	0	0.0
			.flash.rodata	205512	205512	0	0.0
			.flash.text	962627	962627	0	0.0
			.iram0.text	123399	123399	0	0.0
k32w	light	k32w061+release	(read/write)	661144	661144	0	0.0
			.bss	77224	77224	0	0.0
			.data	1868	1868	0	0.0
			.text	576252	576252	0	0.0
	lock	k32w061+release	(read/write)	662076	662076	0	0.0
			.bss	77488	77488	0	0.0
			.data	1892	1892	0	0.0
			.text	576896	576896	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	8639540	8639540	0	0.0
			(read/write)	390961	390961	0	0.0
			.bss	56049	56049	0	0.0
			.data	1128	1128	0	0.0
			.data.rel.ro	260976	260976	0	0.0
			.dynamic	560	560	0	0.0
			.got	69056	69056	0	0.0
			.init	24	24	0	0.0
			.init_array	200	200	0	0.0
			.rodata	532716	532716	0	0.0
			.text	7267860	7267860	0	0.0
	thermostat-no-ble	arm64	(read only)	2050492	2050492	0	0.0
			(read/write)	145969	145969	0	0.0
			.bss	64897	64897	0	0.0
			.data	904	904	0	0.0
			.data.rel.ro	73160	73160	0	0.0
			.dynamic	560	560	0	0.0
			.got	4056	4056	0	0.0
			.init	24	24	0	0.0
			.init_array	320	320	0	0.0
			.rodata	129948	129948	0	0.0
			.text	1706144	1706144	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2349032	2349032	0	0.0
			.bss	186084	186084	0	0.0
			.data	5296	5296	0	0.0
			.text	1311608	1311608	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2334296	2334296	0	0.0
			.bss	180688	180688	0	0.0
			.data	5576	5576	0	0.0
			.text	1296896	1296896	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2304816	2304816	0	0.0
			.bss	180592	180592	0	0.0
			.data	5568	5568	0	0.0
			.text	1267416	1267416	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139712	1139712	0	0.0
			.bss	11756	11756	0	0.0
			.data	4368	4368	0	0.0
			.text	103096	103096	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2053896	2053896	0	0.0
			.bss	156876	156876	0	0.0
			.data	4864	4864	0	0.0
			.text	1016496	1016496	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	942439	942439	0	0.0
			bss	118776	118776	0	0.0
			rodata	108828	108828	0	0.0
			text	637252	637252	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	927955	927955	0	0.0
			bss	115820	115820	0	0.0
			rodata	101280	101280	0	0.0
			text	632648	632648	0	0.0
		nrf52840dongle_nrf52840	(read/write)	993115	993115	0	0.0
			bss	121616	121616	0	0.0
			rodata	113580	113580	0	0.0
			text	669452	669452	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	852298	852298	0	0.0
			bss	115564	115564	0	0.0
			rodata	102004	102004	0	0.0
			text	554172	554172	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	912943	912943	0	0.0
			bss	118828	118828	0	0.0
			rodata	103884	103884	0	0.0
			text	612828	612828	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	822982	822982	0	0.0
			bss	115648	115648	0	0.0
			rodata	97112	97112	0	0.0
			text	529784	529784	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	541835	541835	0	0.0
			bss	52588	52588	0	0.0
			rodata	50104	50104	0	0.0
			text	376940	376940	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	915619	915619	0	0.0
			bss	118576	118576	0	0.0
			rodata	104272	104272	0	0.0
			text	615296	615296	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	910787	910787	0	0.0
			bss	118600	118600	0	0.0
			rodata	103376	103376	0	0.0
			text	611324	611324	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	798203	798203	0	0.0
			bss	109776	109776	0	0.0
			rodata	78288	78288	0	0.0
			text	533644	533644	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	711022	711022	0	0.0
			bss	107664	107664	0	0.0
			rodata	72592	72592	0	0.0
			text	451320	451320	0	0.0
p6	all-clusters-app	default	(read/write)	2407784	2407784	0	0.0
			.bss	114428	114428	0	0.0
			.data	2584	2584	0	0.0
			.text	1366048	1366048	0	0.0
	light-app	default	(read/write)	2330608	2330608	0	0.0
			.bss	105272	105272	0	0.0
			.data	2408	2408	0	0.0
			.text	1288872	1288872	0	0.0
	lock-app	default	(read/write)	2300016	2300016	0	0.0
			.bss	105024	105024	0	0.0
			.data	2360	2360	0	0.0
			.text	1258280	1258280	0	0.0
qpg	lighting-app	qpg6105+debug	(read only)	567364	567356	-8	-0.0
			(read/write)	146936	146936	0	0.0
			.bss	89416	89416	0	0.0
			.data	1060	1060	0	0.0
			.text	562044	562036	-8	-0.0
	lock-app	qpg6105+debug	(read only)	516024	516008	-16	-0.0
			(read/write)	146940	146940	0	0.0
			.bss	88896	88896	0	0.0
			.data	992	992	0	0.0
			.text	510704	510688	-16	-0.0
	persistent-storage-app	qpg6105+debug	(read only)	107140	107140	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	38504	38504	0	0.0
			.data	288	288	0	0.0
			.text	101820	101820	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	841362	841362	0	0.0
			bss	87224	87224	0	0.0
			noinit	37160	37160	0	0.0
			text	588360	588360	0	0.0

[andy31415]

Fast track: trivial change.