-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android CHIP demo app #1412
Android CHIP demo app #1412
Conversation
Are the following files build artifacts being accidentally checked in?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the following files build artifacts being accidentally checked in?
src/android/CHIPTool/app/src/main/jniLibs/arm64-v8a/libcrypto.so src/android/CHIPTool/app/src/main/jniLibs/arm64-v8a/libSetupPayloadParser.so src/android/CHIPTool/app/src/main/jniLibs/x86/libSetupPayloadParser.so src/android/CHIPTool/app/src/main/jniLibs/x86/libcrypto.so
Maybe we could use some $NDK_PATH in our build scripts for the crypto bit. For the PayloadParser, it sounds as if our build should create that file and we should not need to check it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as changes requested: I believe we should not checkin .so files and we should instead require user paths if we cannot autodetect (e.g. chip build output directory or NDK path).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but agreed we do not want to check in the .so binaries.
Same goes for .jar files. Any artifacts of the build should not be checked in. |
@vidhis88 @randyrossi any update here? |
8903cc2
to
703aa72
Compare
Updated the PR to remove the .so and .jar files. Since we don't yet have a build job for the Android app, I wanted to allow anyone checking out the Android demo app to be able to run it without having to manually build the .so and .jar files by including them. |
Scan CHIP QR code and display the SetupPayload info.
Scan CHIP QR code and display the SetupPayload info.
Video: https://drive.google.com/file/d/1BqqjPsQItrdNCNtfjfR5W4zMKUVkiTpy/view