Make sure we don't advertise with CM=1 when we're not accepting PASE connections. #13813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
requested review from
tcarmelveilleux,
andy31415,
cecille,
sagar-apple,
pan-apple and
chrisdecenzo
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
saurabhst and
selissia
|
PR #13813: Size comparison from 5394388 to 4458632 Increases (17 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
Full report (20 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
truth-in-advertising
branch
2 times, most recently
from
3726c19 to
6db8f34
Compare
|
PR #13813: Size comparison from 5394388 to 6db8f34 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 21, 2022
tcarmelveilleux
approved these changes
Jan 21, 2022
bzbarsky-apple
force-pushed
the
truth-in-advertising
branch
from
6db8f34 to
6ac6005
Compare
chrisdecenzo
approved these changes
Jan 21, 2022
cecille
approved these changes
Jan 21, 2022
|
PR #13813: Size comparison from b519c8e to 3a9f386 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
truth-in-advertising
branch
from
3a9f386 to
f9c7281
Compare
bzbarsky-apple
force-pushed
the
truth-in-advertising
branch
from
f9c7281 to
9e1f019
Compare
|
PR #13813: Size comparison from b1d40eb to 9e1f019 Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
truth-in-advertising
branch
from
9e1f019 to
971a76c
Compare
|
PR #13813: Size comparison from 7cb2640 to 971a76c Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…connections. Right now it's possible for a device to both be advertising over dns-sd with CM=1 and not be accepting PASE connections. Which makes the CM=1 not exactly true. Summary of changes: 1. Change DnssdServer to clearly differentiate between "Start with default commissioning mode behavior based on whether we have operational credentials" and "Start with commissioning mode disabled", instead of treating the two as synonyms. I audited all callsites that explicitly passed kDisabled to StartServer() instead of no args, and they all seem to want to actually disable commissioning mode. 2. Change CommissioningWindowManager to start/stop DNS-SD commissioning advertising in the same codepaths as BLE advertising. This means we stop advertising with CM=1 or CM=2 when we stop accepting PASE connections, and start doing it again when we start accepting PASE connections again (e.g. if commissioning fails).
Co-authored-by: chrisdecenzo <[email protected]>
bzbarsky-apple
force-pushed
the
truth-in-advertising
branch
from
971a76c to
c0fdbfe
Compare
|
PR #13813: Size comparison from beaa480 to c0fdbfe Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…connections. (project-chip#13813) * Make sure we don't advertise with CM=1 when we're not accepting PASE connections. Right now it's possible for a device to both be advertising over dns-sd with CM=1 and not be accepting PASE connections. Which makes the CM=1 not exactly true. Summary of changes: 1. Change DnssdServer to clearly differentiate between "Start with default commissioning mode behavior based on whether we have operational credentials" and "Start with commissioning mode disabled", instead of treating the two as synonyms. I audited all callsites that explicitly passed kDisabled to StartServer() instead of no args, and they all seem to want to actually disable commissioning mode. 2. Change CommissioningWindowManager to start/stop DNS-SD commissioning advertising in the same codepaths as BLE advertising. This means we stop advertising with CM=1 or CM=2 when we stop accepting PASE connections, and start doing it again when we start accepting PASE connections again (e.g. if commissioning fails). * Apply review suggestion. Co-authored-by: chrisdecenzo <[email protected]> Co-authored-by: chrisdecenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's possible for a device to both be advertising over
dns-sd with CM=1 and not be accepting PASE connections. Which makes
the CM=1 not exactly true.
Summary of changes:
Change DnssdServer to clearly differentiate between "Start with
default commissioning mode behavior based on whether we have
operational credentials" and "Start with commissioning mode disabled",
instead of treating the two as synonyms. I audited all callsites that
explicitly passed kDisabled to StartServer() instead of no args, and
they all seem to want to actually disable commissioning mode.
Change CommissioningWindowManager to start/stop DNS-SD
commissioning advertising in the same codepaths as BLE advertising.
This means we stop advertising with CM=1 or CM=2 when we stop
accepting PASE connections, and start doing it again when we start
accepting PASE connections again (e.g. if commissioning fails).
Problem
See above.
Change overview
See above.
Testing
Manually tested that a device stops advertising CM=1 while it's in the middle of being commissioned.