Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface a NetworkLocation on Android for ChipDeviceController #13797

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Surface a NetworkLocation on Android for ChipDeviceController #13797

merged 1 commit into from
Jan 26, 2022

Conversation

g-coppock
Copy link
Contributor

Currently there is a method to getIpAddress(), but we also need to know
the port. This adds a Java wrapper class that combines both properties,
and the JNI bindings to resolve.

Tested:

  • Commissioned an m5stack, and verified that the resolved
    NetworkLocation on the Java side matched Addr 0 logged from DIS after
    mDNS discovery completed.

@g-coppock g-coppock marked this pull request as ready for review January 21, 2022 01:24
@g-coppock g-coppock force-pushed the pr/coppock/network_location branch from 9a96a99 to 9db5e34 Compare January 21, 2022 01:33
@restyled-io restyled-io bot mentioned this pull request Jan 21, 2022
Closed
@g-coppock g-coppock force-pushed the pr/coppock/network_location branch from 9db5e34 to 2a43722 Compare January 21, 2022 01:35
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13797: Size comparison from cf1b254 to 2a43722

Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section cf1b254 2a43722 change % change
efr32 lighting-app BRD4161A (read only) 833660 833660 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125320 125320 0 0.0
.data 1896 1896 0 0.0
.text 833652 833652 0 0.0
BRD4161A+rpc (read only) 821056 821056 0 0.0
(read/write) 143880 143880 0 0.0
.bss 141880 141880 0 0.0
.data 1996 1996 0 0.0
.text 821048 821048 0 0.0
window-app BRD4161A (read only) 804212 804212 0 0.0
(read/write) 125792 125792 0 0.0
.bss 123944 123944 0 0.0
.data 1848 1848 0 0.0
.text 804204 804204 0 0.0
k32w light k32w061+release (read/write) 658940 658940 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574692 574692 0 0.0
lock k32w061+release (read/write) 659720 659720 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575212 575212 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8428364 8428364 0 0.0
(read/write) 388769 388769 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 259416 259416 0 0.0
.dynamic 560 560 0 0.0
.got 68424 68424 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 434308 434308 0 0.0
.text 7160308 7160308 0 0.0
thermostat-no-ble arm64 (read only) 2043340 2043340 0 0.0
(read/write) 145441 145441 0 0.0
.bss 64769 64769 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699152 1699152 0 0.0
p6 all-clusters-app default (read/write) 2407768 2407768 0 0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1366032 1366032 0 0.0
light-app default (read/write) 2328728 2328728 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286992 1286992 0 0.0
lock-app default (read/write) 2297736 2297736 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1256000 1256000 0 0.0
qpg lighting-app qpg6105+debug (read only) 565856 565856 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89664 89664 0 0.0
.data 1060 1060 0 0.0
.text 560536 560536 0 0.0
lock-app qpg6105+debug (read only) 514344 514344 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88232 88232 0 0.0
.data 984 984 0 0.0
.text 509024 509024 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839906 839906 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586988 586988 0 0.0

@g-coppock g-coppock force-pushed the pr/coppock/network_location branch from 2a43722 to e3946d1 Compare January 25, 2022 17:20
@g-coppock
Surface a NetworkLocation on Android for ChipDeviceController
40c4030 
Currently there is a method to getIpAddress(), but we also need to know
the port. This adds a Java wrapper class that combines both properties,
and the JNI bindings to resolve.

Tested:
- Commissioned an m5stack, and verified that the resolved
  NetworkLocation on the Java side matched Addr 0 logged from DIS after
  mDNS discovery completed.
@g-coppock g-coppock force-pushed the pr/coppock/network_location branch from e3946d1 to 40c4030 Compare January 25, 2022 17:45
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13797: Size comparison from c428576 to 40c4030

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c428576 40c4030 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 572022 572022 0 0.0
.app_xip_area 477084 477084 0 0.0
.bss 77684 77684 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 832416 832416 0 0.0
(read/write) 127216 127216 0 0.0
.bss 125312 125312 0 0.0
.data 1900 1900 0 0.0
.text 832408 832408 0 0.0
BRD4161A+rpc (read only) 819820 819820 0 0.0
(read/write) 143872 143872 0 0.0
.bss 141872 141872 0 0.0
.data 2000 2000 0 0.0
.text 819812 819812 0 0.0
window-app BRD4161A (read only) 808608 808608 0 0.0
(read/write) 125872 125872 0 0.0
.bss 124016 124016 0 0.0
.data 1856 1856 0 0.0
.text 808600 808600 0 0.0
esp32 all-clusters-app c3devkit (read only) 916812 916812 0 0.0
(read/write) 1317778 1317778 0 0.0
.dram0.bss 70696 70696 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 179440 179440 0 0.0
.flash.text 916812 916812 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965803 965803 0 0.0
(read/write) 450360 450360 0 0.0
.dram0.bss 75440 75440 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208760 208760 0 0.0
.flash.text 960419 960419 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660264 660264 0 0.0
.bss 77456 77456 0 0.0
.data 1868 1868 0 0.0
.text 575140 575140 0 0.0
lock k32w061+release (read/write) 661156 661156 0 0.0
.bss 77720 77720 0 0.0
.data 1892 1892 0 0.0
.text 575744 575744 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8697804 8697804 0 0.0
(read/write) 390817 390817 0 0.0
.bss 56017 56017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260888 260888 0 0.0
.dynamic 560 560 0 0.0
.got 69040 69040 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532532 532532 0 0.0
.text 7326532 7326532 0 0.0
thermostat-no-ble arm64 (read only) 2042268 2042268 0 0.0
(read/write) 146625 146625 0 0.0
.bss 65649 65649 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130556 130556 0 0.0
.text 1697408 1697408 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349712 2349712 0 0.0
.bss 189404 189404 0 0.0
.data 5296 5296 0 0.0
.text 1312312 1312312 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331968 2331968 0 0.0
.bss 180920 180920 0 0.0
.data 5576 5576 0 0.0
.text 1294568 1294568 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302552 2302552 0 0.0
.bss 180824 180824 0 0.0
.data 5568 5568 0 0.0
.text 1265152 1265152 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940803 940803 0 0.0
bss 119012 119012 0 0.0
rodata 109000 109000 0 0.0
text 635196 635196 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926287 926287 0 0.0
bss 116056 116056 0 0.0
rodata 101452 101452 0 0.0
text 630588 630588 0 0.0
nrf52840dongle_nrf52840 (read/write) 991447 991447 0 0.0
bss 121852 121852 0 0.0
rodata 113752 113752 0 0.0
text 667392 667392 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850630 850630 0 0.0
bss 115796 115796 0 0.0
rodata 102176 102176 0 0.0
text 552116 552116 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911275 0 0.0
bss 119064 119064 0 0.0
rodata 104056 104056 0 0.0
text 610772 610772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821346 821346 0 0.0
bss 115880 115880 0 0.0
rodata 97284 97284 0 0.0
text 527728 527728 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913951 913951 0 0.0
bss 118808 118808 0 0.0
rodata 104444 104444 0 0.0
text 613236 613236 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909119 909119 0 0.0
bss 118836 118836 0 0.0
rodata 103548 103548 0 0.0
text 609268 609268 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451316 451316 0 0.0
p6 all-clusters-app default (read/write) 2407784 2407784 0 0.0
.bss 117748 117748 0 0.0
.data 2584 2584 0 0.0
.text 1366048 1366048 0 0.0
light-app default (read/write) 2327520 2327520 0 0.0
.bss 105512 105512 0 0.0
.data 2408 2408 0 0.0
.text 1285784 1285784 0 0.0
lock-app default (read/write) 2296960 2296960 0 0.0
.bss 105256 105256 0 0.0
.data 2360 2360 0 0.0
.text 1255224 1255224 0 0.0
qpg lighting-app qpg6105+debug (read only) 565336 565336 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89656 89656 0 0.0
.data 1060 1060 0 0.0
.text 560016 560016 0 0.0
lock-app qpg6105+debug (read only) 514092 514092 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89128 89128 0 0.0
.data 992 992 0 0.0
.text 508772 508772 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839294 839294 0 0.0
bss 87460 87460 0 0.0
noinit 37160 37160 0 0.0
text 585882 585882 0 0.0

woody-apple
woody-apple approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given platform changes

@woody-apple woody-apple merged commit 4f320ab into project-chip:master Jan 26, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@g-coppock @selissia
Surface a NetworkLocation on Android for ChipDeviceController (projec…
60fde5f 
…t-chip#13797)

Currently there is a method to getIpAddress(), but we also need to know
the port. This adds a Java wrapper class that combines both properties,
and the JNI bindings to resolve.

Tested:
- Commissioned an m5stack, and verified that the resolved
  NetworkLocation on the Java side matched Addr 0 logged from DIS after
  mDNS discovery completed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-coppock @woody-apple @bzbarsky-apple