Address review comments on PR 13172. #13600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
pan-apple
|
PR #13600: Size comparison from 8aca71c to 9be87ec Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (22 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Fast tracking, given older PR, doesn't look like it should be stale. Still needs comments resolved. |
woody-apple
approved these changes
Jan 26, 2022
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
tcarmelveilleux
approved these changes
Feb 2, 2022
Changes: * Remove length anotations on some lists that are always handled via AttributeAccessInterface so should not count toward ATTRIBUTE_LARGEST. Reduces ATTRIBUTE_LARGEST from 401 to 255/259 for most apps. * Fix some .zap files that did not have those lists marked as External storage. * Add a way for applications to static_assert via a config variable that ATTRIBUTE_LARGEST is not larger than expected. * Stop using %zu for logging in Server.h * Add checks + logging for a missing attribute persistence provider in attribute-storage.
bzbarsky-apple
force-pushed
the
nvm-storage-followup
branch
2 times, most recently
from
e0d187d to
bdc68b1
Compare
|
PR #13600: Size comparison from 740284a to bdc68b1 Increases (2 builds for qpg)
Decreases (2 builds for qpg)
Full report (3 builds for qpg)
|
bzbarsky-apple
force-pushed
the
nvm-storage-followup
branch
from
bdc68b1 to
f7a1715
Compare
|
PR #13600: Size comparison from 740284a to f7a1715 Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (31 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Remove length anotations on some lists that are always handled via
AttributeAccessInterface so should not count toward
ATTRIBUTE_LARGEST. Reduces ATTRIBUTE_LARGEST from 401 to 255/259
for most apps.
Fix some .zap files that did not have those lists marked as External
storage.
Add a way for applications to static_assert via a config variable
that ATTRIBUTE_LARGEST is not larger than expected.
Stop using %zu for logging in Server.h
Add checks + logging for a missing attribute persistence provider in
attribute-storage.
Problem
Addressing review comments on #13172
Change overview
See above.
Testing
No obvious behavior changes, except in hard-to-exercise error conditions.