Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an error formatter for StatusIB encapsulated in CHIP_ERROR. #13568

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Add an error formatter for StatusIB encapsulated in CHIP_ERROR. #13568

merged 1 commit into from
Jan 18, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Printing errors that have a StatusIB inside is not as informative as one would like.

Change overview

Add an error formatter.

Testing

Unit tests.

@boring-cyborg boring-cyborg bot added the app label Jan 14, 2022
@github-actions
Copy link

github-actions bot commented Jan 14, 2022 •
edited
Loading

PR #13568: Size comparison from 5e61ce9 to 2c0ef7b

Increases above 0.2%:

platform target config section 5e61ce9 2c0ef7b change % change
efr32 lighting-app BRD4161A .data 1884 1892 8 0.4
BRD4161A+rpc .data 1984 1992 8 0.4
window-app BRD4161A .data 1836 1844 8 0.4
k32w light k32w061+release .data 1852 1860 8 0.4
lock k32w061+release .data 1872 1880 8 0.4
linux chip-tool-ipv6only arm64 .data 1096 1112 16 1.5
thermostat-no-ble arm64 .data 880 896 16 1.8
p6 all-clusters-app default .data 2592 2600 8 0.3
light-app default .data 2392 2400 8 0.3
lock-app default .data 2344 2352 8 0.3
qpg lighting-app qpg6105+debug .data 1044 1052 8 0.8
lock-app qpg6105+debug .data 972 980 8 0.8
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e61ce9 2c0ef7b change % change
efr32 lighting-app BRD4161A (read only) 832764 832852 88 0.0
(read/write) 127628 127636 8 0.0
.data 1884 1892 8 0.4
.text 832756 832844 88 0.0
BRD4161A+rpc (read only) 820168 820248 80 0.0
(read/write) 144288 144296 8 0.0
.data 1984 1992 8 0.4
.text 820160 820240 80 0.0
window-app BRD4161A (read only) 805424 805504 80 0.0
(read/write) 126320 126328 8 0.0
.data 1836 1844 8 0.4
.text 805416 805496 80 0.0
esp32 all-clusters-app c3devkit (read only) 910034 910102 68 0.0
(read/write) 1316506 1316522 16 0.0
.dram0.data 14284 14292 8 0.1
.flash.text 910034 910102 68 0.0
m5stack (read only) 959027 959091 64 0.0
(read/write) 448672 448688 16 0.0
.dram0.data 34064 34072 8 0.0
.flash.rodata 207504 207512 8 0.0
.flash.text 953643 953707 64 0.0
k32w light k32w061+release (read/write) 657920 657996 76 0.0
.data 1852 1860 8 0.4
.text 573132 573200 68 0.0
lock k32w061+release (read/write) 661604 661680 76 0.0
.data 1872 1880 8 0.4
.text 576500 576568 68 0.0
linux chip-tool-ipv6only arm64 (read only) 8024820 8026036 1216 0.0
(read/write) 370241 370257 16 0.0
.data 1096 1112 16 1.5
.rodata 417788 417836 48 0.0
.text 6819140 6820276 1136 0.0
thermostat-no-ble arm64 (read only) 2041980 2043340 1360 0.1
(read/write) 145969 145985 16 0.0
.data 880 896 16 1.8
.rodata 129884 129932 48 0.0
.text 1697504 1698800 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2347832 2347904 72 0.0
.data 5320 5328 8 0.2
.text 1310408 1310480 72 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2332416 2332488 72 0.0
.data 5560 5568 8 0.1
.text 1295016 1295088 72 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304536 2304600 64 0.0
.data 5544 5552 8 0.1
.text 1267136 1267200 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941447 941519 72 0.0
text 635576 635644 68 0.0
nrf52840dk_nrf52840+rpc (read/write) 926911 927003 92 0.0
rodata 101108 101112 4 0.0
text 630968 631036 68 0.0
nrf52840dongle_nrf52840 (read/write) 992091 992167 76 0.0
rodata 113412 113416 4 0.0
text 667772 667840 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851270 851346 76 0.0
rodata 101832 101836 4 0.0
text 552492 552560 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912619 912691 72 0.0
text 612672 612740 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822686 822762 76 0.0
rodata 97016 97020 4 0.0
text 529632 529700 68 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913991 914067 76 0.0
rodata 104004 104008 4 0.0
text 613996 614064 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910747 910835 88 0.0
text 611448 611516 68 0.0
p6 all-clusters-app default (read/write) 2402304 2402384 80 0.0
.data 2592 2600 8 0.3
.text 1360568 1360648 80 0.0
light-app default (read/write) 2327544 2327624 80 0.0
.data 2392 2400 8 0.3
.text 1285808 1285888 80 0.0
lock-app default (read/write) 2298456 2298528 72 0.0
.data 2344 2352 8 0.3
.text 1256720 1256792 72 0.0
qpg lighting-app qpg6105+debug (read only) 561976 562048 72 0.0
.data 1044 1052 8 0.8
.text 556656 556728 72 0.0
lock-app qpg6105+debug (read only) 515292 515364 72 0.0
.data 972 980 8 0.8
.text 509972 510044 72 0.0
telink lighting-app tlsr9518adk80d (read/write) 838462 838538 76 0.0
text 585618 585682 64 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e61ce9 2c0ef7b change % change
efr32 lighting-app BRD4161A (read only) 832764 832852 88 0.0
(read/write) 127628 127636 8 0.0
.bss 125744 125744 0 0.0
.data 1884 1892 8 0.4
.text 832756 832844 88 0.0
BRD4161A+rpc (read only) 820168 820248 80 0.0
(read/write) 144288 144296 8 0.0
.bss 142304 142304 0 0.0
.data 1984 1992 8 0.4
.text 820160 820240 80 0.0
window-app BRD4161A (read only) 805424 805504 80 0.0
(read/write) 126320 126328 8 0.0
.bss 124480 124480 0 0.0
.data 1836 1844 8 0.4
.text 805416 805496 80 0.0
esp32 all-clusters-app c3devkit (read only) 910034 910102 68 0.0
(read/write) 1316506 1316522 16 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14292 8 0.1
.flash.rodata 178224 178224 0 0.0
.flash.text 910034 910102 68 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959027 959091 64 0.0
(read/write) 448672 448688 16 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34072 8 0.0
.flash.rodata 207504 207512 8 0.0
.flash.text 953643 953707 64 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657920 657996 76 0.0
.bss 77136 77136 0 0.0
.data 1852 1860 8 0.4
.text 573132 573200 68 0.0
lock k32w061+release (read/write) 661604 661680 76 0.0
.bss 77432 77432 0 0.0
.data 1872 1880 8 0.4
.text 576500 576568 68 0.0
linux chip-tool-ipv6only arm64 (read only) 8024820 8026036 1216 0.0
(read/write) 370241 370257 16 0.0
.bss 55217 55217 0 0.0
.data 1096 1112 16 1.5
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64472 64472 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 417788 417836 48 0.0
.text 6819140 6820276 1136 0.0
thermostat-no-ble arm64 (read only) 2041980 2043340 1360 0.1
(read/write) 145969 145985 16 0.0
.bss 65089 65089 0 0.0
.data 880 896 16 1.8
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129932 48 0.0
.text 1697504 1698800 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347832 2347904 72 0.0
.bss 189204 189204 0 0.0
.data 5320 5328 8 0.2
.text 1310408 1310480 72 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332416 2332488 72 0.0
.bss 180752 180752 0 0.0
.data 5560 5568 8 0.1
.text 1295016 1295088 72 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304536 2304600 64 0.0
.bss 179768 179768 0 0.0
.data 5544 5552 8 0.1
.text 1267136 1267200 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941447 941519 72 0.0
bss 119624 119624 0 0.0
rodata 108660 108660 0 0.0
text 635576 635644 68 0.0
nrf52840dk_nrf52840+rpc (read/write) 926911 927003 92 0.0
bss 116668 116668 0 0.0
rodata 101108 101112 4 0.0
text 630968 631036 68 0.0
nrf52840dongle_nrf52840 (read/write) 992091 992167 76 0.0
bss 122464 122464 0 0.0
rodata 113412 113416 4 0.0
text 667772 667840 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851270 851346 76 0.0
bss 116412 116412 0 0.0
rodata 101832 101836 4 0.0
text 552492 552560 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912619 912691 72 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612672 612740 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822686 822762 76 0.0
bss 115600 115600 0 0.0
rodata 97016 97020 4 0.0
text 529632 529700 68 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913991 914067 76 0.0
bss 118544 118544 0 0.0
rodata 104004 104008 4 0.0
text 613996 614064 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910747 910835 88 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611448 611516 68 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451672 451672 0 0.0
p6 all-clusters-app default (read/write) 2402304 2402384 80 0.0
.bss 117484 117484 0 0.0
.data 2592 2600 8 0.3
.text 1360568 1360648 80 0.0
light-app default (read/write) 2327544 2327624 80 0.0
.bss 106064 106064 0 0.0
.data 2392 2400 8 0.3
.text 1285808 1285888 80 0.0
lock-app default (read/write) 2298456 2298528 72 0.0
.bss 104920 104920 0 0.0
.data 2344 2352 8 0.3
.text 1256720 1256792 72 0.0
qpg lighting-app qpg6105+debug (read only) 561976 562048 72 0.0
(read/write) 146936 146936 0 0.0
.bss 89952 89952 0 0.0
.data 1044 1052 8 0.8
.text 556656 556728 72 0.0
lock-app qpg6105+debug (read only) 515292 515364 72 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 980 8 0.8
.text 509972 510044 72 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838462 838538 76 0.0
bss 87312 87312 0 0.0
noinit 37160 37160 0 0.0
text 585618 585682 64 0.0

@andy31415
Copy link
Contributor

fast track: has been up for sufficient time, has checkmarks.

@andy31415 andy31415 merged commit faa6043 into project-chip:master Jan 18, 2022
@bzbarsky-apple bzbarsky-apple deleted the format-status-ib-error branch January 18, 2022 14:48
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Add an error formatter for StatusIB encapsulated in CHIP_ERROR. (proj…
9a5b65a 
…ect-chip#13568)
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@bzbarsky-apple @step0035
Add an error formatter for StatusIB encapsulated in CHIP_ERROR. (proj…
0b0b8a6 
…ect-chip#13568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @msandstedt