Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle write on identifyTime attribute on esp32 side #13536

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Handle write on identifyTime attribute on esp32 side #13536

merged 2 commits into from
Jan 28, 2022

Conversation

PSONALl
Copy link
Contributor

@PSONALl PSONALl commented Jan 13, 2022 •
edited
Loading

What is being fixed?

Handled attribute write command for identifyTime attribute on esp32 side in all-clusters-app

Change overview

Added OnIdentifyAttributeChangeCallback in DeviceCallbacks.cpp

Testing

  • Tested commissioning and cluster control using chip-tool

@restyled-io restyled-io bot mentioned this pull request Jan 13, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

PR #13536: Size comparison from 5c5ab58 to e096d73

Increases (2 builds for esp32)
platform target config section 5c5ab58 e096d73 change % change
esp32 all-clusters-app c3devkit (read only) 908540 908584 44 0.0
.flash.text 908540 908584 44 0.0
m5stack (read only) 957239 957283 44 0.0
.flash.text 951855 951899 44 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5c5ab58 e096d73 change % change
efr32 lighting-app BRD4161A (read only) 831424 831424 0 0.0
(read/write) 127612 127612 0 0.0
.bss 125732 125732 0 0.0
.data 1880 1880 0 0.0
.text 831416 831416 0 0.0
BRD4161A+rpc (read only) 818820 818820 0 0.0
(read/write) 144272 144272 0 0.0
.bss 142292 142292 0 0.0
.data 1980 1980 0 0.0
.text 818812 818812 0 0.0
window-app BRD4161A (read only) 805304 805304 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805296 805296 0 0.0
esp32 all-clusters-app c3devkit (read only) 908540 908584 44 0.0
(read/write) 1316498 1316498 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178216 178216 0 0.0
.flash.text 908540 908584 44 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 957239 957283 44 0.0
(read/write) 448664 448664 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207496 207496 0 0.0
.flash.text 951855 951899 44 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657800 657800 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573012 573012 0 0.0
lock k32w061+release (read/write) 661564 661564 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576460 576460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7742900 7742900 0 0.0
(read/write) 360817 360817 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 239216 239216 0 0.0
.dynamic 560 560 0 0.0
.got 61592 61592 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 404140 404140 0 0.0
.text 6573668 6573668 0 0.0
thermostat-no-ble arm64 (read only) 2040988 2040988 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129868 129868 0 0.0
.text 1696528 1696528 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346480 2346480 0 0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1309056 1309056 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331304 2331304 0 0.0
.bss 180728 180728 0 0.0
.data 5552 5552 0 0.0
.text 1293904 1293904 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304528 2304528 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267128 1267128 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054456 2054456 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017056 1017056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940335 940335 0 0.0
bss 119596 119596 0 0.0
rodata 108508 108508 0 0.0
text 634656 634656 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925771 925771 0 0.0
bss 116640 116640 0 0.0
rodata 100960 100960 0 0.0
text 630008 630008 0 0.0
nrf52840dongle_nrf52840 (read/write) 991015 991015 0 0.0
bss 122440 122440 0 0.0
rodata 113264 113264 0 0.0
text 666852 666852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850162 850162 0 0.0
bss 116384 116384 0 0.0
rodata 101684 101684 0 0.0
text 551576 551576 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912575 912575 0 0.0
bss 118784 118784 0 0.0
rodata 103780 103780 0 0.0
text 612648 612648 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822646 822646 0 0.0
bss 115600 115600 0 0.0
rodata 97008 97008 0 0.0
text 529608 529608 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913903 913903 0 0.0
bss 118544 118544 0 0.0
rodata 103996 103996 0 0.0
text 613908 613908 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910687 910687 0 0.0
bss 118572 118572 0 0.0
rodata 103252 103252 0 0.0
text 611396 611396 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798643 798643 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533988 533988 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711462 711462 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2400648 2400648 0 0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1358912 1358912 0 0.0
light-app default (read/write) 2326200 2326200 0 0.0
.bss 106040 106040 0 0.0
.data 2384 2384 0 0.0
.text 1284464 1284464 0 0.0
lock-app default (read/write) 2298432 2298432 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256696 1256696 0 0.0
qpg lighting-app qpg6105+debug (read only) 535004 535004 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89336 89336 0 0.0
.data 1008 1008 0 0.0
.text 529684 529684 0 0.0
lock-app qpg6105+debug (read only) 506928 506928 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88472 88472 0 0.0
.data 956 956 0 0.0
.text 501608 501608 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836974 836974 0 0.0
bss 87288 87288 0 0.0
noinit 37160 37160 0 0.0
text 584340 584340 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given platform changes by a platform maintainer.

@woody-apple
Copy link
Contributor

@PSONALl please restyle this PR! :)

@PSONALl PSONALl force-pushed the handle-identify-on-esp32 branch from e096d73 to 3a2111e Compare January 17, 2022 10:09
@github-actions
Copy link

github-actions bot commented Jan 17, 2022 •
edited
Loading

PR #13536: Size comparison from e4faade to 3a2111e

Increases (2 builds for esp32)
platform target config section e4faade 3a2111e change % change
esp32 all-clusters-app c3devkit (read only) 912094 912138 44 0.0
.flash.text 912094 912138 44 0.0
m5stack (read only) 960883 960915 32 0.0
.flash.text 955499 955531 32 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e4faade 3a2111e change % change
efr32 lighting-app BRD4161A (read only) 834852 834852 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834844 834844 0 0.0
BRD4161A+rpc (read only) 822232 822232 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822224 822224 0 0.0
window-app BRD4161A (read only) 805424 805424 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805416 0 0.0
esp32 all-clusters-app c3devkit (read only) 912094 912138 44 0.0
(read/write) 1316682 1316682 0 0.0
.dram0.bss 70520 70520 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912094 912138 44 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 960883 960915 32 0.0
(read/write) 448840 448840 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207672 207672 0 0.0
.flash.text 955499 955531 32 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659064 659064 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 574276 574276 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576692 576692 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8042100 8042100 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6833684 6833684 0 0.0
thermostat-no-ble arm64 (read only) 2042108 2042108 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697632 1697632 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349856 2349856 0 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312432 1312432 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334504 2334504 0 0.0
.bss 180760 180760 0 0.0
.data 5568 5568 0 0.0
.text 1297104 1297104 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304848 2304848 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267448 1267448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943403 943403 0 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637376 637376 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928883 928883 0 0.0
bss 116672 116672 0 0.0
rodata 101272 101272 0 0.0
text 632772 632772 0 0.0
nrf52840dongle_nrf52840 (read/write) 994079 994079 0 0.0
bss 122472 122472 0 0.0
rodata 113576 113576 0 0.0
text 669576 669576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853242 853242 0 0.0
bss 116416 116416 0 0.0
rodata 101996 101996 0 0.0
text 554300 554300 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912763 912763 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612824 612824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822830 822830 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529784 529784 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915627 915627 0 0.0
bss 118548 118548 0 0.0
rodata 104152 104152 0 0.0
text 615480 615480 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910715 910715 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611404 611404 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2404744 2404744 0 0.0
.bss 117556 117556 0 0.0
.data 2600 2600 0 0.0
.text 1363008 1363008 0 0.0
light-app default (read/write) 2330048 2330048 0 0.0
.bss 106128 106128 0 0.0
.data 2392 2392 0 0.0
.text 1288312 1288312 0 0.0
lock-app default (read/write) 2299072 2299072 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257336 1257336 0 0.0
qpg lighting-app qpg6105+debug (read only) 565072 565072 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 559752 559752 0 0.0
lock-app qpg6105+debug (read only) 515484 515484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510164 510164 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840778 840778 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587748 587748 0 0.0

@PSONALl PSONALl force-pushed the handle-identify-on-esp32 branch 3 times, most recently from 2bfdc3e to 376e0c4 Compare January 17, 2022 14:34
@github-actions
Copy link

github-actions bot commented Jan 17, 2022 •
edited
Loading

PR #13536: Size comparison from e4faade to 376e0c4

Increases (4 builds for esp32, mbed, p6)
platform target config section e4faade 376e0c4 change % change
esp32 all-clusters-app c3devkit (read only) 912094 912198 104 0.0
(read/write) 1316682 1316746 64 0.0
.flash.rodata 178384 178448 64 0.0
.flash.text 912094 912198 104 0.0
m5stack (read only) 960883 960971 88 0.0
(read/write) 448840 448912 72 0.0
.dram0.bss 74976 74984 8 0.0
.flash.rodata 207672 207736 64 0.0
.flash.text 955499 955587 88 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2349856 2349920 64 0.0
.text 1312432 1312496 64 0.0
p6 all-clusters-app default (read/write) 2404744 2404808 64 0.0
.text 1363008 1363072 64 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e4faade 376e0c4 change % change
efr32 lighting-app BRD4161A (read only) 834852 834852 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834844 834844 0 0.0
BRD4161A+rpc (read only) 822232 822232 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822224 822224 0 0.0
window-app BRD4161A (read only) 805424 805424 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805416 0 0.0
esp32 all-clusters-app c3devkit (read only) 912094 912198 104 0.0
(read/write) 1316682 1316746 64 0.0
.dram0.bss 70520 70520 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178384 178448 64 0.0
.flash.text 912094 912198 104 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 960883 960971 88 0.0
(read/write) 448840 448912 72 0.0
.dram0.bss 74976 74984 8 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207672 207736 64 0.0
.flash.text 955499 955587 88 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659064 659064 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 574276 574276 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576692 576692 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8042100 8042100 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6833684 6833684 0 0.0
thermostat-no-ble arm64 (read only) 2042108 2042108 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697632 1697632 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349856 2349920 64 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312432 1312496 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334504 2334504 0 0.0
.bss 180760 180760 0 0.0
.data 5568 5568 0 0.0
.text 1297104 1297104 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304848 2304848 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267448 1267448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943403 943403 0 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637376 637376 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928883 928883 0 0.0
bss 116672 116672 0 0.0
rodata 101272 101272 0 0.0
text 632772 632772 0 0.0
nrf52840dongle_nrf52840 (read/write) 994079 994079 0 0.0
bss 122472 122472 0 0.0
rodata 113576 113576 0 0.0
text 669576 669576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853242 853242 0 0.0
bss 116416 116416 0 0.0
rodata 101996 101996 0 0.0
text 554300 554300 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912763 912763 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612824 612824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822830 822830 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529784 529784 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915627 915627 0 0.0
bss 118548 118548 0 0.0
rodata 104152 104152 0 0.0
text 615480 615480 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910715 910715 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611404 611404 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2404744 2404808 64 0.0
.bss 117556 117556 0 0.0
.data 2600 2600 0 0.0
.text 1363008 1363072 64 0.0
light-app default (read/write) 2330048 2330048 0 0.0
.bss 106128 106128 0 0.0
.data 2392 2392 0 0.0
.text 1288312 1288312 0 0.0
lock-app default (read/write) 2299072 2299072 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257336 1257336 0 0.0
qpg lighting-app qpg6105+debug (read only) 565072 565072 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 559752 559752 0 0.0
lock-app qpg6105+debug (read only) 515484 515484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510164 510164 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840778 840778 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587748 587748 0 0.0

@PSONALl PSONALl force-pushed the handle-identify-on-esp32 branch 3 times, most recently from d9c07d0 to 8b44da7 Compare January 25, 2022 10:48
@restyled-io restyled-io bot mentioned this pull request Jan 25, 2022
Closed
@PSONALl PSONALl force-pushed the handle-identify-on-esp32 branch from 8b44da7 to 0d0d0db Compare January 25, 2022 11:00
@PSONALl PSONALl force-pushed the handle-identify-on-esp32 branch from 0d0d0db to 74079f3 Compare January 25, 2022 11:02
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13536: Size comparison from e169fcf to 74079f3

Increases (2 builds for esp32)
platform target config section e169fcf 74079f3 change % change
esp32 all-clusters-app c3devkit (read only) 919202 919334 132 0.0
.flash.text 919202 919334 132 0.0
m5stack (read only) 967535 967647 112 0.0
.flash.text 962151 962263 112 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e169fcf 74079f3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573714 0 0.0
.app_xip_area 479016 479016 0 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835484 0 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835476 0 0.0
BRD4161A+rpc (read only) 822864 822864 0 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 822856 0 0.0
window-app BRD4161A (read only) 806324 806324 0 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806316 0 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919334 132 0.0
(read/write) 1376810 1376810 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176064 176064 0 0.0
.flash.text 919202 919334 132 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967647 112 0.0
(read/write) 443240 443240 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205224 205224 0 0.0
.flash.text 962151 962263 112 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660864 660864 0 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 575972 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576616 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8639540 8639540 0 0.0
(read/write) 390961 390961 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260976 260976 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 532716 532716 0 0.0
.text 7267860 7267860 0 0.0
thermostat-no-ble arm64 (read only) 2050428 2050428 0 0.0
(read/write) 145969 145969 0 0.0
.bss 64897 64897 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73160 73160 0 0.0
.dynamic 560 560 0 0.0
.got 4056 4056 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 129948 129948 0 0.0
.text 1706080 1706080 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2348784 0 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311360 1311360 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333984 2333984 0 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296584 1296584 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304568 2304568 0 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267168 1267168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942175 942175 0 0.0
bss 118776 118776 0 0.0
rodata 108708 108708 0 0.0
text 637104 637104 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 927675 927675 0 0.0
bss 115820 115820 0 0.0
rodata 101160 101160 0 0.0
text 632500 632500 0 0.0
nrf52840dongle_nrf52840 (read/write) 992855 992855 0 0.0
bss 121616 121616 0 0.0
rodata 113464 113464 0 0.0
text 669304 669304 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852034 852034 0 0.0
bss 115564 115564 0 0.0
rodata 101884 101884 0 0.0
text 554024 554024 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912683 912683 0 0.0
bss 118828 118828 0 0.0
rodata 103768 103768 0 0.0
text 612680 612680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822702 822702 0 0.0
bss 115648 115648 0 0.0
rodata 96992 96992 0 0.0
text 529636 529636 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915339 915339 0 0.0
bss 118576 118576 0 0.0
rodata 104152 104152 0 0.0
text 615148 615148 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910523 910523 0 0.0
bss 118600 118600 0 0.0
rodata 103256 103256 0 0.0
text 611176 611176 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407448 0 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365712 0 0.0
light-app default (read/write) 2330256 2330256 0 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288520 0 0.0
lock-app default (read/write) 2299664 2299664 0 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1257928 0 0.0
qpg lighting-app qpg6105+debug (read only) 567092 567092 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561772 0 0.0
lock-app qpg6105+debug (read only) 515752 515752 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510432 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841062 0 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588184 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given > 3 days for review.

@PSONALl PSONALl force-pushed the handle-identify-on-esp32 branch from a8dbbbd to bc38ae9 Compare January 28, 2022 04:46
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

PR #13536: Size comparison from 92f8343 to bc38ae9

Increases (2 builds for esp32)
platform target config section 92f8343 bc38ae9 change % change
esp32 all-clusters-app c3devkit (read only) 932734 932870 136 0.0
.flash.text 932734 932870 136 0.0
m5stack (read only) 980687 980767 80 0.0
.flash.text 975303 975383 80 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 92f8343 bc38ae9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578130 578130 0 0.0
.app_xip_area 484224 484224 0 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536142 536142 0 0.0
.app_xip_area 443780 443780 0 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842984 842984 0 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842976 842976 0 0.0
BRD4161A+rpc (read only) 830336 830336 0 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830328 830328 0 0.0
window-app BRD4161A (read only) 815560 815560 0 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815552 815552 0 0.0
esp32 all-clusters-app c3devkit (read only) 932734 932870 136 0.0
(read/write) 1397322 1397322 0 0.0
.dram0.bss 69688 69688 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 194480 194480 0 0.0
.flash.text 932734 932870 136 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980687 980767 80 0.0
(read/write) 461692 461692 0 0.0
.dram0.bss 74432 74432 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221108 221108 0 0.0
.flash.text 975303 975383 80 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662940 662940 0 0.0
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578844 578844 0 0.0
lock k32w061+release (read/write) 663844 663844 0 0.0
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579460 579460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6765620 6765620 0 0.0
(read/write) 279201 279201 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 175984 0 0.0
.dynamic 560 560 0 0.0
.got 42784 42784 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 386892 386892 0 0.0
.text 5806628 5806628 0 0.0
thermostat-no-ble arm64 (read only) 2080620 2080620 0 0.0
(read/write) 149537 149537 0 0.0
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 129932 129932 0 0.0
.text 1733344 1733344 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382408 2382408 0 0.0
.bss 188588 188588 0 0.0
.data 5288 5288 0 0.0
.text 1345008 1345008 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338200 2338200 0 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300800 1300800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302240 2302240 0 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264840 1264840 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2292980 0 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255552 1255552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981375 0 0.0
bss 119660 119660 0 0.0
rodata 115684 115684 0 0.0
text 668228 668228 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 966923 0 0.0
bss 116704 116704 0 0.0
rodata 107160 107160 0 0.0
text 664672 664672 0 0.0
nrf52840dongle_nrf52840 (read/write) 997459 997459 0 0.0
bss 120832 120832 0 0.0
rodata 114516 114516 0 0.0
text 673656 673656 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890546 0 0.0
bss 116448 116448 0 0.0
rodata 108964 108964 0 0.0
text 584416 584416 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913955 913955 0 0.0
bss 118040 118040 0 0.0
rodata 104320 104320 0 0.0
text 614212 614212 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824006 824006 0 0.0
bss 114856 114856 0 0.0
rodata 97528 97528 0 0.0
text 531172 531172 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 916819 0 0.0
bss 117792 117792 0 0.0
rodata 104832 104832 0 0.0
text 616748 616748 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912003 912003 0 0.0
bss 117816 117816 0 0.0
rodata 103936 103936 0 0.0
text 612788 612788 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2441656 2441656 0 0.0
.bss 116740 116740 0 0.0
.data 2584 2584 0 0.0
.text 1399920 1399920 0 0.0
light-app default (read/write) 2338568 2338568 0 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296832 1296832 0 0.0
lock-app default (read/write) 2304080 2304080 0 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262344 1262344 0 0.0
qpg lighting-app qpg6105+debug (read only) 570884 570884 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565564 565564 0 0.0
lock-app qpg6105+debug (read only) 517004 517004 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511684 511684 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845770 845770 0 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592508 592508 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit d2fded9 into project-chip:master Jan 28, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@PSONALl @selissia
Handle write on identifyTime attribute on esp32 side (project-chip#13536
65226f2 
)

* Handle write on identifyTime attribute on esp32 side

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

Assignees
No one assigned
Labels
examples fast track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PSONALl @woody-apple @dhrishi @bzbarsky-apple