Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pump-examples] Removed SED settings for both pump apps #13527

Merged
merged 4 commits into from
Jan 18, 2022
Merged

[pump-examples] Removed SED settings for both pump apps #13527

merged 4 commits into from
Jan 18, 2022

Conversation

andersbangGF
Copy link
Contributor

@andersbangGF andersbangGF commented Jan 13, 2022 •
edited
Loading

Problem

Since #13330 BLE commissioning has been broken in the pump apps. This was caused by the devices accidentally being set to Thread SED in an earlier PR.

Change overview

Removed the SED defines from the two projects config files

Testing

  • Tested pump-app and pump-controller BLE commissioning with Mac Chip-Tool and Android Chip-Tool

@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

PR #13527: Size comparison from cd9bea7 to fe67366

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cd9bea7 fe67366 change % change
efr32 lighting-app BRD4161A (read only) 831456 831456 0 0.0
(read/write) 127612 127612 0 0.0
.bss 125732 125732 0 0.0
.data 1880 1880 0 0.0
.text 831448 831448 0 0.0
BRD4161A+rpc (read only) 818852 818852 0 0.0
(read/write) 144272 144272 0 0.0
.bss 142292 142292 0 0.0
.data 1980 1980 0 0.0
.text 818844 818844 0 0.0
window-app BRD4161A (read only) 805336 805336 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805328 805328 0 0.0
esp32 all-clusters-app c3devkit (read only) 908600 908600 0 0.0
(read/write) 1316426 1316426 0 0.0
.dram0.bss 70488 70488 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178160 178160 0 0.0
.flash.text 908600 908600 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 957275 957275 0 0.0
(read/write) 448576 448576 0 0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207432 207432 0 0.0
.flash.text 951891 951891 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657384 657384 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 572596 572596 0 0.0
lock k32w061+release (read/write) 661668 661668 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576564 576564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7742916 7742916 0 0.0
(read/write) 360817 360817 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 239216 239216 0 0.0
.dynamic 560 560 0 0.0
.got 61592 61592 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 404124 404124 0 0.0
.text 6573700 6573700 0 0.0
thermostat-no-ble arm64 (read only) 2040908 2040908 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129868 129868 0 0.0
.text 1696448 1696448 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346360 2346360 0 0.0
.bss 189188 189188 0 0.0
.data 5320 5320 0 0.0
.text 1308936 1308936 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331392 2331392 0 0.0
.bss 180728 180728 0 0.0
.data 5552 5552 0 0.0
.text 1293992 1293992 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304552 2304552 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267152 1267152 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054392 2054392 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016992 1016992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940411 940411 0 0.0
bss 119596 119596 0 0.0
rodata 108600 108600 0 0.0
text 634632 634632 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925843 925843 0 0.0
bss 116640 116640 0 0.0
rodata 101048 101048 0 0.0
text 629984 629984 0 0.0
nrf52840dongle_nrf52840 (read/write) 991071 991071 0 0.0
bss 122440 122440 0 0.0
rodata 113352 113352 0 0.0
text 666828 666828 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850238 850238 0 0.0
bss 116384 116384 0 0.0
rodata 101776 101776 0 0.0
text 551552 551552 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912651 912651 0 0.0
bss 118784 118784 0 0.0
rodata 103872 103872 0 0.0
text 612624 612624 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822718 822718 0 0.0
bss 115600 115600 0 0.0
rodata 97096 97096 0 0.0
text 529584 529584 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913963 913963 0 0.0
bss 118544 118544 0 0.0
rodata 104088 104088 0 0.0
text 613884 613884 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910763 910763 0 0.0
bss 118572 118572 0 0.0
rodata 103344 103344 0 0.0
text 611372 611372 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798627 798627 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533968 533968 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711446 711446 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451648 451648 0 0.0
p6 all-clusters-app default (read/write) 2400512 2400512 0 0.0
.bss 117460 117460 0 0.0
.data 2592 2592 0 0.0
.text 1358776 1358776 0 0.0
light-app default (read/write) 2326232 2326232 0 0.0
.bss 106040 106040 0 0.0
.data 2384 2384 0 0.0
.text 1284496 1284496 0 0.0
lock-app default (read/write) 2298464 2298464 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256728 1256728 0 0.0
qpg lighting-app qpg6105+debug (read only) 535100 535100 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89336 89336 0 0.0
.data 1008 1008 0 0.0
.text 529780 529780 0 0.0
lock-app qpg6105+debug (read only) 507008 507008 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88472 88472 0 0.0
.data 956 956 0 0.0
.text 501688 501688 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 837062 837062 0 0.0
bss 87288 87288 0 0.0
noinit 37160 37160 0 0.0
text 584334 584334 0 0.0

woody-apple
woody-apple approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given platform changes by a platform maintainer.

@github-actions
Copy link

github-actions bot commented Jan 14, 2022 •
edited
Loading

PR #13527: Size comparison from 5e61ce9 to 0a18fb1

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e61ce9 0a18fb1 change % change
efr32 lighting-app BRD4161A (read only) 832764 832764 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 832756 832756 0 0.0
BRD4161A+rpc (read only) 820168 820168 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 820160 820160 0 0.0
window-app BRD4161A (read only) 805424 805424 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805416 0 0.0
esp32 all-clusters-app c3devkit (read only) 910034 910034 0 0.0
(read/write) 1316506 1316506 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178224 178224 0 0.0
.flash.text 910034 910034 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959027 959027 0 0.0
(read/write) 448672 448672 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207504 207504 0 0.0
.flash.text 953643 953643 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657920 657920 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573132 573132 0 0.0
lock k32w061+release (read/write) 661604 661604 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576500 576500 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8024820 8024820 0 0.0
(read/write) 370241 370241 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64472 64472 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 417788 417788 0 0.0
.text 6819140 6819140 0 0.0
thermostat-no-ble arm64 (read only) 2041980 2041980 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697504 1697504 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347832 2347832 0 0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1310408 1310408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332416 2332416 0 0.0
.bss 180752 180752 0 0.0
.data 5560 5560 0 0.0
.text 1295016 1295016 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304536 2304536 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267136 1267136 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941447 941447 0 0.0
bss 119624 119624 0 0.0
rodata 108660 108660 0 0.0
text 635576 635576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926911 926911 0 0.0
bss 116668 116668 0 0.0
rodata 101108 101108 0 0.0
text 630968 630968 0 0.0
nrf52840dongle_nrf52840 (read/write) 992091 992091 0 0.0
bss 122464 122464 0 0.0
rodata 113412 113412 0 0.0
text 667772 667772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851270 851270 0 0.0
bss 116412 116412 0 0.0
rodata 101832 101832 0 0.0
text 552492 552492 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912619 912619 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612672 612672 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822686 822686 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529632 529632 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913991 913991 0 0.0
bss 118544 118544 0 0.0
rodata 104004 104004 0 0.0
text 613996 613996 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910747 910747 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611448 611448 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451672 451672 0 0.0
p6 all-clusters-app default (read/write) 2402304 2402304 0 0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1360568 1360568 0 0.0
light-app default (read/write) 2327544 2327544 0 0.0
.bss 106064 106064 0 0.0
.data 2392 2392 0 0.0
.text 1285808 1285808 0 0.0
lock-app default (read/write) 2298456 2298456 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256720 1256720 0 0.0
qpg lighting-app qpg6105+debug (read only) 561976 561976 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89952 89952 0 0.0
.data 1044 1044 0 0.0
.text 556656 556656 0 0.0
lock-app qpg6105+debug (read only) 515292 515292 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 509972 509972 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838462 838462 0 0.0
bss 87312 87312 0 0.0
noinit 37160 37160 0 0.0
text 585618 585618 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 18, 2022 •
edited
Loading

PR #13527: Size comparison from d611c63 to f0ae262

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d611c63 f0ae262 change % change
efr32 lighting-app BRD4161A (read only) 834868 834868 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834860 834860 0 0.0
BRD4161A+rpc (read only) 822264 822264 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822256 822256 0 0.0
window-app BRD4161A (read only) 805456 805456 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805448 805448 0 0.0
esp32 all-clusters-app c3devkit (read only) 912384 912384 0 0.0
(read/write) 1316682 1316682 0 0.0
.dram0.bss 70528 70528 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912384 912384 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961223 961223 0 0.0
(read/write) 448848 448848 0 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207672 207672 0 0.0
.flash.text 955839 955839 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659080 659080 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 574292 574292 0 0.0
lock k32w061+release (read/write) 661812 661812 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576708 576708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8049492 8049492 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6841076 6841076 0 0.0
thermostat-no-ble arm64 (read only) 2042812 2042812 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1698336 1698336 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350112 2350112 0 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312688 1312688 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334568 2334568 0 0.0
.bss 180760 180760 0 0.0
.data 5568 5568 0 0.0
.text 1297168 1297168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304912 2304912 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267512 1267512 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943419 943419 0 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637388 637388 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928899 928899 0 0.0
bss 116672 116672 0 0.0
rodata 101272 101272 0 0.0
text 632784 632784 0 0.0
nrf52840dongle_nrf52840 (read/write) 994095 994095 0 0.0
bss 122472 122472 0 0.0
rodata 113576 113576 0 0.0
text 669588 669588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853242 853242 0 0.0
bss 116416 116416 0 0.0
rodata 101996 101996 0 0.0
text 554312 554312 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912779 912779 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612836 612836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822846 822846 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529796 529796 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915643 915643 0 0.0
bss 118548 118548 0 0.0
rodata 104152 104152 0 0.0
text 615492 615492 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910715 910715 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611416 611416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451668 451668 0 0.0
p6 all-clusters-app default (read/write) 2405224 2405224 0 0.0
.bss 117556 117556 0 0.0
.data 2600 2600 0 0.0
.text 1363488 1363488 0 0.0
light-app default (read/write) 2330080 2330080 0 0.0
.bss 106128 106128 0 0.0
.data 2392 2392 0 0.0
.text 1288344 1288344 0 0.0
lock-app default (read/write) 2299104 2299104 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257368 1257368 0 0.0
qpg lighting-app qpg6105+debug (read only) 565088 565088 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 559768 559768 0 0.0
lock-app qpg6105+debug (read only) 515500 515500 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510180 510180 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840826 840826 0 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587790 587790 0 0.0

@andy31415 andy31415 merged commit 07454af into project-chip:master Jan 18, 2022
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jan 18, 2022
@andersbangGF @rcasallas-silabs
[pump-examples] Removed SED settings for both pump apps (project-chip…
dddf7a1 
…#13527)

* Removed SED settings

* Added back defines for security test modes and removes submodule added by accident
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@andersbangGF @selissia
[pump-examples] Removed SED settings for both pump apps (project-chip…
987fbd0 
…#13527)

* Removed SED settings

* Added back defines for security test modes and removes submodule added by accident
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@andersbangGF @step0035
[pump-examples] Removed SED settings for both pump apps (project-chip…
3bb5981 
…#13527)

* Removed SED settings

* Added back defines for security test modes and removes submodule added by accident
@tlykkeberg-grundfos tlykkeberg-grundfos deleted the bugfix/FixBLEComissioning branch March 2, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andersbangGF @andy31415 @woody-apple @bzbarsky-apple @Damian-Nordic