Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patch on ESP32 Docker img #13474

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Remove patch on ESP32 Docker img #13474

merged 1 commit into from
Jan 12, 2022

Conversation

electrocucaracha
Copy link
Collaborator

Problem

8aaabc2 removed the patch reference in the Dockerfile so this patch file is not used anymore

Fixes #10310

Change overview

Removed leftovers from the source code

Testing

@electrocucaracha
Remove patch on ESP32 Docker img
046119e 
Signed-off-by: Victor Morales <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13474: Size comparison from f878e4a to 046119e

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f878e4a 046119e change % change
efr32 lighting-app BRD4161A (read only) 830304 830304 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830296 830296 0 0.0
BRD4161A+rpc (read only) 817708 817708 0 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817700 817700 0 0.0
window-app BRD4161A (read only) 804248 804248 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804240 804240 0 0.0
esp32 all-clusters-app c3devkit (read only) 898202 898202 0 0.0
(read/write) 1316090 1316090 0 0.0
.dram0.bss 70168 70168 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178208 178208 0 0.0
.flash.text 898202 898202 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959383 959383 0 0.0
(read/write) 448544 448544 0 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207696 207696 0 0.0
.flash.text 953999 953999 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656404 656404 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571928 571928 0 0.0
lock k32w061+release (read/write) 660740 660740 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575948 575948 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7183964 7183964 0 0.0
(read/write) 344625 344625 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 226744 226744 0 0.0
.dynamic 560 560 0 0.0
.got 58232 58232 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390756 390756 0 0.0
.text 6062036 6062036 0 0.0
thermostat-no-ble arm64 (read only) 2037788 2037788 0 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129516 129516 0 0.0
.text 1693968 1693968 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348984 2348984 0 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1311560 1311560 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330560 2330560 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293160 1293160 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303784 2303784 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266384 1266384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939327 939327 0 0.0
bss 119284 119284 0 0.0
rodata 108332 108332 0 0.0
text 634140 634140 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 924795 924795 0 0.0
bss 116328 116328 0 0.0
rodata 100784 100784 0 0.0
text 629492 629492 0 0.0
nrf52840dongle_nrf52840 (read/write) 990007 990007 0 0.0
bss 122128 122128 0 0.0
rodata 113088 113088 0 0.0
text 666336 666336 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849186 849186 0 0.0
bss 116072 116072 0 0.0
rodata 101508 101508 0 0.0
text 551060 551060 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911599 911599 0 0.0
bss 118472 118472 0 0.0
rodata 103604 103604 0 0.0
text 612132 612132 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821638 821638 0 0.0
bss 115288 115288 0 0.0
rodata 96832 96832 0 0.0
text 529092 529092 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912879 912879 0 0.0
bss 118232 118232 0 0.0
rodata 103820 103820 0 0.0
text 613392 613392 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909679 909679 0 0.0
bss 118260 118260 0 0.0
rodata 103076 103076 0 0.0
text 610880 610880 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798439 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533880 533880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711254 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451560 451560 0 0.0
p6 all-clusters-app default (read/write) 2403272 2403272 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361536 1361536 0 0.0
light-app default (read/write) 2325144 2325144 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283408 1283408 0 0.0
lock-app default (read/write) 2297376 2297376 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255640 1255640 0 0.0
qpg lighting-app qpg6105+debug (read only) 534084 534084 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528764 528764 0 0.0
lock-app qpg6105+debug (read only) 506004 506004 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500684 500684 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835914 835914 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583782 583782 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 6c6f438 into project-chip:master Jan 12, 2022
@dhrishi
Copy link
Contributor

dhrishi commented Jan 12, 2022 •
edited
Loading

Just for the records, 2862a1a is the latest ESP-IDF upgrade in CHIP. We use the fixed release tag v4.4-beta1 instead of the moving branch release/v4.4

Having said that, it also has the fix to the required certificate issue

selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@electrocucaracha @selissia
Remove patch on ESP32 Docker img (project-chip#13474)
d0a4e52 
Signed-off-by: Victor Morales <[email protected]>
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@electrocucaracha @step0035
Remove patch on ESP32 Docker img (project-chip#13474)
02fa746 
Signed-off-by: Victor Morales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
integrations review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove this patch once https://github.com/espressif/esp-idf/pull/7632 is availab...
3 participants
@electrocucaracha @dhrishi @bzbarsky-apple