Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close exchange when session is released #13448

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Close exchange when session is released #13448

merged 2 commits into from
Jan 11, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Jan 11, 2022

Problem

Fix #13425

Change overview

Close the exchange when the associated session is released

Testing

Checked by unit-tests

@kghost kghost self-assigned this Jan 11, 2022
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13448: Size comparison from a841e21 to db3e853

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a841e21 db3e853 change % change
efr32 lighting-app BRD4161A (read only) 829972 830036 64 0.0
.text 829964 830028 64 0.0
BRD4161A+rpc (read only) 817168 817232 64 0.0
.text 817160 817224 64 0.0
window-app BRD4161A (read only) 803436 803500 64 0.0
.text 803428 803492 64 0.0
esp32 all-clusters-app c3devkit (read only) 892608 892636 28 0.0
.flash.text 892608 892636 28 0.0
m5stack (read only) 952483 952503 20 0.0
.flash.text 947099 947119 20 0.0
k32w light k32w061+release (read/write) 656148 656164 16 0.0
.text 571672 571688 16 0.0
lock k32w061+release (read/write) 660488 660504 16 0.0
.text 575696 575712 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7113292 32 0.0
.text 6025556 6025588 32 0.0
thermostat-no-ble arm64 (read only) 2036572 2036604 32 0.0
.text 1693360 1693392 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2349496 2349560 64 0.0
.text 1312072 1312136 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939003 939019 16 0.0
text 633916 633940 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 924467 924483 16 0.0
text 629268 629292 24 0.0
nrf52840dongle_nrf52840 (read/write) 989679 989695 16 0.0
text 666112 666136 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848858 848874 16 0.0
text 550836 550860 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911307 32 0.0
text 611912 611936 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821310 821342 32 0.0
text 528872 528896 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912567 912583 16 0.0
text 613172 613196 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909355 909387 32 0.0
text 610660 610684 24 0.0
shell nrf52840dk_nrf52840 (read/write) 798063 798095 32 0.0
text 533608 533632 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710914 32 0.0
text 451288 451312 24 0.0
p6 all-clusters-app default (read/write) 2402808 2402872 64 0.0
.text 1361072 1361136 64 0.0
light-app default (read/write) 2324800 2324864 64 0.0
.text 1283064 1283128 64 0.0
lock-app default (read/write) 2297024 2297088 64 0.0
.text 1255288 1255352 64 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533876 24 0.0
.text 528532 528556 24 0.0
lock-app qpg6105+debug (read only) 505772 505796 24 0.0
.text 500452 500476 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835594 32 0.0
text 583540 583570 30 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a841e21 db3e853 change % change
efr32 lighting-app BRD4161A (read only) 829972 830036 64 0.0
(read/write) 127056 127056 0 0.0
.bss 125176 125176 0 0.0
.data 1880 1880 0 0.0
.text 829964 830028 64 0.0
BRD4161A+rpc (read only) 817168 817232 64 0.0
(read/write) 143720 143720 0 0.0
.bss 141736 141736 0 0.0
.data 1980 1980 0 0.0
.text 817160 817224 64 0.0
window-app BRD4161A (read only) 803436 803500 64 0.0
(read/write) 125996 125996 0 0.0
.bss 124160 124160 0 0.0
.data 1836 1836 0 0.0
.text 803428 803492 64 0.0
esp32 all-clusters-app c3devkit (read only) 892608 892636 28 0.0
(read/write) 1314786 1314786 0 0.0
.dram0.bss 69824 69824 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 177656 177656 0 0.0
.flash.text 892608 892636 28 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 952483 952503 20 0.0
(read/write) 446360 446360 0 0.0
.dram0.bss 74304 74304 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206984 206984 0 0.0
.flash.text 947099 947119 20 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 656148 656164 16 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571672 571688 16 0.0
lock k32w061+release (read/write) 660488 660504 16 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575696 575712 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7113292 32 0.0
(read/write) 327377 327377 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209544 209544 0 0.0
.dynamic 560 560 0 0.0
.got 58184 58184 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390132 390132 0 0.0
.text 6025556 6025588 32 0.0
thermostat-no-ble arm64 (read only) 2036572 2036604 32 0.0
(read/write) 145377 145377 0 0.0
.bss 64721 64721 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72832 72832 0 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129244 129244 0 0.0
.text 1693360 1693392 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349496 2349560 64 0.0
.bss 189068 189068 0 0.0
.data 5320 5320 0 0.0
.text 1312072 1312136 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331144 2331144 0 0.0
.bss 180600 180600 0 0.0
.data 5552 5552 0 0.0
.text 1293744 1293744 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304432 2304432 0 0.0
.bss 179648 179648 0 0.0
.data 5544 5544 0 0.0
.text 1267032 1267032 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2054432 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1017032 1017032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939003 939019 16 0.0
bss 119284 119284 0 0.0
rodata 108232 108232 0 0.0
text 633916 633940 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 924467 924483 16 0.0
bss 116328 116328 0 0.0
rodata 100680 100680 0 0.0
text 629268 629292 24 0.0
nrf52840dongle_nrf52840 (read/write) 989679 989695 16 0.0
bss 122128 122128 0 0.0
rodata 112984 112984 0 0.0
text 666112 666136 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848858 848874 16 0.0
bss 116072 116072 0 0.0
rodata 101404 101404 0 0.0
text 550836 550860 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911307 32 0.0
bss 118472 118472 0 0.0
rodata 103504 103504 0 0.0
text 611912 611936 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821310 821342 32 0.0
bss 115288 115288 0 0.0
rodata 96728 96728 0 0.0
text 528872 528896 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912567 912583 16 0.0
bss 118232 118232 0 0.0
rodata 103716 103716 0 0.0
text 613172 613196 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909355 909387 32 0.0
bss 118260 118260 0 0.0
rodata 102976 102976 0 0.0
text 610660 610684 24 0.0
shell nrf52840dk_nrf52840 (read/write) 798063 798095 32 0.0
bss 109768 109768 0 0.0
rodata 78180 78180 0 0.0
text 533608 533632 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710914 32 0.0
bss 107656 107656 0 0.0
rodata 72484 72484 0 0.0
text 451288 451312 24 0.0
p6 all-clusters-app default (read/write) 2402808 2402872 64 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361072 1361136 64 0.0
light-app default (read/write) 2324800 2324864 64 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283064 1283128 64 0.0
lock-app default (read/write) 2297024 2297088 64 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255288 1255352 64 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533876 24 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528532 528556 24 0.0
lock-app qpg6105+debug (read only) 505772 505796 24 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500452 500476 24 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835594 32 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583540 583570 30 0.0

andy31415
andy31415 approved these changes Jan 11, 2022
View reviewed changes
src/messaging/ExchangeContext.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13448: Size comparison from a841e21 to 9389150

Increases above 0.2%:

platform target config section a841e21 9389150 change % change
esp32 all-clusters-app c3devkit (read only) 892608 898288 5680 0.6
.dram0.bss 69824 70168 344 0.5
.flash.rodata 177656 178160 504 0.3
.flash.text 892608 898288 5680 0.6
m5stack (read only) 952483 959399 6916 0.7
(read/write) 446360 448504 2144 0.5
.dram0.bss 74304 74656 352 0.5
.flash.rodata 206984 207656 672 0.3
.flash.text 947099 954015 6916 0.7
.iram0.text 122671 123399 728 0.6
linux thermostat-no-ble arm64 .got 4008 4032 24 0.6
Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a841e21 9389150 change % change
efr32 lighting-app BRD4161A (read only) 829972 830212 240 0.0
.text 829964 830204 240 0.0
BRD4161A+rpc (read only) 817168 817408 240 0.0
.text 817160 817400 240 0.0
window-app BRD4161A (read only) 803436 803676 240 0.0
.text 803428 803668 240 0.0
esp32 all-clusters-app c3devkit (read only) 892608 898288 5680 0.6
(read/write) 1314786 1316042 1256 0.1
.dram0.bss 69824 70168 344 0.5
.flash.rodata 177656 178160 504 0.3
.flash.text 892608 898288 5680 0.6
m5stack (read only) 952483 959399 6916 0.7
(read/write) 446360 448504 2144 0.5
.dram0.bss 74304 74656 352 0.5
.flash.rodata 206984 207656 672 0.3
.flash.text 947099 954015 6916 0.7
.iram0.text 122671 123399 728 0.6
k32w light k32w061+release (read/write) 656148 656292 144 0.0
.text 571672 571816 144 0.0
lock k32w061+release (read/write) 660488 660632 144 0.0
.text 575696 575840 144 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7113820 560 0.0
(read/write) 327377 327457 80 0.0
.data.rel.ro 209544 209608 64 0.0
.got 58184 58200 16 0.0
.rodata 390132 390148 16 0.0
.text 6025556 6025860 304 0.0
thermostat-no-ble arm64 (read only) 2036572 2037244 672 0.0
(read/write) 145377 145489 112 0.1
.bss 64721 64737 16 0.0
.data.rel.ro 72832 72896 64 0.1
.got 4008 4032 24 0.6
.rodata 129244 129276 32 0.0
.text 1693360 1693744 384 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2349496 2349776 280 0.0
.text 1312072 1312352 280 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2331144 2331288 144 0.0
.text 1293744 1293888 144 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304432 2304576 144 0.0
.text 1267032 1267176 144 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054432 2055088 656 0.0
.bss 157060 157068 8 0.0
.text 1017032 1017688 656 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939003 939211 208 0.0
rodata 108232 108296 64 0.1
text 633916 634060 144 0.0
nrf52840dk_nrf52840+rpc (read/write) 924467 924675 208 0.0
rodata 100680 100744 64 0.1
text 629268 629416 148 0.0
nrf52840dongle_nrf52840 (read/write) 989679 989887 208 0.0
rodata 112984 113048 64 0.1
text 666112 666260 148 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848858 849066 208 0.0
rodata 101404 101468 64 0.1
text 550836 550984 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911483 208 0.0
rodata 103504 103568 64 0.1
text 611912 612056 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821310 821518 208 0.0
rodata 96728 96792 64 0.1
text 528872 529020 148 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912567 912775 208 0.0
rodata 103716 103780 64 0.1
text 613172 613316 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909355 909563 208 0.0
rodata 102976 103040 64 0.1
text 610660 610808 148 0.0
shell nrf52840dk_nrf52840 (read/write) 798063 798335 272 0.0
bss 109768 109776 8 0.0
rodata 78180 78244 64 0.1
text 533608 533812 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 711154 272 0.0
bss 107656 107664 8 0.0
rodata 72484 72548 64 0.1
text 451288 451488 200 0.0
p6 all-clusters-app default (read/write) 2402808 2403152 344 0.0
.text 1361072 1361416 344 0.0
light-app default (read/write) 2324800 2325064 264 0.0
.text 1283064 1283328 264 0.0
lock-app default (read/write) 2297024 2297272 248 0.0
.text 1255288 1255536 248 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533988 136 0.0
.text 528532 528668 136 0.0
lock-app qpg6105+debug (read only) 505772 505908 136 0.0
.text 500452 500588 136 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835814 252 0.0
text 583540 583728 188 0.0
Decreases (1 build for esp32)
platform target config section a841e21 9389150 change % change
esp32 all-clusters-app c3devkit .dram0.data 14244 14212 -32 -0.2
.iram0.text 62254 62056 -198 -0.3
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a841e21 9389150 change % change
efr32 lighting-app BRD4161A (read only) 829972 830212 240 0.0
(read/write) 127056 127056 0 0.0
.bss 125176 125176 0 0.0
.data 1880 1880 0 0.0
.text 829964 830204 240 0.0
BRD4161A+rpc (read only) 817168 817408 240 0.0
(read/write) 143720 143720 0 0.0
.bss 141736 141736 0 0.0
.data 1980 1980 0 0.0
.text 817160 817400 240 0.0
window-app BRD4161A (read only) 803436 803676 240 0.0
(read/write) 125996 125996 0 0.0
.bss 124160 124160 0 0.0
.data 1836 1836 0 0.0
.text 803428 803668 240 0.0
esp32 all-clusters-app c3devkit (read only) 892608 898288 5680 0.6
(read/write) 1314786 1316042 1256 0.1
.dram0.bss 69824 70168 344 0.5
.dram0.data 14244 14212 -32 -0.2
.flash.rodata 177656 178160 504 0.3
.flash.text 892608 898288 5680 0.6
.iram0.text 62254 62056 -198 -0.3
m5stack (read only) 952483 959399 6916 0.7
(read/write) 446360 448504 2144 0.5
.dram0.bss 74304 74656 352 0.5
.dram0.data 34064 34064 0 0.0
.flash.rodata 206984 207656 672 0.3
.flash.text 947099 954015 6916 0.7
.iram0.text 122671 123399 728 0.6
k32w light k32w061+release (read/write) 656148 656292 144 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571672 571816 144 0.0
lock k32w061+release (read/write) 660488 660632 144 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575696 575840 144 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7113820 560 0.0
(read/write) 327377 327457 80 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209544 209608 64 0.0
.dynamic 560 560 0 0.0
.got 58184 58200 16 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390132 390148 16 0.0
.text 6025556 6025860 304 0.0
thermostat-no-ble arm64 (read only) 2036572 2037244 672 0.0
(read/write) 145377 145489 112 0.1
.bss 64721 64737 16 0.0
.data 880 880 0 0.0
.data.rel.ro 72832 72896 64 0.1
.dynamic 560 560 0 0.0
.got 4008 4032 24 0.6
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129244 129276 32 0.0
.text 1693360 1693744 384 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349496 2349776 280 0.0
.bss 189068 189068 0 0.0
.data 5320 5320 0 0.0
.text 1312072 1312352 280 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331144 2331288 144 0.0
.bss 180600 180600 0 0.0
.data 5552 5552 0 0.0
.text 1293744 1293888 144 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304432 2304576 144 0.0
.bss 179648 179648 0 0.0
.data 5544 5544 0 0.0
.text 1267032 1267176 144 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2055088 656 0.0
.bss 157060 157068 8 0.0
.data 4864 4864 0 0.0
.text 1017032 1017688 656 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939003 939211 208 0.0
bss 119284 119284 0 0.0
rodata 108232 108296 64 0.1
text 633916 634060 144 0.0
nrf52840dk_nrf52840+rpc (read/write) 924467 924675 208 0.0
bss 116328 116328 0 0.0
rodata 100680 100744 64 0.1
text 629268 629416 148 0.0
nrf52840dongle_nrf52840 (read/write) 989679 989887 208 0.0
bss 122128 122128 0 0.0
rodata 112984 113048 64 0.1
text 666112 666260 148 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848858 849066 208 0.0
bss 116072 116072 0 0.0
rodata 101404 101468 64 0.1
text 550836 550984 148 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911483 208 0.0
bss 118472 118472 0 0.0
rodata 103504 103568 64 0.1
text 611912 612056 144 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821310 821518 208 0.0
bss 115288 115288 0 0.0
rodata 96728 96792 64 0.1
text 528872 529020 148 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912567 912775 208 0.0
bss 118232 118232 0 0.0
rodata 103716 103780 64 0.1
text 613172 613316 144 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909355 909563 208 0.0
bss 118260 118260 0 0.0
rodata 102976 103040 64 0.1
text 610660 610808 148 0.0
shell nrf52840dk_nrf52840 (read/write) 798063 798335 272 0.0
bss 109768 109776 8 0.0
rodata 78180 78244 64 0.1
text 533608 533812 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 711154 272 0.0
bss 107656 107664 8 0.0
rodata 72484 72548 64 0.1
text 451288 451488 200 0.0
p6 all-clusters-app default (read/write) 2402808 2403152 344 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361072 1361416 344 0.0
light-app default (read/write) 2324800 2325064 264 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283064 1283328 264 0.0
lock-app default (read/write) 2297024 2297272 248 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255288 1255536 248 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533988 136 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528532 528668 136 0.0
lock-app qpg6105+debug (read only) 505772 505908 136 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500452 500588 136 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835814 252 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583540 583728 188 0.0

@andy31415
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13448: Size comparison from 68df85c to 80e08de

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 68df85c 80e08de change % change
efr32 lighting-app BRD4161A (read only) 830256 830320 64 0.0
.text 830248 830312 64 0.0
BRD4161A+rpc (read only) 817660 817724 64 0.0
.text 817652 817716 64 0.0
window-app BRD4161A (read only) 804200 804264 64 0.0
.text 804192 804256 64 0.0
esp32 all-clusters-app c3devkit (read only) 898316 898344 28 0.0
.flash.text 898316 898344 28 0.0
m5stack (read only) 959427 959459 32 0.0
.flash.text 954043 954075 32 0.0
k32w light k32w061+release (read/write) 656380 656396 16 0.0
.text 571904 571920 16 0.0
lock k32w061+release (read/write) 660720 660736 16 0.0
.text 575928 575944 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7114060 7114092 32 0.0
.text 6026020 6026052 32 0.0
thermostat-no-ble arm64 (read only) 2037468 2037500 32 0.0
.text 1693888 1693920 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348912 2348976 64 0.0
.text 1311488 1311552 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939295 939327 32 0.0
text 634112 634136 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 924763 924795 32 0.0
text 629464 629488 24 0.0
nrf52840dongle_nrf52840 (read/write) 989971 989987 16 0.0
text 666308 666332 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849154 849186 32 0.0
text 551032 551056 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911567 911599 32 0.0
text 612104 612128 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821606 821638 32 0.0
text 529064 529088 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912863 912879 16 0.0
text 613364 613388 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909647 909679 32 0.0
text 610852 610876 24 0.0
shell nrf52840dk_nrf52840 (read/write) 798423 798439 16 0.0
text 533856 533880 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711238 711254 16 0.0
text 451536 451560 24 0.0
p6 all-clusters-app default (read/write) 2403200 2403264 64 0.0
.text 1361464 1361528 64 0.0
light-app default (read/write) 2325088 2325152 64 0.0
.text 1283352 1283416 64 0.0
lock-app default (read/write) 2297320 2297384 64 0.0
.text 1255584 1255648 64 0.0
qpg lighting-app qpg6105+debug (read only) 534060 534084 24 0.0
.text 528740 528764 24 0.0
lock-app qpg6105+debug (read only) 505980 506004 24 0.0
.text 500660 500684 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 835910 32 0.0
text 583752 583782 30 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 68df85c 80e08de change % change
efr32 lighting-app BRD4161A (read only) 830256 830320 64 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830248 830312 64 0.0
BRD4161A+rpc (read only) 817660 817724 64 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817652 817716 64 0.0
window-app BRD4161A (read only) 804200 804264 64 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804192 804256 64 0.0
esp32 all-clusters-app c3devkit (read only) 898316 898344 28 0.0
(read/write) 1316082 1316082 0 0.0
.dram0.bss 70168 70168 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178200 178200 0 0.0
.flash.text 898316 898344 28 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959427 959459 32 0.0
(read/write) 448536 448536 0 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207688 207688 0 0.0
.flash.text 954043 954075 32 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656380 656396 16 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571904 571920 16 0.0
lock k32w061+release (read/write) 660720 660736 16 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575928 575944 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7114060 7114092 32 0.0
(read/write) 327473 327473 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209624 209624 0 0.0
.dynamic 560 560 0 0.0
.got 58208 58208 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390148 390148 0 0.0
.text 6026020 6026052 32 0.0
thermostat-no-ble arm64 (read only) 2037468 2037500 32 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129276 129276 0 0.0
.text 1693888 1693920 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348912 2348976 64 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1311488 1311552 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330560 2330560 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293160 1293160 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303784 2303784 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266384 1266384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939295 939327 32 0.0
bss 119284 119284 0 0.0
rodata 108332 108332 0 0.0
text 634112 634136 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 924763 924795 32 0.0
bss 116328 116328 0 0.0
rodata 100784 100784 0 0.0
text 629464 629488 24 0.0
nrf52840dongle_nrf52840 (read/write) 989971 989987 16 0.0
bss 122128 122128 0 0.0
rodata 113084 113084 0 0.0
text 666308 666332 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849154 849186 32 0.0
bss 116072 116072 0 0.0
rodata 101508 101508 0 0.0
text 551032 551056 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911567 911599 32 0.0
bss 118472 118472 0 0.0
rodata 103604 103604 0 0.0
text 612104 612128 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821606 821638 32 0.0
bss 115288 115288 0 0.0
rodata 96832 96832 0 0.0
text 529064 529088 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912863 912879 16 0.0
bss 118232 118232 0 0.0
rodata 103820 103820 0 0.0
text 613364 613388 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909647 909679 32 0.0
bss 118260 118260 0 0.0
rodata 103076 103076 0 0.0
text 610852 610876 24 0.0
shell nrf52840dk_nrf52840 (read/write) 798423 798439 16 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533856 533880 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711238 711254 16 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451536 451560 24 0.0
p6 all-clusters-app default (read/write) 2403200 2403264 64 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361464 1361528 64 0.0
light-app default (read/write) 2325088 2325152 64 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283352 1283416 64 0.0
lock-app default (read/write) 2297320 2297384 64 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255584 1255648 64 0.0
qpg lighting-app qpg6105+debug (read only) 534060 534084 24 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528740 528764 24 0.0
lock-app qpg6105+debug (read only) 505980 506004 24 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500660 500684 24 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 835910 32 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583752 583782 30 0.0

@andy31415 andy31415 merged commit f334c27 into project-chip:master Jan 11, 2022
@kghost kghost deleted the session-crash branch January 12, 2022 01:59
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 13, 2022
@kghost @andy31415 @selissia
Close exchange when session is released (project-chip#13448)
b3c09d8 
* Close exchange when session is released

* Add clearRetransTable parameter to DoClose call

Co-authored-by: Andrei Litvin <[email protected]>
@selissia selissia mentioned this pull request Jan 13, 2022
Merged
woody-apple pushed a commit that referenced this pull request Jan 13, 2022
@selissia @kghost
@andy31415 @restyled-commits
[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the…
6183d8a 
… image (#13499)

* Code for testing bootloader integration

* Add bootloader API calls

* Add the rest of booloader calls to EFR32 OTA Requestor

* Call the OTARequestor Init() method

* Use correct booloader API

* Close exchange when session is released (#13448)

* Close exchange when session is released

* Add clearRetransTable parameter to DoClose call

Co-authored-by: Andrei Litvin <[email protected]>

* Clean up comments and debug code

* Restyled by whitespace

* Restyled by clang-format

Co-authored-by: Zang MingJie <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 25, 2022
Closed
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@kghost @andy31415 @selissia
Close exchange when session is released (project-chip#13448)
24a3513 
* Close exchange when session is released

* Add clearRetransTable parameter to DoClose call

Co-authored-by: Andrei Litvin <[email protected]>
selissia added a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@selissia @kghost
@andy31415 @restyled-commits
[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the…
3ae22c3 
… image (project-chip#13499)

* Code for testing bootloader integration

* Add bootloader API calls

* Add the rest of booloader calls to EFR32 OTA Requestor

* Call the OTARequestor Init() method

* Use correct booloader API

* Close exchange when session is released (project-chip#13448)

* Close exchange when session is released

* Add clearRetransTable parameter to DoClose call

Co-authored-by: Andrei Litvin <[email protected]>

* Clean up comments and debug code

* Restyled by whitespace

* Restyled by clang-format

Co-authored-by: Zang MingJie <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@kghost @andy31415 @step0035
Close exchange when session is released (project-chip#13448)
dd4dd59 
* Close exchange when session is released

* Add clearRetransTable parameter to DoClose call

Co-authored-by: Andrei Litvin <[email protected]>
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@selissia @kghost
@andy31415 @restyled-commits @step0035
[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the…
104b434 
… image (project-chip#13499)

* Code for testing bootloader integration

* Add bootloader API calls

* Add the rest of booloader calls to EFR32 OTA Requestor

* Call the OTARequestor Init() method

* Use correct booloader API

* Close exchange when session is released (project-chip#13448)

* Close exchange when session is released

* Add clearRetransTable parameter to DoClose call

Co-authored-by: Andrei Litvin <[email protected]>

* Clean up comments and debug code

* Restyled by whitespace

* Restyled by clang-format

Co-authored-by: Zang MingJie <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
This was referenced Jun 9, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@turon turon turon approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@kghost kghost

Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash due to failing assert in SessionHolder::Get
5 participants
@kghost @andy31415 @turon @msandstedt @jepenven-silabs