-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Automatically add simulated clusters from the clusters directo… #13299
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_SimulatedClustersAutoRegistration
Jan 5, 2022
Merged
[YAML] Automatically add simulated clusters from the clusters directo… #13299
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_SimulatedClustersAutoRegistration
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple and
saurabhst
January 3, 2022 15:40
pullapprove
bot
requested review from
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 3, 2022 15:40
…ry into the list of clusters used for test generation instead of manually adding them one by one at the top of SimulatedClusters.js
vivien-apple
force-pushed
the
YAML_SimulatedClustersAutoRegistration
branch
from
January 4, 2022 09:08
b213633
to
18f36b6
Compare
PR #13299: Size comparison from b0af6ba to 18f36b6 Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 4, 2022
jmeg-sfy
approved these changes
Jan 4, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…ry into the list of clusters used for test generation instead of manually adding them one by one at the top of SimulatedClusters.js (project-chip#13299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry into the list of clusters used for test generation instead of manually adding them one by one at the top of SimulatedClusters.js
Problem
"Simulated" clusters needs to be added manually to
SimulatedClusters.js
. It can be done automatically.Change overview
clusters
subfolder.Testing
I did regenerate tests to validate that it works and observe no difference in the generated code.