Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fix OTA application READMEs #13152

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[ESP32] Fix OTA application READMEs #13152

merged 1 commit into from
Dec 21, 2021

Conversation

shubhamdp
Copy link
Contributor

Change overview

Fixed the command and some description in ESP32 OTA Requestor and Provider READMEs.

Testing

Carried tests with ESP32 OTA requestor and provider with commands in READMEs.

@shubhamdp shubhamdp force-pushed the esp32_ota_app_readme_fixups branch from 384431e to 0e61c23 Compare December 20, 2021 05:19
@boring-cyborg boring-cyborg bot added the github label Dec 20, 2021
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

PR #13152: Size comparison from 6a08b04 to 0e61c23

Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 6a08b04 0e61c23 change % change
efr32 lighting-app BRD4161A (read only) 830408 830408 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830400 830400 0 0.0
BRD4161A+rpc (read only) 818052 818052 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818044 818044 0 0.0
window-app BRD4161A (read only) 803784 803784 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803776 803776 0 0.0
k32w light k32w061+release (read/write) 648740 648740 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633456 633456 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979164 6979164 0 0.0
(read/write) 325633 325633 0 0.0
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 209704 0 0.0
.dynamic 560 560 0 0.0
.got 56536 56536 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383732 383732 0 0.0
.text 5903540 5903540 0 0.0
thermostat-no-ble arm64 (read only) 2002756 2002756 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1662736 1662736 0 0.0
p6 all-clusters-app default (read/write) 2389080 2389080 0 0.0
.bss 116780 116780 0 0.0
.data 2544 2544 0 0.0
.text 1347344 1347344 0 0.0
light-app default (read/write) 2324944 2324944 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283208 1283208 0 0.0
lock-app default (read/write) 2297152 2297152 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255416 1255416 0 0.0
qpg lighting-app qpg6105+debug (read only) 532240 532240 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 526920 526920 0 0.0
lock-app qpg6105+debug (read only) 503904 503904 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498584 498584 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 832258 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580384 580384 0 0.0

@shubhamdp
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the esp32_ota_app_readme_fixups branch from 0e61c23 to 6527848 Compare December 20, 2021 06:30
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

PR #13152: Size comparison from 6a08b04 to 6527848

Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6a08b04 6527848 change % change
efr32 lighting-app BRD4161A (read only) 830408 830408 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830400 830400 0 0.0
BRD4161A+rpc (read only) 818052 818052 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818044 818044 0 0.0
window-app BRD4161A (read only) 803784 803784 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803776 803776 0 0.0
esp32 all-clusters-app c3devkit (read only) 881120 881120 0 0.0
(read/write) 1312402 1312402 0 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175832 0 0.0
.flash.text 881120 881120 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941647 941647 0 0.0
(read/write) 441516 441516 0 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202660 0 0.0
.flash.text 936263 936263 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648740 648740 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633456 633456 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979164 6979164 0 0.0
(read/write) 325633 325633 0 0.0
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 209704 0 0.0
.dynamic 560 560 0 0.0
.got 56536 56536 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383732 383732 0 0.0
.text 5903540 5903540 0 0.0
thermostat-no-ble arm64 (read only) 2002756 2002756 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1662736 1662736 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337664 2337664 0 0.0
.bss 188580 188580 0 0.0
.data 5264 5264 0 0.0
.text 1300240 1300240 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330568 2330568 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293168 1293168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303664 2303664 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266264 1266264 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935999 935999 0 0.0
bss 118408 118408 0 0.0
rodata 108124 108124 0 0.0
text 631884 631884 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922351 922351 0 0.0
bss 115452 115452 0 0.0
rodata 101540 101540 0 0.0
text 627196 627196 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859714 859714 0 0.0
bss 116692 116692 0 0.0
rodata 103048 103048 0 0.0
text 559324 559324 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908095 908095 0 0.0
bss 117596 117596 0 0.0
rodata 103428 103428 0 0.0
text 609708 609708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832058 832058 0 0.0
bss 115908 115908 0 0.0
rodata 98392 98392 0 0.0
text 537192 537192 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909391 909391 0 0.0
bss 117356 117356 0 0.0
rodata 103644 103644 0 0.0
text 610948 610948 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906207 906207 0 0.0
bss 117384 117384 0 0.0
rodata 102900 102900 0 0.0
text 608456 608456 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2389080 2389080 0 0.0
.bss 116780 116780 0 0.0
.data 2544 2544 0 0.0
.text 1347344 1347344 0 0.0
light-app default (read/write) 2324944 2324944 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283208 1283208 0 0.0
lock-app default (read/write) 2297152 2297152 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255416 1255416 0 0.0
qpg lighting-app qpg6105+debug (read only) 532240 532240 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 526920 526920 0 0.0
lock-app qpg6105+debug (read only) 503904 503904 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498584 498584 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 832258 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580384 580384 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the esp32_ota_app_readme_fixups branch from 6527848 to 7556e4e Compare December 20, 2021 19:39
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

PR #13152: Size comparison from 660a290 to 7556e4e

Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 660a290 7556e4e change % change
efr32 lighting-app BRD4161A (read only) 830568 830568 0 0.0
(read/write) 127384 127384 0 0.0
.bss 125504 125504 0 0.0
.data 1876 1876 0 0.0
.text 830560 830560 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144048 144048 0 0.0
.bss 142072 142072 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803944 803944 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124488 124488 0 0.0
.data 1832 1832 0 0.0
.text 803936 803936 0 0.0
k32w light k32w061+release (read/write) 648764 648764 0 0.0
.bss 76512 76512 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633472 633472 0 0.0
.bss 76224 76224 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7005564 7005564 0 0.0
(read/write) 326241 326241 0 0.0
.bss 54609 54609 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210144 210144 0 0.0
.dynamic 560 560 0 0.0
.got 56696 56696 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384228 0 0.0
.text 5928084 5928084 0 0.0
thermostat-no-ble arm64 (read only) 2002916 2002916 0 0.0
(read/write) 144081 144081 0 0.0
.bss 64369 64369 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1662896 1662896 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339832 2339832 0 0.0
.bss 188596 188596 0 0.0
.data 5272 5272 0 0.0
.text 1302408 1302408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330568 2330568 0 0.0
.bss 180936 180936 0 0.0
.data 5552 5552 0 0.0
.text 1293168 1293168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303664 2303664 0 0.0
.bss 179984 179984 0 0.0
.data 5544 5544 0 0.0
.text 1266264 1266264 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 935967 0 0.0
bss 118428 118428 0 0.0
rodata 108124 108124 0 0.0
text 631864 631864 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922367 922367 0 0.0
bss 115472 115472 0 0.0
rodata 101540 101540 0 0.0
text 627176 627176 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859730 859730 0 0.0
bss 116712 116712 0 0.0
rodata 103048 103048 0 0.0
text 559308 559308 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908111 908111 0 0.0
bss 117616 117616 0 0.0
rodata 103428 103428 0 0.0
text 609692 609692 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832042 832042 0 0.0
bss 115928 115928 0 0.0
rodata 98392 98392 0 0.0
text 537172 537172 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909375 909375 0 0.0
bss 117376 117376 0 0.0
rodata 103644 103644 0 0.0
text 610928 610928 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 906191 0 0.0
bss 117404 117404 0 0.0
rodata 102900 102900 0 0.0
text 608440 608440 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2391824 2391824 0 0.0
.bss 116804 116804 0 0.0
.data 2552 2552 0 0.0
.text 1350088 1350088 0 0.0
light-app default (read/write) 2325104 2325104 0 0.0
.bss 106184 106184 0 0.0
.data 2384 2384 0 0.0
.text 1283368 1283368 0 0.0
lock-app default (read/write) 2297312 2297312 0 0.0
.bss 105064 105064 0 0.0
.data 2336 2336 0 0.0
.text 1255576 1255576 0 0.0
qpg lighting-app qpg6105+debug (read only) 532248 532248 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86840 86840 0 0.0
.data 1004 1004 0 0.0
.text 526928 526928 0 0.0
lock-app qpg6105+debug (read only) 503912 503912 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85976 85976 0 0.0
.data 952 952 0 0.0
.text 498592 498592 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 832258 0 0.0
bss 87088 87088 0 0.0
noinit 37160 37160 0 0.0
text 580366 580366 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit bf7feea into project-chip:master Dec 21, 2021
@shubhamdp shubhamdp deleted the esp32_ota_app_readme_fixups branch December 22, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@gjc13 gjc13 gjc13 approved these changes

@dhrishi dhrishi dhrishi approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shubhamdp @bzbarsky-apple @msandstedt @dhrishi @gjc13