-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TestCluster] Test cluster use negative defaults for ints types #13117
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:TestCluster_UseNegativeDefaultsForIntsTypes
Dec 26, 2021
Merged
[TestCluster] Test cluster use negative defaults for ints types #13117
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:TestCluster_UseNegativeDefaultsForIntsTypes
Dec 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02 and
mrjerryjohns
December 17, 2021 11:51
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 17, 2021 11:51
PR #13117: Size comparison from a9b9fca to 12e2394 Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 17, 2021
bzbarsky-apple
approved these changes
Dec 18, 2021
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some of the tests for reading attributes from
TestCluster
were expecting negative defaults. Not that ZAP has been updated this is possible.Change overview
# ZAP won't allow setting a negative default!
insrc/app/tests/suites
and use the ZAP UI to use defaults for the linked attributes for theall-clusters-app
Testing
Tests are green after everything has been regenerated.