Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClusterRevision value for Basic Info #13068

Merged

Conversation

lzgrablic02
Copy link
Contributor

Problem

  • Basic Information Cluster ClusterRevision did not match spec

Change overview

Change value for ClusterRevision of Basic Information Cluster

Testing

  • None

@github-actions
Copy link

github-actions bot commented Dec 16, 2021

PR #13068: Size comparison from 5988375 to 5644bf6

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5988375 5644bf6 change % change
efr32 lighting-app BRD4161A (read only) 835684 835684 0 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835676 835676 0 0.0
BRD4161A+rpc (read only) 823304 823304 0 0.0
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823296 823296 0 0.0
window-app BRD4161A (read only) 809060 809060 0 0.0
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809052 809052 0 0.0
esp32 all-clusters-app c3devkit (read only) 876694 876694 0 0.0
(read/write) 1312954 1312954 0 0.0
.dram0.bss 69776 69776 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 175920 175920 0 0.0
.flash.text 876694 876694 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962575 962575 0 0.0
(read/write) 453688 453688 0 0.0
.dram0.bss 76096 76096 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 211748 211748 0 0.0
.flash.text 957191 957191 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 686396 686396 0 0.0
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600664 600664 0 0.0
lock-app k32w061+debug (read/write) 633960 633960 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550124 550124 0 0.0
shell k32w061+debug (read/write) 639688 639688 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553364 553364 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6929412 6929412 0 0.0
(read/write) 323377 323377 0 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208016 208016 0 0.0
.dynamic 560 560 0 0.0
.got 55992 55992 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 378356 378356 0 0.0
.text 5864180 5864180 0 0.0
thermostat-no-ble arm64 (read only) 1993972 1993972 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654592 1654592 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334696 2334696 0 0.0
.bss 189044 189044 0 0.0
.data 5264 5264 0 0.0
.text 1297272 1297272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329280 2329280 0 0.0
.bss 180872 180872 0 0.0
.data 5544 5544 0 0.0
.text 1291880 1291880 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302376 2302376 0 0.0
.bss 179920 179920 0 0.0
.data 5536 5536 0 0.0
.text 1264976 1264976 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936531 936531 0 0.0
bss 118376 118376 0 0.0
rodata 107952 107952 0 0.0
text 632628 632628 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 918483 918483 0 0.0
bss 114708 114708 0 0.0
rodata 99864 99864 0 0.0
text 625764 625764 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860246 860246 0 0.0
bss 116660 116660 0 0.0
rodata 102876 102876 0 0.0
text 560064 560064 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908627 908627 0 0.0
bss 117564 117564 0 0.0
rodata 103256 103256 0 0.0
text 610444 610444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832574 832574 0 0.0
bss 115876 115876 0 0.0
rodata 98220 98220 0 0.0
text 537920 537920 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913507 913507 0 0.0
bss 117472 117472 0 0.0
rodata 104600 104600 0 0.0
text 613996 613996 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906739 906739 0 0.0
bss 117352 117352 0 0.0
rodata 102728 102728 0 0.0
text 609192 609192 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796959 796959 0 0.0
bss 109472 109472 0 0.0
rodata 78032 78032 0 0.0
text 532996 532996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709594 709594 0 0.0
bss 107360 107360 0 0.0
rodata 72336 72336 0 0.0
text 450484 450484 0 0.0
p6 all-clusters-app default (read/write) 2390552 2390552 0 0.0
.bss 117236 117236 0 0.0
.data 2544 2544 0 0.0
.text 1348816 1348816 0 0.0
light-app default (read/write) 2329936 2329936 0 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.text 1288200 1288200 0 0.0
lock-app default (read/write) 2302144 2302144 0 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.text 1260408 1260408 0 0.0
qpg lighting-app qpg6105+debug (read only) 532752 532752 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527432 527432 0 0.0
lock-app qpg6105+debug (read only) 504424 504424 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499104 499104 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831078 831078 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579390 579390 0 0.0

@andy31415 andy31415 merged commit 9ed7c0c into project-chip:master Dec 16, 2021
@lzgrablic02 lzgrablic02 deleted the basic-info-cluster-revision branch December 20, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants