Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Size reports] Remove .heap section from reports #13056

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

For platforms that use it, the .heap section indicates memory
available for the heap, that is, RAM not otherwise in use.
Including it in size reports is confusing because a .heap increase
is good.

Change overview

Remove .heap from the default section list of the platforms
where it currently appears, namely Mbed and P6.

Testing

Manually checked on a P6 binary.

#### Problem

For platforms that use it, the `.heap` section indicates memory
available for the heap, that is, RAM not otherwise in use.
Including it in size reports is confusing because a `.heap` increase
is good.

#### Change overview

Remove `.heap` from the default section list of the platforms
where it currently appears, namely Mbed and P6.

#### Testing

Manually checked on a P6 binary.
@github-actions
Copy link

github-actions bot commented Dec 15, 2021

PR #13056: Size comparison from 32370de to 1360231

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 32370de4 1360231 change % change
efr32 lighting-app BRD4161A (read only) 836360 836360 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125696 125696 0 0.0
.data 1876 1876 0 0.0
.text 836352 836352 0 0.0
BRD4161A+rpc (read only) 823964 823964 0 0.0
(read/write) 144248 144248 0 0.0
.bss 142272 142272 0 0.0
.data 1976 1976 0 0.0
.text 823956 823956 0 0.0
window-app BRD4161A (read only) 809720 809720 0 0.0
(read/write) 126512 126512 0 0.0
.bss 124680 124680 0 0.0
.data 1832 1832 0 0.0
.text 809712 809712 0 0.0
esp32 all-clusters-app c3devkit (read only) 876682 876682 0 0.0
(read/write) 1313026 1313026 0 0.0
.dram0.bss 70016 70016 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 175776 175776 0 0.0
.flash.text 876682 876682 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962507 962507 0 0.0
(read/write) 453784 453784 0 0.0
.dram0.bss 76344 76344 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 211596 211596 0 0.0
.flash.text 957123 957123 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 687048 687048 0 0.0
.bss 78280 78280 0 0.0
.data 1908 1908 0 0.0
.text 601060 601060 0 0.0
lock-app k32w061+debug (read/write) 634612 634612 0 0.0
.bss 76432 76432 0 0.0
.data 1860 1860 0 0.0
.text 550520 550520 0 0.0
shell k32w061+debug (read/write) 640016 640016 0 0.0
.bss 78740 78740 0 0.0
.data 1840 1840 0 0.0
.text 553636 553636 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6911396 6911396 0 0.0
(read/write) 323201 323201 0 0.0
.bss 54833 54833 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 207704 207704 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 377636 377636 0 0.0
.text 5847812 5847812 0 0.0
thermostat-no-ble arm64 (read only) 1994756 1994756 0 0.0
(read/write) 144113 144113 0 0.0
.bss 64577 64577 0 0.0
.data 832 832 0 0.0
.data.rel.ro 71976 71976 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127924 127924 0 0.0
.text 1655456 1655456 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334344 2334344 0 0.0
.bss 189268 189268 0 0.0
.data 5256 5256 0 0.0
.text 1296920 1296920 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329840 2329840 0 0.0
.bss 181128 181128 0 0.0
.data 5544 5544 0 0.0
.text 1292440 1292440 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302936 2302936 0 0.0
.bss 180168 180168 0 0.0
.data 5536 5536 0 0.0
.text 1265536 1265536 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 922923 922923 0 0.0
bss 118788 118788 0 0.0
rodata 104292 104292 0 0.0
text 624212 624212 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 885963 885963 0 0.0
bss 115140 115140 0 0.0
rodata 95588 95588 0 0.0
text 598952 598952 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848934 848934 0 0.0
bss 120164 120164 0 0.0
rodata 99552 99552 0 0.0
text 554652 554652 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 894963 894963 0 0.0
bss 117968 117968 0 0.0
rodata 99604 99604 0 0.0
text 601980 601980 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821234 821234 0 0.0
bss 119376 119376 0 0.0
rodata 94892 94892 0 0.0
text 532512 532512 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 899915 899915 0 0.0
bss 117880 117880 0 0.0
rodata 100956 100956 0 0.0
text 605584 605584 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 893123 893123 0 0.0
bss 117760 117760 0 0.0
rodata 99092 99092 0 0.0
text 600780 600780 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2390368 2390368 0 0.0
.bss 117468 117468 0 0.0
.data 2536 2536 0 0.0
.text 1348632 1348632 0 0.0
light-app default (read/write) 2330680 2330680 0 0.0
.bss 106384 106384 0 0.0
.data 2384 2384 0 0.0
.text 1288944 1288944 0 0.0
lock-app default (read/write) 2302896 2302896 0 0.0
.bss 105264 105264 0 0.0
.data 2336 2336 0 0.0
.text 1261160 1261160 0 0.0
qpg lighting-app qpg6105+debug (read only) 533100 533100 0 0.0
(read/write) 146936 146936 0 0.0
.bss 87032 87032 0 0.0
.data 1004 1004 0 0.0
.text 527780 527780 0 0.0
lock-app qpg6105+debug (read only) 504788 504788 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86168 86168 0 0.0
.data 952 952 0 0.0
.text 499468 499468 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831922 831922 0 0.0
bss 87272 87272 0 0.0
noinit 37160 37160 0 0.0
text 579974 579974 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-track: tooling change.

@bzbarsky-apple bzbarsky-apple merged commit e1986bc into project-chip:master Dec 15, 2021
@kpschoedel kpschoedel deleted the nubloat-17 branch December 16, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants