Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Data Provider: Added method to remove GroupInfo by GroupId. #12950

Conversation

rcasallas-silabs
Copy link
Contributor

Problem

Missing function to remove a group given by group id.

Change overview

  • Added method to remove a group given the group id.
  • Unit test modified to cover the new function.

Testing

  • Unit tests run successfully.

@github-actions
Copy link

github-actions bot commented Dec 13, 2021

PR #12950: Size comparison from 73776ef to 481545c

Increases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 73776ef 481545c change % change
efr32 lighting-app BRD4161A (read only) 815948 816036 88 0.0
.text 815940 816028 88 0.0
BRD4161A+rpc (read only) 803580 803668 88 0.0
.text 803572 803660 88 0.0
window-app BRD4161A (read only) 793008 793096 88 0.0
.text 793000 793088 88 0.0
esp32 all-clusters-app c3devkit (read only) 857188 857272 84 0.0
.flash.text 857188 857272 84 0.0
m5stack (read only) 961251 961335 84 0.0
(read/write) 450260 450268 8 0.0
.flash.rodata 210440 210448 8 0.0
.flash.text 955867 955951 84 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670476 68 0.0
.text 588840 588908 68 0.0
lock-app k32w061+debug (read/write) 620344 620412 68 0.0
.text 540664 540732 68 0.0
shell k32w061+debug (read/write) 625712 625796 84 0.0
.text 543744 543828 84 0.0
linux chip-tool-ipv6only arm64 (read only) 6873564 6873964 400 0.0
(read/write) 319201 319217 16 0.0
.data.rel.ro 208784 208800 16 0.0
.text 5826788 5827140 352 0.0
thermostat-no-ble arm64 (read only) 1954660 1955060 400 0.0
(read/write) 137537 137553 16 0.0
.data.rel.ro 70600 70616 16 0.0
.text 1620512 1620864 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314032 2314104 72 0.0
.text 1276608 1276680 72 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309888 2309952 64 0.0
.text 1272488 1272552 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2283000 2283064 64 0.0
.text 1245600 1245664 64 0.0
p6 all-clusters-app default (read/write) 2360976 2361064 88 0.0
.text 1319240 1319328 88 0.0
light-app default (read/write) 2301568 2301656 88 0.0
.text 1259832 1259920 88 0.0
lock-app default (read/write) 2277640 2277728 88 0.0
.text 1235904 1235992 88 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522236 76 0.0
.text 516840 516916 76 0.0
lock-app qpg6100+debug (read only) 496532 496608 76 0.0
.text 491212 491288 76 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812354 92 0.0
text 567218 567302 84 0.0
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 73776ef 481545c change % change
efr32 lighting-app BRD4161A (read only) 815948 816036 88 0.0
(read/write) 123152 123152 0 0.0
.bss 121288 121288 0 0.0
.data 1864 1864 0 0.0
.text 815940 816028 88 0.0
BRD4161A+rpc (read only) 803580 803668 88 0.0
(read/write) 139828 139828 0 0.0
.bss 137864 137864 0 0.0
.data 1964 1964 0 0.0
.text 803572 803660 88 0.0
window-app BRD4161A (read only) 793008 793096 88 0.0
(read/write) 122104 122104 0 0.0
.bss 120272 120272 0 0.0
.data 1828 1828 0 0.0
.text 793000 793088 88 0.0
esp32 all-clusters-app c3devkit (read only) 857188 857272 84 0.0
(read/write) 1304450 1304450 0 0.0
.dram0.bss 64696 64696 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172544 172544 0 0.0
.flash.text 857188 857272 84 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961251 961335 84 0.0
(read/write) 450260 450268 8 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210440 210448 8 0.0
.flash.text 955867 955951 84 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670476 68 0.0
.bss 73872 73872 0 0.0
.data 1896 1896 0 0.0
.text 588840 588908 68 0.0
lock-app k32w061+debug (read/write) 620344 620412 68 0.0
.bss 72024 72024 0 0.0
.data 1856 1856 0 0.0
.text 540664 540732 68 0.0
shell k32w061+debug (read/write) 625712 625796 84 0.0
.bss 74332 74332 0 0.0
.data 1836 1836 0 0.0
.text 543744 543828 84 0.0
linux chip-tool-ipv6only arm64 (read only) 6873564 6873964 400 0.0
(read/write) 319201 319217 16 0.0
.bss 51921 51921 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208784 208800 16 0.0
.dynamic 560 560 0 0.0
.got 53576 53576 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365692 365692 0 0.0
.text 5826788 5827140 352 0.0
thermostat-no-ble arm64 (read only) 1954660 1955060 400 0.0
(read/write) 137537 137553 16 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70600 70616 16 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125796 0 0.0
.text 1620512 1620864 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314032 2314104 72 0.0
.bss 183964 183964 0 0.0
.data 5240 5240 0 0.0
.heap 847240 847240 0 0.0
.text 1276608 1276680 72 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309888 2309952 64 0.0
.bss 175824 175824 0 0.0
.data 5536 5536 0 0.0
.heap 855088 855088 0 0.0
.text 1272488 1272552 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283000 2283064 64 0.0
.bss 174864 174864 0 0.0
.data 5528 5528 0 0.0
.heap 856056 856056 0 0.0
.text 1245600 1245664 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
p6 all-clusters-app default (read/write) 2360976 2361064 88 0.0
.bss 112164 112164 0 0.0
.data 2528 2528 0 0.0
.heap 918648 918648 0 0.0
.text 1319240 1319328 88 0.0
light-app default (read/write) 2301568 2301656 88 0.0
.bss 101080 101080 0 0.0
.data 2368 2368 0 0.0
.heap 929896 929896 0 0.0
.text 1259832 1259920 88 0.0
lock-app default (read/write) 2277640 2277728 88 0.0
.bss 99960 99960 0 0.0
.data 2328 2328 0 0.0
.heap 931056 931056 0 0.0
.text 1235904 1235992 88 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522236 76 0.0
(read/write) 122332 122332 0 0.0
.bss 82712 82712 0 0.0
.data 996 996 0 0.0
.text 516840 516916 76 0.0
lock-app qpg6100+debug (read only) 496532 496608 76 0.0
(read/write) 122336 122336 0 0.0
.bss 81848 81848 0 0.0
.data 952 952 0 0.0
.text 491212 491288 76 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812354 92 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 567218 567302 84 0.0

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

PR #12950: Size comparison from c8027a5 to 6b89ec9

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c8027a5 6b89ec9 change % change
efr32 lighting-app BRD4161A (read only) 816412 816500 88 0.0
.text 816404 816492 88 0.0
BRD4161A+rpc (read only) 804028 804116 88 0.0
.text 804020 804108 88 0.0
window-app BRD4161A (read only) 793488 793576 88 0.0
.text 793480 793568 88 0.0
esp32 all-clusters-app c3devkit (read only) 856964 857048 84 0.0
.flash.text 856964 857048 84 0.0
m5stack (read only) 960943 961031 88 0.0
(read/write) 450468 450476 8 0.0
.flash.rodata 210592 210600 8 0.0
.flash.text 955559 955647 88 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670496 670580 84 0.0
.text 588872 588956 84 0.0
lock-app k32w061+debug (read/write) 620432 620500 68 0.0
.text 540696 540764 68 0.0
shell k32w061+debug (read/write) 625800 625884 84 0.0
.text 543776 543860 84 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6877132 400 0.0
(read/write) 319281 319297 16 0.0
.data.rel.ro 208760 208776 16 0.0
.text 5828772 5829124 352 0.0
thermostat-no-ble arm64 (read only) 1952100 1952500 400 0.0
(read/write) 137665 137681 16 0.0
.data.rel.ro 70744 70760 16 0.0
.text 1618016 1618368 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314104 2314240 136 0.0
.text 1276680 1276816 136 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309960 2310024 64 0.0
.text 1272560 1272624 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2283072 2283136 64 0.0
.text 1245672 1245736 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907787 907855 68 0.0
rodata 102220 102224 4 0.0
text 613628 613700 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 870831 870899 68 0.0
rodata 93520 93524 4 0.0
text 588368 588440 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833790 833858 68 0.0
rodata 97480 97484 4 0.0
text 544052 544124 72 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880435 880503 68 0.0
rodata 98340 98344 4 0.0
text 593064 593136 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806674 806758 84 0.0
rodata 93628 93632 4 0.0
text 523580 523652 72 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885387 885455 68 0.0
rodata 99692 99696 4 0.0
text 596668 596740 72 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878579 878663 84 0.0
rodata 97828 97832 4 0.0
text 591864 591936 72 0.0
p6 all-clusters-app default (read/write) 2361448 2361536 88 0.0
.text 1319712 1319800 88 0.0
light-app default (read/write) 2302024 2302112 88 0.0
.text 1260288 1260376 88 0.0
lock-app default (read/write) 2278112 2278200 88 0.0
.text 1236376 1236464 88 0.0
qpg lighting-app qpg6100+debug (read only) 522192 522268 76 0.0
.text 516872 516948 76 0.0
lock-app qpg6100+debug (read only) 496540 496616 76 0.0
.text 491220 491296 76 0.0
telink lighting-app tlsr9518adk80d (read/write) 812230 812314 84 0.0
text 566982 567066 84 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c8027a5 6b89ec9 change % change
efr32 lighting-app BRD4161A (read only) 816412 816500 88 0.0
(read/write) 123208 123208 0 0.0
.bss 121344 121344 0 0.0
.data 1864 1864 0 0.0
.text 816404 816492 88 0.0
BRD4161A+rpc (read only) 804028 804116 88 0.0
(read/write) 139884 139884 0 0.0
.bss 137920 137920 0 0.0
.data 1964 1964 0 0.0
.text 804020 804108 88 0.0
window-app BRD4161A (read only) 793488 793576 88 0.0
(read/write) 122160 122160 0 0.0
.bss 120328 120328 0 0.0
.data 1828 1828 0 0.0
.text 793480 793568 88 0.0
esp32 all-clusters-app c3devkit (read only) 856964 857048 84 0.0
(read/write) 1304650 1304650 0 0.0
.dram0.bss 64752 64752 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 856964 857048 84 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960943 961031 88 0.0
(read/write) 450468 450476 8 0.0
.dram0.bss 74040 74040 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210592 210600 8 0.0
.flash.text 955559 955647 88 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670496 670580 84 0.0
.bss 73928 73928 0 0.0
.data 1896 1896 0 0.0
.text 588872 588956 84 0.0
lock-app k32w061+debug (read/write) 620432 620500 68 0.0
.bss 72080 72080 0 0.0
.data 1856 1856 0 0.0
.text 540696 540764 68 0.0
shell k32w061+debug (read/write) 625800 625884 84 0.0
.bss 74388 74388 0 0.0
.data 1836 1836 0 0.0
.text 543776 543860 84 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6877132 400 0.0
(read/write) 319281 319297 16 0.0
.bss 51873 51873 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208760 208776 16 0.0
.dynamic 560 560 0 0.0
.got 53720 53720 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366092 366092 0 0.0
.text 5828772 5829124 352 0.0
thermostat-no-ble arm64 (read only) 1952100 1952500 400 0.0
(read/write) 137665 137681 16 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70744 70760 16 0.0
.dynamic 560 560 0 0.0
.got 3672 3672 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125764 125764 0 0.0
.text 1618016 1618368 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314104 2314240 136 0.0
.bss 184020 184020 0 0.0
.data 5240 5240 0 0.0
.heap 847184 847184 0 0.0
.text 1276680 1276816 136 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309960 2310024 64 0.0
.bss 175880 175880 0 0.0
.data 5536 5536 0 0.0
.heap 855032 855032 0 0.0
.text 1272560 1272624 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283072 2283136 64 0.0
.bss 174920 174920 0 0.0
.data 5520 5520 0 0.0
.heap 856008 856008 0 0.0
.text 1245672 1245736 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907787 907855 68 0.0
bss 116352 116352 0 0.0
rodata 102220 102224 4 0.0
text 613628 613700 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 870831 870899 68 0.0
bss 112700 112700 0 0.0
rodata 93520 93524 4 0.0
text 588368 588440 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833790 833858 68 0.0
bss 117728 117728 0 0.0
rodata 97480 97484 4 0.0
text 544052 544124 72 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880435 880503 68 0.0
bss 113616 113616 0 0.0
rodata 98340 98344 4 0.0
text 593064 593136 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806674 806758 84 0.0
bss 115024 115024 0 0.0
rodata 93628 93632 4 0.0
text 523580 523652 72 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885387 885455 68 0.0
bss 113528 113528 0 0.0
rodata 99692 99696 4 0.0
text 596668 596740 72 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878579 878663 84 0.0
bss 113404 113404 0 0.0
rodata 97828 97832 4 0.0
text 591864 591936 72 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2361448 2361536 88 0.0
.bss 112220 112220 0 0.0
.data 2528 2528 0 0.0
.heap 918592 918592 0 0.0
.text 1319712 1319800 88 0.0
light-app default (read/write) 2302024 2302112 88 0.0
.bss 101136 101136 0 0.0
.data 2368 2368 0 0.0
.heap 929840 929840 0 0.0
.text 1260288 1260376 88 0.0
lock-app default (read/write) 2278112 2278200 88 0.0
.bss 100016 100016 0 0.0
.data 2328 2328 0 0.0
.heap 931000 931000 0 0.0
.text 1236376 1236464 88 0.0
qpg lighting-app qpg6100+debug (read only) 522192 522268 76 0.0
(read/write) 122332 122332 0 0.0
.bss 82768 82768 0 0.0
.data 996 996 0 0.0
.text 516872 516948 76 0.0
lock-app qpg6100+debug (read only) 496540 496616 76 0.0
(read/write) 122336 122336 0 0.0
.bss 81904 81904 0 0.0
.data 952 952 0 0.0
.text 491220 491296 76 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812230 812314 84 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566982 567066 84 0.0

@jepenven-silabs jepenven-silabs merged commit 442c639 into project-chip:master Dec 15, 2021
@rcasallas-silabs rcasallas-silabs deleted the group_data_provier_remove_group branch February 2, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants