-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Data Provider: Added method to remove GroupInfo by GroupId. #12950
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
rcasallas-silabs:group_data_provier_remove_group
Dec 15, 2021
Merged
Group Data Provider: Added method to remove GroupInfo by GroupId. #12950
jepenven-silabs
merged 2 commits into
project-chip:master
from
rcasallas-silabs:group_data_provier_remove_group
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #12950: Size comparison from 73776ef to 481545c Increases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_data_provier_remove_group
branch
from
December 14, 2021 09:19
481545c
to
6b89ec9
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns and
msandstedt
December 14, 2021 09:19
pullapprove
bot
requested review from
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
December 14, 2021 09:19
PR #12950: Size comparison from c8027a5 to 6b89ec9 Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 14, 2021
andy31415
reviewed
Dec 14, 2021
jepenven-silabs
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing function to remove a group given by group id.
Change overview
Testing