-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert OTAQueryStatus to an enum class #12918
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:convert_ota_query_status_enum_class
Dec 11, 2021
Merged
Convert OTAQueryStatus to an enum class #12918
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:convert_ota_query_status_enum_class
Dec 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #12918: Size comparison from f27c939 to dddb514 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 11, 2021
carol-apple
force-pushed
the
convert_ota_query_status_enum_class
branch
from
December 11, 2021 04:03
dddb514
to
46e8e53
Compare
pullapprove
bot
requested review from
austinh0,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia and
tecimovic
December 11, 2021 04:03
pullapprove
bot
requested review from
turon,
vijs,
wbschiller,
xylophone21,
yufengwangca and
yunhanw-google
December 11, 2021 04:03
PR #12918: Size comparison from 654c3e1 to 46e8e53 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 11, 2021
dhrishi
approved these changes
Dec 11, 2021
@carol-apple Merge conflict? |
carol-apple
force-pushed
the
convert_ota_query_status_enum_class
branch
from
December 11, 2021 20:33
46e8e53
to
1b118aa
Compare
Yeah, I think Damian merged a change last night. I resolved the conflict and will merge this once the builds are green again. |
PR #12918: Size comparison from 03c6902 to 1b118aa Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OTA Query Status is currently not an enum class
Change overview
Convert OTAQueryStatus to enum class
Testing
No behavior change, tree compiles. Manually tested OTA provider/requestor scenario to verify basic case not broken.