Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linux door-lock app #12907

Merged
merged 35 commits into from
Jan 4, 2022
Merged

Add Linux door-lock app #12907

merged 35 commits into from
Jan 4, 2022

Conversation

dustin-crossman
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Adds bare-bones linux door-lock app

Change overview

  • Linux door-lock app pulls in recently updated door-lock cluster
  • Implement LockDoor and UnlockDoor in door lock cluster code
  • Adds Linux door-lock app to github workflows

Testing

  • Manual testing using chip-tool and all-cluster-app
  • CI automated testing

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@andy31415
Copy link
Contributor

@dustin-crossman please also fix restyle issues (e.g. by running ./scripts/helpers/restyle-diff.sh), I believe reviewers are only added after that check passes.

@github-actions
Copy link

PR #12907: Size comparison from 8808d7a to 86467c8

Decreases (1 build for telink)
platform target config section 8808d7a 86467c8 change % change
telink lighting-app tlsr9518adk80d text 566528 566522 -6 -0.0
Full report (1 build for telink)
platform target config section 8808d7a 86467c8 change % change
telink lighting-app tlsr9518adk80d (read/write) 811418 811418 0 0.0
bss 82848 82848 0 0.0
noinit 37160 37160 0 0.0
text 566528 566522 -6 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Dec 11, 2021
View reviewed changes
examples/lock-app/linux/main.cpp Outdated Show resolved Hide resolved
examples/lock-app/linux/main.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/door-lock-server/door-lock-server.h Outdated Show resolved Hide resolved
@dustin-crossman dustin-crossman force-pushed the feature/door-lock-linux-app branch from 30903d2 to d83d2b5 Compare December 13, 2021 23:22
@dustin-crossman
Copy link
Contributor Author

@andy31415 Is there an alternative to running restyle? Running ./scripts/helpers/restyle-diff.sh isn't working for me (some connection error with Docker. Not sure what's wrong).

@dustin-crossman dustin-crossman force-pushed the feature/door-lock-linux-app branch 2 times, most recently from 8405ffd to 9bc8e29 Compare December 14, 2021 19:09
@dustin-crossman dustin-crossman force-pushed the feature/door-lock-linux-app branch from 7740ece to 7669372 Compare December 15, 2021 18:38
@bzbarsky-apple
Copy link
Contributor

@dustin-crossman Need to pick up restyle changes?

@stale
Copy link

stale bot commented Dec 27, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 27, 2021
@stale stale bot removed the stale Stale issue or PR label Dec 28, 2021
@github-actions
Copy link

github-actions bot commented Dec 28, 2021 •
edited
Loading

PR #12907: Size comparison from 83b2f46 to 958cd30

Increases above 0.2%:

platform target config section 83b2f46 958cd30 change % change
k32w lock k32w061+release (read/write) 632264 635576 3312 0.5
.text 548708 551968 3260 0.6
mbed lock-app CY8CPROTO_062_4343W+release .text 1264800 1268136 3336 0.3
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 907507 910831 3324 0.4
rodata 103304 104148 844 0.8
text 609460 611904 2444 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834742 3320 0.4
rodata 98268 99108 840 0.9
text 536940 539380 2440 0.5
p6 lock-app default .data 2336 2344 8 0.3
.text 1254144 1257744 3600 0.3
qpg lock-app qpg6105+debug (read only) 502876 506168 3292 0.7
.data 952 956 4 0.4
.text 497556 500848 3292 0.7
Increases (8 builds for k32w, mbed, nrfconnect, p6, qpg)
platform target config section 83b2f46 958cd30 change % change
k32w lock k32w061+release (read/write) 632264 635576 3312 0.5
.bss 75896 75944 48 0.1
.data 1860 1864 4 0.2
.text 548708 551968 3260 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338744 2339176 432 0.0
.bss 188364 188380 16 0.0
.text 1301320 1301752 432 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302200 2305536 3336 0.1
.bss 179656 179704 48 0.0
.text 1264800 1268136 3336 0.3
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 907507 910831 3324 0.4
bss 117360 117396 36 0.0
rodata 103304 104148 844 0.8
text 609460 611904 2444 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834742 3320 0.4
bss 115672 115712 40 0.0
rodata 98268 99108 840 0.9
text 536940 539380 2440 0.5
p6 all-clusters-app default (read/write) 2390856 2391472 616 0.0
.bss 116564 116580 16 0.0
.text 1349120 1349736 616 0.0
lock-app default (read/write) 2295880 2299480 3600 0.2
.bss 104736 104776 40 0.0
.data 2336 2344 8 0.3
.text 1254144 1257744 3600 0.3
qpg lock-app qpg6105+debug (read only) 502876 506168 3292 0.7
.bss 85792 85832 40 0.0
.data 952 956 4 0.4
.text 497556 500848 3292 0.7
Decreases (1 build for qpg)
platform target config section 83b2f46 958cd30 change % change
qpg lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83b2f46 958cd30 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 635576 3312 0.5
.bss 75896 75944 48 0.1
.data 1860 1864 4 0.2
.text 548708 551968 3260 0.6
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338744 2339176 432 0.0
.bss 188364 188380 16 0.0
.data 5272 5272 0 0.0
.text 1301320 1301752 432 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2305536 3336 0.1
.bss 179656 179704 48 0.0
.data 5544 5544 0 0.0
.text 1264800 1268136 3336 0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 910831 3324 0.4
bss 117360 117396 36 0.0
rodata 103304 104148 844 0.8
text 609460 611904 2444 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834742 3320 0.4
bss 115672 115712 40 0.0
rodata 98268 99108 840 0.9
text 536940 539380 2440 0.5
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2390856 2391472 616 0.0
.bss 116564 116580 16 0.0
.data 2552 2552 0 0.0
.text 1349120 1349736 616 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2299480 3600 0.2
.bss 104736 104776 40 0.0
.data 2336 2344 8 0.3
.text 1254144 1257744 3600 0.3
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 506168 3292 0.7
(read/write) 146940 146936 -4 -0.0
.bss 85792 85832 40 0.0
.data 952 956 4 0.4
.text 497556 500848 3292 0.7
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 29, 2021 •
edited
Loading

PR #12907: Size comparison from eab67b3 to 3e901ef

Increases above 0.2%:

platform target config section eab67b3 3e901ef change % change
k32w lock k32w061+release (read/write) 632264 635540 3276 0.5
.data 1860 1868 8 0.4
.text 548708 551936 3228 0.6
p6 all-clusters-app default .data 2552 2560 8 0.3
lock-app default .data 2336 2344 8 0.3
.text 1254144 1257688 3544 0.3
qpg lock-app qpg6105+debug (read only) 502876 506152 3276 0.7
.data 952 960 8 0.8
.text 497556 500832 3276 0.7
Increases (4 builds for k32w, p6, qpg)
platform target config section eab67b3 3e901ef change % change
k32w lock k32w061+release (read/write) 632264 635540 3276 0.5
.bss 75896 75936 40 0.1
.data 1860 1868 8 0.4
.text 548708 551936 3228 0.6
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
lock-app default (read/write) 2295880 2299424 3544 0.2
.bss 104736 104768 32 0.0
.data 2336 2344 8 0.3
.text 1254144 1257688 3544 0.3
qpg lock-app qpg6105+debug (read only) 502876 506152 3276 0.7
.bss 85792 85824 32 0.0
.data 952 960 8 0.8
.text 497556 500832 3276 0.7
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section eab67b3 3e901ef change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 635540 3276 0.5
.bss 75896 75936 40 0.1
.data 1860 1868 8 0.4
.text 548708 551936 3228 0.6
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2299424 3544 0.2
.bss 104736 104768 32 0.0
.data 2336 2344 8 0.3
.text 1254144 1257688 3544 0.3
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 506152 3276 0.7
(read/write) 146940 146940 0 0.0
.bss 85792 85824 32 0.0
.data 952 960 8 0.8
.text 497556 500832 3276 0.7
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 29, 2021 •
edited
Loading

PR #12907: Size comparison from eab67b3 to 673e18f

Increases above 0.2%:

platform target config section eab67b3 673e18f change % change
k32w lock k32w061+release (read/write) 632264 635752 3488 0.6
.data 1860 1868 8 0.4
.text 548708 552148 3440 0.6
mbed lock-app CY8CPROTO_062_4343W+release .text 1264800 1268264 3464 0.3
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 907507 911019 3512 0.4
rodata 103304 104152 848 0.8
text 609460 612092 2632 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834946 3524 0.4
rodata 98268 99112 844 0.9
text 536940 539572 2632 0.5
p6 all-clusters-app default .data 2552 2560 8 0.3
lock-app default .data 2336 2344 8 0.3
.text 1254144 1257936 3792 0.3
qpg lock-app qpg6105+debug (read only) 502876 506364 3488 0.7
.data 952 960 8 0.8
.text 497556 501044 3488 0.7
Increases (8 builds for k32w, mbed, nrfconnect, p6, qpg)
platform target config section eab67b3 673e18f change % change
k32w lock k32w061+release (read/write) 632264 635752 3488 0.6
.bss 75896 75936 40 0.1
.data 1860 1868 8 0.4
.text 548708 552148 3440 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338944 2339368 424 0.0
.bss 188364 188372 8 0.0
.data 5272 5280 8 0.2
.text 1301520 1301944 424 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302200 2305664 3464 0.2
.bss 179656 179696 40 0.0
.data 5544 5552 8 0.1
.text 1264800 1268264 3464 0.3
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 907507 911019 3512 0.4
bss 117360 117388 28 0.0
rodata 103304 104152 848 0.8
text 609460 612092 2632 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834946 3524 0.4
bss 115672 115704 32 0.0
rodata 98268 99112 844 0.9
text 536940 539572 2632 0.5
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
lock-app default (read/write) 2295880 2299672 3792 0.2
.bss 104736 104768 32 0.0
.data 2336 2344 8 0.3
.text 1254144 1257936 3792 0.3
qpg lock-app qpg6105+debug (read only) 502876 506364 3488 0.7
.bss 85792 85824 32 0.0
.data 952 960 8 0.8
.text 497556 501044 3488 0.7
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eab67b3 673e18f change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 635752 3488 0.6
.bss 75896 75936 40 0.1
.data 1860 1868 8 0.4
.text 548708 552148 3440 0.6
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338944 2339368 424 0.0
.bss 188364 188372 8 0.0
.data 5272 5280 8 0.2
.text 1301520 1301944 424 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2305664 3464 0.2
.bss 179656 179696 40 0.0
.data 5544 5552 8 0.1
.text 1264800 1268264 3464 0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 911019 3512 0.4
bss 117360 117388 28 0.0
rodata 103304 104152 848 0.8
text 609460 612092 2632 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834946 3524 0.4
bss 115672 115704 32 0.0
rodata 98268 99112 844 0.9
text 536940 539572 2632 0.5
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2299672 3792 0.2
.bss 104736 104768 32 0.0
.data 2336 2344 8 0.3
.text 1254144 1257936 3792 0.3
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 506364 3488 0.7
(read/write) 146940 146940 0 0.0
.bss 85792 85824 32 0.0
.data 952 960 8 0.8
.text 497556 501044 3488 0.7
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 29, 2021 •
edited
Loading

PR #12907: Size comparison from eab67b3 to ef7b9cd

Increases above 0.2%:

platform target config section eab67b3 ef7b9cd change % change
k32w lock k32w061+release (read/write) 632264 635752 3488 0.6
.data 1860 1868 8 0.4
.text 548708 552148 3440 0.6
mbed lock-app CY8CPROTO_062_4343W+release .text 1264800 1268264 3464 0.3
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 907507 911019 3512 0.4
rodata 103304 104152 848 0.8
text 609460 612092 2632 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834946 3524 0.4
rodata 98268 99112 844 0.9
text 536940 539572 2632 0.5
p6 all-clusters-app default .data 2552 2560 8 0.3
lock-app default .data 2336 2344 8 0.3
.text 1254144 1257936 3792 0.3
qpg lock-app qpg6105+debug (read only) 502876 506364 3488 0.7
.data 952 960 8 0.8
.text 497556 501044 3488 0.7
Increases (8 builds for k32w, mbed, nrfconnect, p6, qpg)
platform target config section eab67b3 ef7b9cd change % change
k32w lock k32w061+release (read/write) 632264 635752 3488 0.6
.bss 75896 75936 40 0.1
.data 1860 1868 8 0.4
.text 548708 552148 3440 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338944 2339368 424 0.0
.bss 188364 188372 8 0.0
.data 5272 5280 8 0.2
.text 1301520 1301944 424 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302200 2305664 3464 0.2
.bss 179656 179696 40 0.0
.data 5544 5552 8 0.1
.text 1264800 1268264 3464 0.3
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 907507 911019 3512 0.4
bss 117360 117388 28 0.0
rodata 103304 104152 848 0.8
text 609460 612092 2632 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834946 3524 0.4
bss 115672 115704 32 0.0
rodata 98268 99112 844 0.9
text 536940 539572 2632 0.5
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
lock-app default (read/write) 2295880 2299672 3792 0.2
.bss 104736 104768 32 0.0
.data 2336 2344 8 0.3
.text 1254144 1257936 3792 0.3
qpg lock-app qpg6105+debug (read only) 502876 506364 3488 0.7
.bss 85792 85824 32 0.0
.data 952 960 8 0.8
.text 497556 501044 3488 0.7
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eab67b3 ef7b9cd change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 635752 3488 0.6
.bss 75896 75936 40 0.1
.data 1860 1868 8 0.4
.text 548708 552148 3440 0.6
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338944 2339368 424 0.0
.bss 188364 188372 8 0.0
.data 5272 5280 8 0.2
.text 1301520 1301944 424 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2305664 3464 0.2
.bss 179656 179696 40 0.0
.data 5544 5552 8 0.1
.text 1264800 1268264 3464 0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 911019 3512 0.4
bss 117360 117388 28 0.0
rodata 103304 104152 848 0.8
text 609460 612092 2632 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 831422 834946 3524 0.4
bss 115672 115704 32 0.0
rodata 98268 99112 844 0.9
text 536940 539572 2632 0.5
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2299672 3792 0.2
.bss 104736 104768 32 0.0
.data 2336 2344 8 0.3
.text 1254144 1257936 3792 0.3
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 506364 3488 0.7
(read/write) 146940 146940 0 0.0
.bss 85792 85824 32 0.0
.data 952 960 8 0.8
.text 497556 501044 3488 0.7
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 29, 2021 •
edited
Loading

PR #12907: Size comparison from eab67b3 to 9488a34

Increases above 0.2%:

platform target config section eab67b3 9488a341 change % change
p6 all-clusters-app default .data 2552 2560 8 0.3
Increases (4 builds for esp32, mbed, p6)
platform target config section eab67b3 9488a341 change % change
esp32 all-clusters-app c3devkit (read only) 882900 883300 400 0.0
(read/write) 1312498 1312554 56 0.0
.dram0.bss 69104 69112 8 0.0
.dram0.data 14228 14236 8 0.1
.flash.rodata 176104 176144 40 0.0
.flash.text 882900 883300 400 0.0
m5stack (read only) 943439 943823 384 0.0
(read/write) 441600 441648 48 0.0
.dram0.data 34056 34064 8 0.0
.flash.rodata 202936 202976 40 0.0
.flash.text 938055 938439 384 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338944 2339368 424 0.0
.bss 188364 188372 8 0.0
.data 5272 5280 8 0.2
.text 1301520 1301944 424 0.0
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eab67b3 9488a341 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 882900 883300 400 0.0
(read/write) 1312498 1312554 56 0.0
.dram0.bss 69104 69112 8 0.0
.dram0.data 14228 14236 8 0.1
.flash.rodata 176104 176144 40 0.0
.flash.text 882900 883300 400 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 943439 943823 384 0.0
(read/write) 441600 441648 48 0.0
.dram0.bss 73600 73600 0 0.0
.dram0.data 34056 34064 8 0.0
.flash.rodata 202936 202976 40 0.0
.flash.text 938055 938439 384 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647440 647440 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563552 563552 0 0.0
lock k32w061+release (read/write) 632264 632264 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548708 548708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338944 2339368 424 0.0
.bss 188364 188372 8 0.0
.data 5272 5280 8 0.2
.text 1301520 1301944 424 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2302200 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264800 1264800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907507 0 0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609460 609460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831422 831422 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536940 536940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2391112 2391656 544 0.0
.bss 116564 116572 8 0.0
.data 2552 2560 8 0.3
.text 1349376 1349920 544 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@andy31415
Copy link
Contributor

/rebase

@andy31415 andy31415 merged commit b006321 into project-chip:master Jan 4, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@dustin-crossman @Morozov-5F @step0035
Add Linux door-lock app (project-chip#12907)
bf6e561 
* Add linux lock app stub.

* Add LockManager to linux lock app

* Add linux door-lock app to github workflows.

* Add door lock cluster to door lock app zap.

* Regen auto-generated stuff.

* Working on door-lock implementation.

* Update a couple auto-generated files.
Remove deleted include file.
Updating lock-app.zap with more commands and regen files.

* More door-lock fixes/improvements.

* Cleaning up lock app a bit.

* Add linux lock app to build_examples.py script and use it in github workflows.

* Addressing review feedback.

* Fixup some auto-generated files.

* Ran through clang-format.

* Regen files.

* More review feedback.

* Restyle gn files.

* Added weak definitions for Lock/Unlock commands.

* Addressing review feedback.

* Restyle

* Quick fix.

* Fix format strings in Door Lock cluster

* Add Door Lock Cluster to an mbedOS build

* Fix format strings and parameter usage

* Add placeholder README.md

* Make lock-app to build on Darwin

* Fix Linux Build tests by adding appropriate targets

* Fix formatting in README for linux lock app

* Use proper path for Linux lock app in CI

* Fix build errors on ESP32

* Update auto-generated files

* Fix ESP32 build lock-app build

* Move door lock app to the separate example

* Fix styling issues

Co-authored-by: Morozov-5F <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jrhees-cae jrhees-cae jrhees-cae approved these changes

@andy31415 andy31415 andy31415 approved these changes

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples github review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dustin-crossman @CLAassistant @andy31415 @bzbarsky-apple @jrhees-cae @Morozov-5F